Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/FBookkeeping/FBookkeeping.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Define a constant instead of duplicating this literal "fbookkeepingid" 4 times.
Open

    public $table_index = 'fbookkeepingid';
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "u_yf_fbookkeeping" 3 times.
Open

    public $table_name = 'u_yf_fbookkeeping';
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "u_yf_fbookkeepingcf" 3 times.
Open

    public $customFieldTable = ['u_yf_fbookkeepingcf', 'fbookkeepingid'];
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "vtiger_crmentity" 3 times.
Open

    public $tab_name = ['vtiger_crmentity', 'u_yf_fbookkeeping', 'u_yf_fbookkeepingcf'];
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "assigned_user_id" 3 times.
Open

        'Assigned To' => 'assigned_user_id',
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "subject" 8 times.
Open

        'subject' => 'subject',
Severity: Critical
Found in modules/FBookkeeping/FBookkeeping.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Avoid excessively long variable names like $def_detailview_recname. Keep variable name length under 20.
Open

    public $def_detailview_recname = 'subject';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class FBookkeeping extends Vtiger_CRMEntity
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 14 and the first side effect is on line 12.
Open

<?php
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

The property $table_name is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $tab_name is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $table_index is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $def_detailview_recname is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $tab_name_index is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $default_order_by is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $search_fields is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $search_fields_name is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $popup_fields is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $default_sort_order is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $def_basicsearch_col is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $mandatory_fields is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $list_fields_name is not named in camelCase.
Open

class FBookkeeping extends Vtiger_CRMEntity
{
    public $table_name = 'u_yf_fbookkeeping';
    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    public $table_name = 'u_yf_fbookkeeping';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $mandatory_fields = ['subject', 'assigned_user_id'];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        // Format: Field Label => fieldname
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $table_index = 'fbookkeepingid';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Mandatory table for supporting custom fields.
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $customFieldTable = ['u_yf_fbookkeepingcf', 'fbookkeepingid'];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        // tablename should not have prefix 'vtiger_'
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // Used when enabling/disabling the mandatory fields for the module.
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'u_yf_fbookkeepingcf' => 'fbookkeepingid', ];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $def_basicsearch_col = 'subject';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $tab_name = ['vtiger_crmentity', 'u_yf_fbookkeeping', 'u_yf_fbookkeepingcf'];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // For Popup listview and UI type support
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $search_fields = [
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $def_detailview_recname = 'subject';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $search_fields_name = [];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $relationFields = [];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'Assigned To' => ['vtiger_crmentity', 'assigned_user_id'],
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'subject' => ['fbookkeeping', 'subject'],
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $tab_name_index = [
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // Column value to use on detail view record text display
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $default_order_by = '';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Mandatory for Saving, Include tables related to this module.
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @var string[] List of fields in the RelationListView
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $popup_fields = ['subject'];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // Refers to vtiger_field.fieldname values.
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'u_yf_fbookkeeping' => 'fbookkeepingid',
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // For Alphabetical search
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'Assigned To' => 'assigned_user_id',
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Mandatory for Saving, Include tablename and tablekey columnname here.
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $default_sort_order = 'ASC';
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'vtiger_crmentity' => 'crmid',
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public $list_fields_name = [
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    // For Popup window record selection
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        'subject' => 'subject',
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        // Format: Field Label => Array(tablename, columnname)
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ];
Severity: Minor
Found in modules/FBookkeeping/FBookkeeping.php by phpcodesniffer

There are no issues that match your filters.

Category
Status