Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/FInvoice/dashboards/SummationByMonths.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
0%

Method getWidgetData has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getWidgetData($moduleName, $owner)
    {
        $rawData = $data = $years = [];
        $dateStart = ((int) date('Y') - 2) . '-01-01';
        $dateEnd = date('Y-m-d', strtotime('last day of december'));
Severity: Major
Found in modules/FInvoice/dashboards/SummationByMonths.php - About 2 hrs to fix

    Function getWidgetData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getWidgetData($moduleName, $owner)
    {
        $rawData = $data = $years = [];
        $dateStart = ((int) date('Y') - 2) . '-01-01';
        $dateEnd = date('Y-m-d', strtotime('last day of december'));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonths.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonths.php - About 1 hr to fix

      Method getFilterFields has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFilterFields($moduleName): array
    {
        if (!isset($this->filterFields)) {
            $this->filterFields = [];
            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
      Severity: Minor
      Found in modules/FInvoice/dashboards/SummationByMonths.php - About 1 hr to fix

        Function getFilterFields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getFilterFields($moduleName): array
    {
        if (!isset($this->filterFields)) {
            $this->filterFields = [];
            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method getWidgetData() has an NPath complexity of 448. The configured NPath complexity threshold is 200.
        Open

            public function getWidgetData($moduleName, $owner)
    {
        $rawData = $data = $years = [];
        $dateStart = ((int) date('Y') - 2) . '-01-01';
        $dateEnd = date('Y-m-d', strtotime('last day of december'));
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method getWidgetData() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            public function getWidgetData($moduleName, $owner)
    {
        $rawData = $data = $years = [];
        $dateStart = ((int) date('Y') - 2) . '-01-01';
        $dateEnd = date('Y-m-d', strtotime('last day of december'));
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Missing class import via use statement (line '110', column '12').
        Open

                $y = new \yii\db\Expression('extract(year FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '111', column '12').
        Open

                $m = new \yii\db\Expression('extract(month FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '112', column '12').
        Open

                $s = new \yii\db\Expression("SUM({$sumColumnName})");
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '69', column '17').
        Open

                    $field = new \Vtiger_Field_Model();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '119', column '40').
        Open

                $queryGenerator->setCustomGroup([new \yii\db\Expression('y'), new \yii\db\Expression('m')]);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '108', column '25').
        Open

                $queryGenerator = new \App\QueryGenerator($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '119', column '69').
        Open

                $queryGenerator->setCustomGroup([new \yii\db\Expression('y'), new \yii\db\Expression('m')]);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid using static access to class 'Vtiger_Module_Model' in method 'getFilterFields'.
        Open

                    $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $viewer->view('dashboards/SummationByMonths.tpl', $moduleName);
        }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class '\App\Language' in method 'getFilterFields'.
        Open

                        $picklistValues[$fieldModelGross->getColumnName()] = \App\Language::translate($fieldModelGross->getFieldLabel(), $fieldModelGross->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $owner = $request->getByType('owner', \App\Purifier::TEXT);
        }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '33', column '57').
        Open

            public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\App\User' in method 'process'.
        Open

                $currentUserId = \App\User::getCurrentUserId();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'App\Language' in method 'getWidgetData'.
        Open

                    $chartData['labels'][] = App\Language::translate($shortMonth[$i]);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Language' in method 'getFilterFields'.
        Open

                        $picklistValues[$fieldModel->getColumnName()] = \App\Language::translate($fieldModel->getFieldLabel(), $fieldModel->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
        Open

                    $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Colors' in method 'getWidgetData'.
        Open

                            $yearsData[$y]['backgroundColor'][] = \App\Colors::getRandomColor($y * 10);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
        Open

                $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Language' in method 'getWidgetData'.
        Open

                            'label' => \App\Language::translate('LBL_YEAR', $moduleName) . ' ' . $y,
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Define a constant instead of duplicating this literal "fieldvalue" 4 times.
        Open

                        $fieldModel->set('fieldvalue', $value);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by sonar-php

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

        Compliant Solution

        ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Define a constant instead of duplicating this literal "sum_field" 3 times.
        Open

                    $field->set('name', 'sum_field')
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by sonar-php

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

        Compliant Solution

        ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Reference to undeclared property \FInvoice_SummationByMonths_Dashboard->filterFields
        Open

                return $this->filterFields;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method __construct from undeclared class \yii\db\Expression
        Open

                $y = new \yii\db\Expression('extract(year FROM saledate)');
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method getInstance from undeclared class \App\Fields\Owner
        Open

                $accessibleGroups = \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule();
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method __construct from undeclared class \yii\db\Expression
        Open

                $queryGenerator->setCustomGroup([new \yii\db\Expression('y'), new \yii\db\Expression('m')]);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method setCustomGroup from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $queryGenerator->setCustomGroup([new \yii\db\Expression('y'), new \yii\db\Expression('m')]);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method getInstance from undeclared class \Vtiger_Widget_Model
        Open

                $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method __construct from undeclared class \yii\db\Expression
        Open

                $m = new \yii\db\Expression('extract(month FROM saledate)');
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('ACCESSIBLE_GROUPS', $accessibleGroups);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Reference to undeclared property \FInvoice_SummationByMonths_Dashboard->filterFields
        Open

                if (!isset($this->filterFields)) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Reference to undeclared property \FInvoice_SummationByMonths_Dashboard->filterFields
        Open

                    $this->filterFields = [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method setCustomColumn from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $queryGenerator->setCustomColumn($fieldList);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('WIDGET', $widget);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Reference to undeclared property \FInvoice_SummationByMonths_Dashboard->filterFields
        Open

                        $this->filterFields[$field->getName()] = $field;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
        Open

                $currentUserId = \App\User::getCurrentUserId();
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('FILTER_FIELDS', $fields);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to deprecated function \Vtiger_Field_Model::getFieldLabel() defined at /code/modules/Vtiger/models/Field.php:215
        Open

                        $picklistValues[$fieldModel->getColumnName()] = \App\Language::translate($fieldModel->getFieldLabel(), $fieldModel->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('DATA', $data);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method getInstance from undeclared class \App\Fields\Owner
        Open

                $accessibleUsers = \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule();
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to deprecated function \Vtiger_Field_Model::getFieldLabel() defined at /code/modules/Vtiger/models/Field.php:215
        Open

                        $picklistValues[$fieldModelGross->getColumnName()] = \App\Language::translate($fieldModelGross->getFieldLabel(), $fieldModelGross->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method addCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $queryGenerator->addCondition('saledate', $date, 'bw');
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('OWNER', $owner);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('MODULE_NAME', $moduleName);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('ACCESSIBLE_USERS', $accessibleUsers);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to undeclared method \Vtiger_Viewer::assign
        Open

                $viewer->assign('USER_CONDITIONS', $this->conditions);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method addCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $queryGenerator->addCondition('assigned_user_id', $owner, 'e');
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Assigning array{condition:array{0:'between',1:'saledate',2:string,3:string}} to property but \FInvoice_SummationByMonths_Dashboard->conditions is false
        Open

                $this->conditions = ['condition' => ['between', 'saledate', $dateStart, $dateEnd]];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method __construct from undeclared class \yii\db\Expression
        Open

                $s = new \yii\db\Expression("SUM({$sumColumnName})");
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $queryGenerator = new \App\QueryGenerator($moduleName);
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Call to method createQuery from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $query = $queryGenerator->createQuery();
        Severity: Critical
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phan

        Each class must be in a namespace of at least one level (a top-level vendor name)
        Open

        class FInvoice_SummationByMonths_Dashboard extends Vtiger_IndexAjax_View
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        The class FInvoice_SummationByMonths_Dashboard is not named in CamelCase.
        Open

        class FInvoice_SummationByMonths_Dashboard extends Vtiger_IndexAjax_View
{
    private $conditions = false;

    /**
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        CamelCaseClassName

        Since: 0.2

        It is considered best practice to use the CamelCase notation to name classes.

        Example

        class class_name {
}

        Source

        Avoid variables with short names like $m. Configured minimum length is 3.
        Open

                $m = new \yii\db\Expression('extract(month FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $y. Configured minimum length is 3.
        Open

                $y = new \yii\db\Expression('extract(year FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $s. Configured minimum length is 3.
        Open

                $s = new \yii\db\Expression("SUM({$sumColumnName})");
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Process.
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $fields = $this->getFilterFields($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $accessibleGroups = \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('ACCESSIBLE_GROUPS', $accessibleGroups);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @return \Vtiger_Field_Model[]
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $dateEnd = date('Y-m-d', strtotime('last day of december'));
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public function process(App\Request $request)
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if (!$request->has('owner')) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('DATA', $data);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $this->filterFields = [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $fieldModelGross = $moduleModel->getFieldByName('sum_gross');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if ('all' !== $owner) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param string $moduleName
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $picklistValues[$fieldModel->getColumnName()] = \App\Language::translate($fieldModel->getFieldLabel(), $fieldModel->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @return array
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $owner = $request->getByType('owner', \App\Purifier::TEXT);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $fieldModel->set('fieldvalue', $value);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $viewer->view('dashboards/SummationByMonthsContents.tpl', $moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $field = new \Vtiger_Field_Model();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->set('column', 'sum_field')
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public function getWidgetData($moduleName, $owner)
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $currentUserId = \App\User::getCurrentUserId();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Line exceeds 120 characters; contains 172 characters
        Open

                    if ($request->has($fieldModel->getName()) && '' !== ($value = $request->getForSql($fieldModel->getName())) && isset($fieldModel->getPicklistValues()[$value])) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $rawData = $data = $years = [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $queryGenerator->addCondition('saledate', $date, 'bw');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('USER_CONDITIONS', $this->conditions);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                return $this->filterFields;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $this->conditions = ['condition' => ['between', 'saledate', $dateStart, $dateEnd]];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $tempData[$y][$m] = 0;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($request->has($fieldModel->getName()) && '' !== ($value = $request->getForSql($fieldModel->getName())) && isset($fieldModel->getPicklistValues()[$value])) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if ($request->has('content')) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $viewer->view('dashboards/SummationByMonths.tpl', $moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Gets filter fields.
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $fieldModel = $moduleModel->getFieldByName('sum_total');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $field->set('name', 'sum_field')
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->set('label', 'DW_SUM_FIELD')
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $moduleName = $request->getModule();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('WIDGET', $widget);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Line exceeds 120 characters; contains 164 characters
        Open

                        $picklistValues[$fieldModelGross->getColumnName()] = \App\Language::translate($fieldModelGross->getFieldLabel(), $fieldModelGross->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                } else {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $queryGenerator = new \App\QueryGenerator($moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param int|string $owner
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    'LBL_Jul', 'LBL_Aug', 'LBL_Sep', 'LBL_Oct', 'LBL_Nov', 'LBL_Dec', ];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $y = new \yii\db\Expression('extract(year FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $years[] = $y;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            'backgroundColor' => [],
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $yearsData[$y]['stack'] = (string) $y;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                return $chartData;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            private $conditions = false;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer = $this->getViewer($request);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if (!isset($this->filterFields)) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $field->set('fieldvalue', $fieldModel->getColumnName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $sumColumnName = $this->getFilterFields($moduleName)['sum_field']->get('fieldvalue') ?: 'sum_gross';
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('MODULE_NAME', $moduleName);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $fieldList = ['y' => $y, 'm' => $m, 's' => $s];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($fieldModel && $fieldModel->isActiveField()) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        for ($m = 0; $m < 12; ++$m) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    'show_chart' => false,
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public function getFilterFields($moduleName): array
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->set('icon', 'mdi mdi-sigma')
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $date = "{$dateStart},{$dateEnd}";
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $s = new \yii\db\Expression("SUM({$sumColumnName})");
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $queryGenerator->addCondition('assigned_user_id', $owner, 'e');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    'datasets' => [],
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param \App\Request $request
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($fieldModelGross && $fieldModelGross->isActiveField()) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $this->filterFields[$field->getName()] = $field;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $dataReader->close();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (!isset($yearsData[$y])) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $tempData[$y][$m - 1] = $value[0];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                foreach ($tempData as $year => $yearData) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                } else {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->set('fromOutsideList', true)
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->set('uitype', 16)
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                while ($row = $dataReader->read()) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $picklistValues[$fieldModelGross->getColumnName()] = \App\Language::translate($fieldModelGross->getFieldLabel(), $fieldModelGross->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            'label' => \App\Language::translate('LBL_YEAR', $moduleName) . ' ' . $y,
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Get widget data.
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $m = new \yii\db\Expression('extract(month FROM saledate)');
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $yearsData = $tempData = [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $chartData['show_chart'] = (bool) \count($rawData);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $shortMonth = ['LBL_Jan', 'LBL_Feb', 'LBL_Mar', 'LBL_Apr', 'LBL_May', 'LBL_Jun',
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $chartData['datasets'][] = $data;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $dataReader = $query->createCommand()->query();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $rawData[$row['y']][$row['m']] = [round((float) $row['s'], 2)];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                for ($i = 0; $i < 12; ++$i) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $years = array_values(array_unique($years));
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $yearsData[$y] = [
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $yearsData[$year]['data'] = $yearData;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $data = $fields ? $this->getWidgetData($moduleName, $owner) : [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param string     $moduleName
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $queryGenerator->setCustomColumn($fieldList);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $query = $queryGenerator->createQuery();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $chartData = [
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            'data' => [],
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                foreach ($yearsData as $data) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                ];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                foreach ($rawData as $y => $raw) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    foreach ($raw as $m => $value) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('OWNER', $owner);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('ACCESSIBLE_USERS', $accessibleUsers);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($picklistValues) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $field->set('picklistValues', $picklistValues);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $queryGenerator->setCustomGroup([new \yii\db\Expression('y'), new \yii\db\Expression('m')]);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $chartData['years'] = $years;
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                foreach ($fields as $fieldModel) {
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $accessibleUsers = \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule();
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $viewer->assign('FILTER_FIELDS', $fields);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        ->setModule($moduleModel);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $picklistValues = [];
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Line exceeds 120 characters; contains 149 characters
        Open

                        $picklistValues[$fieldModel->getColumnName()] = \App\Language::translate($fieldModel->getFieldLabel(), $fieldModel->getModuleName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $field->set('fieldvalue', $fieldModelGross->getColumnName());
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $dateStart = ((int) date('Y') - 2) . '-01-01';
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    'labels' => [],
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $chartData['labels'][] = App\Language::translate($shortMonth[$i]);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $yearsData[$y]['backgroundColor'][] = \App\Colors::getRandomColor($y * 10);
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        Class name "FInvoice_SummationByMonths_Dashboard" is not in camel caps format
        Open

        class FInvoice_SummationByMonths_Dashboard extends Vtiger_IndexAjax_View
        Severity: Minor
        Found in modules/FInvoice/dashboards/SummationByMonths.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status