Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/FInvoice/dashboards/SummationByMonthsModel.php

Summary

Maintainability
A
3 hrs
Test Coverage
F
0%

Method getFieldInstanceByName has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFieldInstanceByName($name)
    {
        if (!isset($this->customFields[$name])) {
            return parent::getFieldInstanceByName($name);
        }
Severity: Minor
Found in modules/FInvoice/dashboards/SummationByMonthsModel.php - About 1 hr to fix

    Function setDataFromRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function setDataFromRequest(App\Request $request)
    {
        parent::setDataFromRequest($request);
        foreach ($this->customFields as $fieldName => $fieldInfo) {
            if ($request->has($fieldName)) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getFieldInstanceByName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getFieldInstanceByName($name)
    {
        if (!isset($this->customFields[$name])) {
            return parent::getFieldInstanceByName($name);
        }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
    Open

        public function setDataFromRequest(App\Request $request)
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_Field_Model' in method 'getFieldInstanceByName'.
    Open

            return \Vtiger_Field_Model::init($moduleName, $params, $name);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $this->set('data', \App\Json::encode($data));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'setDataFromRequest'.
    Open

                            $this->set('owners', \App\Json::encode($owners));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getFieldInstanceByName'.
    Open

                    $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'.
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getFieldInstanceByName'.
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "owners" 5 times.
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "label" 6 times.
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "purifyType" 5 times.
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "owners_all" 3 times.
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "plotTickSize" 3 times.
    Open

            'plotTickSize' => ['label' => 'LBL_TICK_SIZE', 'purifyType' => \App\Purifier::TEXT],
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "plotLimit" 3 times.
    Open

            'plotLimit' => ['label' => 'LBL_MAXIMUM_VALUE', 'purifyType' => \App\Purifier::TEXT]
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::get
    Open

                    $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::set
    Open

                            $this->set('data', \App\Json::encode($data));
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Reference to undeclared property \FInvoice_SummationByMonthsModel_Dashboard->editFields
    Open

            return $this->editFields + $fields + $this->customFields;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Class extends undeclared class \Vtiger_Widget_Model
    Open

    class FInvoice_SummationByMonthsModel_Dashboard extends Vtiger_Widget_Model
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Reference to undeclared class \Vtiger_Widget_Model
    Open

                return parent::getFieldInstanceByName($name);
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::get
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::get
    Open

                            $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::set
    Open

                            $this->set('owners', \App\Json::encode($owners));
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Reference to undeclared class \Vtiger_Widget_Model
    Open

            parent::setDataFromRequest($request);
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Call to undeclared method \FInvoice_SummationByMonthsModel_Dashboard::get
    Open

                            $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Critical
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phan

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                        case 'owners_all':
                        $value = $value ? explode(' |##| ', $value) : [];
                        $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
                        $owners['available'] = $value;
                        $this->set('owners', \App\Json::encode($owners));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php and 1 other location - About 35 mins to fix
    modules/Vtiger/dashboards/MiniListModel.php on lines 97..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long class names like FInvoice_SummationByMonthsModel_Dashboard. Keep class name length under 40.
    Open

    class FInvoice_SummationByMonthsModel_Dashboard extends Vtiger_Widget_Model
{
    /** {@inheritdoc} */
    public $customFields = [
        'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class FInvoice_SummationByMonthsModel_Dashboard extends Vtiger_Widget_Model
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    The class FInvoice_SummationByMonthsModel_Dashboard is not named in CamelCase.
    Open

    class FInvoice_SummationByMonthsModel_Dashboard extends Vtiger_Widget_Model
{
    /** {@inheritdoc} */
    public $customFields = [
        'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Terminating statement must be on a line by itself
    Open

                        default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    The DEFAULT body must start on the line following the statement
    Open

                default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Terminating statement must be on a line by itself
    Open

                default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    The DEFAULT body must start on the line following the statement
    Open

                        default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'plotLimit' => ['label' => 'LBL_MAXIMUM_VALUE', 'purifyType' => \App\Purifier::TEXT]
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $fields['default_owner'] = ['label' => 'LBL_DEFAULT_FILTER', 'purifyType' => \App\Purifier::STANDARD];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function setDataFromRequest(App\Request $request)
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['uitype'] = 7;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'groups' => 'LBL_GROUPS',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!isset($this->customFields[$name])) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'tooltip' => $this->getEditFields()[$name]['tooltip'] ?? ''
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                case 'plotLimit':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['maximumlength'] = '100';
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['fieldvalue'] = implode(' |##| ', $value);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = 'Settings:WidgetsManagement';
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['typeofdata'] = 'I~M';
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $fieldModel->getDBValue($value);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return parent::getFieldInstanceByName($name);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'groupUsers' => 'LBL_GROUP_USERS',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'rsUsers' => 'LBL_ROLE_AND_SUBORDINATES_USERS'
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $this->set('owners', \App\Json::encode($owners));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $this->editFields + $fields + $this->customFields;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getFieldInstanceByName($name)
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return \Vtiger_Field_Model::init($moduleName, $params, $name);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $customFields = [
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($this->customFields as $fieldName => $fieldInfo) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $data = $this->get('data') ? \App\Json::decode($this->get('data')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $value = $value ? explode(' |##| ', $value) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getEditFields(): array
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'label' => $this->getEditFields()[$name]['label'],
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldModel->validate($value, true);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'plotTickSize' => ['label' => 'LBL_TICK_SIZE', 'purifyType' => \App\Purifier::TEXT],
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'mine' => 'LBL_MINE',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $request->getByType($fieldName, $fieldInfo['purifyType']);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $data[$fieldName] = $value;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $this->set('data', \App\Json::encode($data));
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $fields = [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            switch ($name) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $picklistValue = [
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'plotLimit':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'owners_all' => ['label' => 'LBL_FILTERS_AVAILABLE', 'purifyType' => \App\Purifier::STANDARD],
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'name' => $name,
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                case 'plotTickSize':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['maximumlength'] = '0,99999999999';
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['uitype'] = 33;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['typeofdata'] = 'V~M';
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'users' => 'LBL_USERS',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'roleUsers' => 'LBL_ROLE_USERS',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach ($picklistValue as $key => $label) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $params['picklistValues'][$key] = \App\Language::translate($label, $moduleName);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($request->has($fieldName)) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                case 'owners_all':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            parent::setDataFromRequest($request);
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'owners_all':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $params = [
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $params['fieldvalue'] = $data[$name] ?? 0;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    switch ($fieldName) {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $owners = $this->get('owners') ? \App\Json::decode($this->get('owners')) : [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'all' => 'LBL_ALL',
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'plotTickSize':
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $owners['available'] = $value;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        ];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $value = $owners['available'] ?? [];
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Class name "FInvoice_SummationByMonthsModel_Dashboard" is not in camel caps format
    Open

    class FInvoice_SummationByMonthsModel_Dashboard extends Vtiger_Widget_Model
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Closing brace must be on a line by itself
    Open

                default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    Closing brace must be on a line by itself
    Open

                        default: break;
    Severity: Minor
    Found in modules/FInvoice/dashboards/SummationByMonthsModel.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status