Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/HelpDesk/dashboards/ClosedTicketsByPriority.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method getTicketsByPriority has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getTicketsByPriority($time, $owner)
    {
        $moduleName = 'HelpDesk';
        $ticketStatus = Settings_SupportProcesses_Module_Model::getTicketStatusNotModify();
        $listViewUrl = Vtiger_Module_Model::getInstance($moduleName)->getListViewUrl();
Severity: Minor
Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php - About 2 hrs to fix

    The class HelpDesk_ClosedTicketsByPriority_Dashboard has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class HelpDesk_ClosedTicketsByPriority_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Return search params (use to in bulding address URL to listview).
     *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '48', column '17').
    Open

            $query = (new App\Db\Query())->select([
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '19').
    Open

                'count' => new \yii\db\Expression('COUNT(*)'),
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\User' in method 'process'.
    Open

            $currentUserId = \App\User::getCurrentUserId();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
    Open

            $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'getSearchParams'.
    Open

            return '&entityState=Active&viewname=All&search_params=' . \App\Json::encode($listSearchParams);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
    Open

                $time = Settings_WidgetsManagement_Module_Model::getDefaultDateRange($widget);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Date' in method 'getTicketsByPriority'.
    Open

            $time = \App\Fields\Date::formatRangeToDisplay($time);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Date' in method 'process'.
    Open

            $viewer->assign('DTIME', \App\Fields\Date::formatRangeToDisplay($time));
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_SupportProcesses_Module_Model' in method 'getTicketsByPriority'.
    Open

            $ticketStatus = Settings_SupportProcesses_Module_Model::getTicketStatusNotModify();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\PrivilegeQuery' in method 'getTicketsByPriority'.
    Open

            \App\PrivilegeQuery::getConditions($query, $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
    Open

                $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $viewer->view('dashboards/ClosedTicketsByPriority.tpl', $moduleName);
        }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\App\User' in method 'process'.
    Open

            $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Picklist' in method 'getTicketsByPriority'.
    Open

            $colors = \App\Fields\Picklist::getColors('ticketpriorities');
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getTicketsByPriority'.
    Open

                $chartData['labels'][] = \App\Language::translate($row['priority'], $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "datasets" 4 times.
    Open

                'datasets' => [
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to method getInstance from undeclared class \Vtiger_Widget_Model
    Open

            $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), \App\User::getCurrentUserId());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

            $query = (new App\Db\Query())->select([
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('DATA', $data);
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
    Open

            $currentUserId = \App\User::getCurrentUserId();
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
    Open

            $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), \App\User::getCurrentUserId());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('DTIME', \App\Fields\Date::formatRangeToDisplay($time));
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to method getInstance from undeclared class \App\Fields\Owner
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to method __construct from undeclared class \yii\db\Expression
    Open

                'count' => new \yii\db\Expression('COUNT(*)'),
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to method getInstance from undeclared class \App\Fields\Owner
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule());
    Severity: Critical
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phan

    Avoid excessively long class names like HelpDesk_ClosedTicketsByPriority_Dashboard. Keep class name length under 40.
    Open

    class HelpDesk_ClosedTicketsByPriority_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Return search params (use to in bulding address URL to listview).
     *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class HelpDesk_ClosedTicketsByPriority_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    The class HelpDesk_ClosedTicketsByPriority_Dashboard is not named in CamelCase.
    Open

    class HelpDesk_ClosedTicketsByPriority_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Return search params (use to in bulding address URL to listview).
     *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param int    $owner
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param array  $time
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $conditions[] = ['assigned_user_id', 'e', $owner];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $query = (new App\Db\Query())->select([
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'vtiger_troubletickets.priority',
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $time = $request->getDateRange('time');
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getTicketsByPriority($time, $owner)
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'data' => [],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['links'][] = $listViewUrl . $this->getSearchParams($row['priority'], $time, $owner);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($owner)) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('DATA', $data);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/DashBoardWidgetContents.tpl', $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($owner) && 'all' != $owner) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $listViewUrl = Vtiger_Module_Model::getInstance($moduleName)->getListViewUrl();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            \App\PrivilegeQuery::getConditions($query, $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'datasets' => [
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), \App\User::getCurrentUserId());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('DTIME', \App\Fields\Date::formatRangeToDisplay($time));
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getSearchParams($priority, $time, $owner)
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'count' => new \yii\db\Expression('COUNT(*)'),
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $listSearchParams = [];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $colors = \App\Fields\Picklist::getColors('ticketpriorities');
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($time)) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $chartData = [
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param int   $owner
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->innerJoin('vtiger_ticketpriorities', 'vtiger_ticketpriorities.ticketpriorities = vtiger_troubletickets.priority')
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['labels'][] = \App\Language::translate($row['priority'], $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dataReader->close();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'and',
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    [
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $time = \App\Fields\Date::formatRangeToDisplay($time);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            while ($row = $dataReader->read()) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($request->has('content')) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'vtiger_ticketpriorities.ticketpriorities_id',
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

                $chartData['datasets'][0]['links'][] = $listViewUrl . $this->getSearchParams($row['priority'], $time, $owner);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Line exceeds 120 characters; contains 136 characters
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function returns Tickets grouped by priority.
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($time)) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $currentUserId = \App\User::getCurrentUserId();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $data = $this->getTicketsByPriority($time, $owner);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $listSearchParams[] = $conditions;
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->innerJoin('vtiger_crmentity', 'vtiger_troubletickets.ticketid = vtiger_crmentity.crmid')
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

                ->innerJoin('vtiger_ticketpriorities', 'vtiger_ticketpriorities.ticketpriorities = vtiger_troubletickets.priority')
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $query->groupBy(['vtiger_troubletickets.priority', 'vtiger_ticketpriorities.ticketpriorities_id']);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dataReader = $query->createCommand()->query();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'labels' => [],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['backgroundColor'][] = $colors[$row['ticketpriorities_id']];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $owner = $request->getByType('owner', 2);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param array $time
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ])->from('vtiger_troubletickets')
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->innerJoin('vtiger_ticketstatus', 'vtiger_troubletickets.status = vtiger_ticketstatus.ticketstatus')
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($owner) && 'all' != $owner) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->where(['vtiger_crmentity.deleted' => 0]);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($ticketStatus)) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query->andWhere(['vtiger_troubletickets.status' => $ticketStatus]);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'backgroundColor' => [],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'links' => [],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'show_chart' => false,
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['data'][] = (int) $row['count'];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Line exceeds 120 characters; contains 137 characters
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ]);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($time)) {
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/ClosedTicketsByPriority.tpl', $moduleName);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $conditions[] = ['closing_datatime', 'bw', implode(',', $time)];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return '&entityState=Active&viewname=All&search_params=' . \App\Json::encode($listSearchParams);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = 'HelpDesk';
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query->andWhere([
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ['>=', 'vtiger_troubletickets.closing_datatime', $time[0] . ' 00:00:00'],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ['<=', 'vtiger_troubletickets.closing_datatime', $time[1] . ' 23:59:59'],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $chartData['show_chart'] = (bool) $dataReader->count();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleUsersForModule());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Return search params (use to in bulding address URL to listview).
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param string $priority
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $conditions = [['ticketpriorities', 'e', $priority]];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $ticketStatus = Settings_SupportProcesses_Module_Model::getTicketStatusNotModify();
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query->andWhere(['vtiger_crmentity.smownerid' => $owner]);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ],
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $chartData;
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $time = Settings_WidgetsManagement_Module_Model::getDefaultDateRange($widget);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUserId)->getAccessibleGroupForModule());
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    Class name "HelpDesk_ClosedTicketsByPriority_Dashboard" is not in camel caps format
    Open

    class HelpDesk_ClosedTicketsByPriority_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/HelpDesk/dashboards/ClosedTicketsByPriority.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status