Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/HelpDesk/models/DetailView.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'App\Config' in method 'getDetailViewRelatedLinks'.
Open

                    'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'App\Config' in method 'getDetailViewRelatedLinks'.
Open

        if (App\Config::module($recordModel->getModuleName(), 'SHOW_SUMMARY_PRODUCTS_SERVICES')) {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Vtiger_Relation_Model' in method 'getDetailViewRelatedLinks'.
Open

            $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \HelpDesk_DetailView_Model::getModule
Open

            $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
Severity: Critical
Found in modules/HelpDesk/models/DetailView.php by phan

Reference to undeclared class \Vtiger_DetailView_Model
Open

        $relatedLinks = parent::getDetailViewRelatedLinks();
Severity: Critical
Found in modules/HelpDesk/models/DetailView.php by phan

Class extends undeclared class \Vtiger_DetailView_Model
Open

class HelpDesk_DetailView_Model extends Vtiger_DetailView_Model
Severity: Critical
Found in modules/HelpDesk/models/DetailView.php by phan

Call to undeclared method \HelpDesk_DetailView_Model::getRecord
Open

        $recordModel = $this->getRecord();
Severity: Critical
Found in modules/HelpDesk/models/DetailView.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class HelpDesk_DetailView_Model extends Vtiger_DetailView_Model
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

The class HelpDesk_DetailView_Model is not named in CamelCase.
Open

class HelpDesk_DetailView_Model extends Vtiger_DetailView_Model
{
    /** {@inheritdoc} */
    public function getDetailViewRelatedLinks()
    {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

            }
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $relatedLinks;
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (App\Config::module($recordModel->getModuleName(), 'SHOW_SUMMARY_PRODUCTS_SERVICES')) {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'linktype' => 'DETAILVIEWTAB',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'related' => 'ProductsAndServices',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModel = $this->getRecord();
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Line exceeds 120 characters; contains 152 characters
Open

            if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['Assets']) || isset($relations['OSSSoldServices'])) {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $relatedLinks = parent::getDetailViewRelatedLinks();
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                ];
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $relatedLinks[] = [
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getDetailViewRelatedLinks()
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'linkicon' => '',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['Assets']) || isset($relations['OSSSoldServices'])) {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'linklabel' => 'LBL_RECORD_SUMMARY_PRODUCTS_SERVICES',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

                    'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'linkKey' => 'LBL_RECORD_SUMMARY',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

Class name "HelpDesk_DetailView_Model" is not in camel caps format
Open

class HelpDesk_DetailView_Model extends Vtiger_DetailView_Model
Severity: Minor
Found in modules/HelpDesk/models/DetailView.php by phpcodesniffer

There are no issues that match your filters.

Category
Status