Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/IStorages/textparsers/ProductsTable.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function process()
    {
        $html = '';
        $relationModuleName = 'Products';
        $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
Severity: Minor
Found in modules/IStorages/textparsers/ProductsTable.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process()
    {
        $html = '';
        $relationModuleName = 'Products';
        $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
Severity: Minor
Found in modules/IStorages/textparsers/ProductsTable.php - About 2 hrs to fix

    The method process() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function process()
    {
        $html = '';
        $relationModuleName = 'Products';
        $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
    Open

        public function process()
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Missing class import via use statement (line '33', column '22').
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '33', column '67').
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Vtiger_Record_Model' in method 'process'.
    Open

                    $entryRecordModel = Vtiger_Record_Model::getInstanceById($entryId, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'process'.
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty In Stock', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Double' in method 'process'.
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyPerUnit, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_RelationListView_Model' in method 'process'.
    Open

            $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Double' in method 'process'.
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyInStock, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'process'.
    Open

                    $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate($fieldModel->getFieldLabel(), $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'process'.
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty/Unit', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "relcrmid" 3 times.
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "" 3 times.
    Open

                    $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate($fieldModel->getFieldLabel(), $relationModuleName) . '</th>';
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "qtyinstock" 3 times.
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "" 3 times.
    Open

                            $html .= "<td style=\"{$bodyStyle}\">" . $entryRecordModel->getDisplayValue($header->getName()) . '</td>';
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Reference to instance property recordModel from undeclared class \App\TextParser
    Open

            $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by phan

    Reference to instance property record from undeclared class \App\TextParser
    Open

                ->where(['crmid' => $this->textParser->record])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phan

    Call to deprecated function \Vtiger_Field_Model::getFieldLabel() defined at /code/modules/Vtiger/models/Field.php:215
    Open

                    $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate($fieldModel->getFieldLabel(), $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phan

    Call to method __construct from undeclared class \yii\db\Expression
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Critical
    Found in modules/IStorages/textparsers/ProductsTable.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class IStorages_ProductsTable_Textparser extends \App\TextParser\Base
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    The class IStorages_ProductsTable_Textparser is not named in CamelCase.
    Open

    class IStorages_ProductsTable_Textparser extends \App\TextParser\Base
{
    /** @var string Class name */
    public $name = 'LBL_PRODUCTS_TABLE';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->where(['crmid' => $this->textParser->record])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->groupBy(['relcrmid'])->createCommand()->query();
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $headerStyle = 'font-size:9px;padding:0px 4px;text-align:center;';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $entryRecordModel = Vtiger_Record_Model::getInstanceById($entryId, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        foreach ($columns as $header) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyInStock, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyInStock, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $name = 'LBL_PRODUCTS_TABLE';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty In Stock', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var mixed Parser type */
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $html .= '<table border="1" class="products-table" style="border-collapse:collapse;width:100%;"><thead><tr>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 145 characters
    Open

                    $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate($fieldModel->getFieldLabel(), $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $qtyPerUnit = $entryRecordModel->get('qty_per_unit');
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $html;
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $columns = [];
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $html .= '</tr></thead><tbody>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $html .= '<tr>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $html .= "<td style=\"{$bodyStyle}\">" . $entryRecordModel->getDisplayValue($header->getName()) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyPerUnit, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 125 characters
    Open

            $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $html .= '</tbody></table>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var string Class name */
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $entries = $relationListView->getAllEntries();
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            // Gets sum of products quantity in current storage
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $productsQty = [];
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate($fieldModel->getFieldLabel(), $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($entries as $entry) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 130 characters
    Open

                            $html .= "<td style=\"{$bodyStyle}\">" . $entryRecordModel->getDisplayValue($header->getName()) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $html .= '</tr>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach (['productname', 'ean', 'pscategory'] as $fieldName) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $html = '';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $productModel = $relationListView->getRelatedModuleModel();
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

                $html .= '<table border="1" class="products-table" style="border-collapse:collapse;width:100%;"><thead><tr>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $columns[$fieldName] = $fieldModel;
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $entryId = $entry->getId();
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $productId = $entryRecordModel->get('id');
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dataReader = (new App\Db\Query())->select(['qtyinstock' => new yii\db\Expression('SUM(qtyinstock)'), 'relcrmid'])
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty In Stock', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty/Unit', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process()
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $relationModuleName = 'Products';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($row['qtyinstock'] > 0) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $bodyStyle = 'font-size:8px;border:1px solid #ddd;padding:0px 4px;';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        continue;
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $type = 'pdf';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            while ($row = $dataReader->read()) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (isset($productsQty[$productId])) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Process.
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->from('u_#__istorages_products')
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($entries) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (!$fieldModel || !$fieldModel->isActiveField()) {
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $relationListView = \Vtiger_RelationListView_Model::getInstance($this->textParser->recordModel, $relationModuleName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $productsQty[$row['relcrmid']] = $row['qtyinstock'];
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $qtyInStock = $productsQty[$productId];
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fieldModel = $productModel->getFieldByName($fieldName);
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Line exceeds 120 characters; contains 123 characters
    Open

                $html .= "<th style=\"{$headerStyle}\">" . \App\Language::translate('Qty/Unit', $relationModuleName) . '</th>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $html .= "<td style=\"{$bodyStyle}\">" . \App\Fields\Double::formatToDisplay($qtyPerUnit, false) . '</td>';
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    Class name "IStorages_ProductsTable_Textparser" is not in camel caps format
    Open

    class IStorages_ProductsTable_Textparser extends \App\TextParser\Base
    Severity: Minor
    Found in modules/IStorages/textparsers/ProductsTable.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status