modules/Import/models/ListView.php
Missing class import via use statement (line '103', column '25'). Open
Open
$queryGenerator = new \App\QueryGenerator($moduleModel->get('name'));- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method getListViewEntries uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$pagingModel->set('nextPageExists', false);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\User' in method 'addLastImportedRecordConditions'. Open
Open
$user = \App\User::getCurrentUserId();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Loader' in method 'getInstance'. Open
Open
$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'ListView', 'Import');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Import_Module_Model' in method 'addLastImportedRecordConditions'. Open
Open
$userDBTableName = Import_Module_Model::getDbTableName($user);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'getInstance'. Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$linkParams'. Open
Open
public function getListViewMassActions($linkParams)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$viewId'. Open
Open
public static function getInstance($moduleName, $viewId = '0')- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$linkParams'. Open
Open
public function getListViewLinks($linkParams)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Saw unextractable annotation for comment '* @param <array> $linkParams'</array> Open
Open
* @param <Array> $linkParams- Exclude checks
Default value for int $viewId can't be string Open
Open
public static function getInstance($moduleName, $viewId = '0')- Exclude checks
Call to method initForDefaultCustomView from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
$queryGenerator->initForDefaultCustomView(true);- Exclude checks
Call to undeclared method \App\Db\Query::innerJoin Open
Open
$query->innerJoin($userDBTableName, $moduleModel->basetable . '.' . $moduleModel->basetableid . " = $userDBTableName.recordid");- Exclude checks
Suspicious type false of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
Open
$query->innerJoin($userDBTableName, $moduleModel->basetable . '.' . $moduleModel->basetableid . " = $userDBTableName.recordid");- Exclude checks
Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User) Open
Open
$user = \App\User::getCurrentUserId();- Exclude checks
Declaration of function getListViewMassActions(array $linkParams) : false should be compatible with function getListViewMassActions(array $linkParams) : \Vtiger_Link_Model[] defined in /code/modules/Vtiger/models/ListView.php:236 Open
Open
public function getListViewMassActions($linkParams)- Exclude checks
Call to method createQuery from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
$query = $this->getQueryGenerator()->createQuery();- Exclude checks
Call to undeclared method \App\Db\Query::where Open
Open
$query->where(['and', ['not', [$userDBTableName . '.temp_status' => [Import_Data_Action::IMPORT_RECORD_FAILED, Import_Data_Action::IMPORT_RECORD_SKIPPED]]], ['not', [$userDBTableName . '.recordid' => null]]]);- Exclude checks
Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
$queryGenerator = new \App\QueryGenerator($moduleModel->get('name'));- Exclude checks
Call to undeclared method \App\Db\Query::count Open
Open
return $query->count();- Exclude checks
Saw unextractable annotation for comment '* @param <array> $linkParams'</array> Open
Open
* @param <Array> $linkParams- Exclude checks
Call to undeclared method \App\Db\Query::all Open
Open
$rows = $query->all();- Exclude checks
Call to method createQuery from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
$query = $this->getQueryGenerator()->createQuery();- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Import_ListView_Model extends Vtiger_ListView_Model- Exclude checks
The class Import_ListView_Model is not named in CamelCase. Open
Open
class Import_ListView_Model extends Vtiger_ListView_Model
{
/**
* Function to get the list of listview links for the module.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->loadListViewOrderBy();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (0 !== $pagingModel->get('limit')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($rows as $row) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $moduleName - Module Name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Vtiger_ListView_Model instance- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getListViewMassActions($linkParams)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pageLimit = $pagingModel->getPageLimit();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->limit($pageLimit + 1)->offset($pagingModel->getStartIndex());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = $this->addLastImportedRecordConditions($query);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param <Array> $linkParams- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->loadListViewCondition();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $query->count();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getInstance($moduleName, $viewId = '0')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Static Function to get the Instance of Vtiger ListView model for a given module and custom view.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$user = \App\User::getCurrentUserId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array - Associative array of record id mapped to Vtiger_Record_Model instance- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = $this->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function addLastImportedRecordConditions($query)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $query;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the list view entries.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pagingModel->set('nextPageExists', false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$listViewRecordModels = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$listViewRecordModels[$row['id']] = $moduleModel->getRecordFromArray($row);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getListViewCount()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return false - no List View Links needed on Import pages- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$count = \count($rows);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* ListView count.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'ListView', 'Import');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new $modelClassName();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param <Array> $linkParams- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = $this->getQueryGenerator()->createQuery();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function adds conditions to query.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getListViewEntries(Vtiger_Paging_Model $pagingModel)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pagingModel->calculatePageRange($count);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
array_pop($rows);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pagingModel->set('nextPageExists', true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Db\Query $query- Exclude checks
Line exceeds 120 characters; contains 136 characters Open
Open
$query->innerJoin($userDBTableName, $moduleModel->basetable . '.' . $moduleModel->basetableid . " = $userDBTableName.recordid");- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->innerJoin($userDBTableName, $moduleModel->basetable . '.' . $moduleModel->basetableid . " = $userDBTableName.recordid");- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the list of Mass actions for the module.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param Vtiger_Paging_Model $pagingModel- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($count > $pageLimit) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $listViewRecordModels;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->loadListViewCondition();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->where(['and', ['not', [$userDBTableName . '.temp_status' => [Import_Data_Action::IMPORT_RECORD_FAILED, Import_Data_Action::IMPORT_RECORD_SKIPPED]]], ['not', [$userDBTableName . '.recordid' => null]]]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the list of listview links for the module.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return false - no List View Links needed on Import pages- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($rows);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = $this->getQueryGenerator()->createQuery();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $viewId - Custom View Id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = $this->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getListViewLinks($linkParams)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$rows = $query->all();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = $this->addLastImportedRecordConditions($query);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queryGenerator->initForDefaultCustomView(true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$userDBTableName = Import_Module_Model::getDbTableName($user);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queryGenerator = new \App\QueryGenerator($moduleModel->get('name'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance->set('module', $moduleModel)->set('query_generator', $queryGenerator);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \App\Db\Query- Exclude checks
Line exceeds 120 characters; contains 217 characters Open
Open
$query->where(['and', ['not', [$userDBTableName . '.temp_status' => [Import_Data_Action::IMPORT_RECORD_FAILED, Import_Data_Action::IMPORT_RECORD_SKIPPED]]], ['not', [$userDBTableName . '.recordid' => null]]]);- Exclude checks
Class name "Import_ListView_Model" is not in camel caps format Open
Open
class Import_ListView_Model extends Vtiger_ListView_Model- Exclude checks