YetiForceCompany/YetiForceCRM

Method getDetailViewLinks has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getDetailViewLinks(array $linkParams): array
    {
        if ($this->getRecord()->isReadOnly() || \App\RequestUtil::getBrowserInfo()->ie) {
            return parent::getDetailViewLinks($linkParams);
        }

Avoid using static access to class '\App\Language' in method 'getDetailViewLinks'.

Open

                'title' => \App\Language::translate('LBL_GO_TO_PREVIEW', $moduleName),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'getDetailViewLinks'.

Open

                'linkhint' => \App\Language::translate('LBL_GO_TO_PREVIEW', $moduleName),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Link_Model' in method 'getDetailViewLinks'.

Open

            $relatedLinks[] = Vtiger_Link_Model::getInstanceFromValues($relatedLinkEntry);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Reference to undeclared class \Vtiger_DetailView_Model

Open

            return parent::getDetailViewLinks($linkParams);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \KnowledgeBase_DetailView_Model::getRecord

Open

        if ($this->getRecord()->isReadOnly() || \App\RequestUtil::getBrowserInfo()->ie) {

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \KnowledgeBase_DetailView_Model::getRecord

Open

        $recordModel = $this->getRecord();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared class \Vtiger_DetailView_Model

Open

        $linkModelList = parent::getDetailViewLinks($linkParams);

• Exclude checks
  • Disable engine
  • Disable check

Class extends undeclared class \Vtiger_DetailView_Model

Open

class KnowledgeBase_DetailView_Model extends Vtiger_DetailView_Model

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class KnowledgeBase_DetailView_Model extends Vtiger_DetailView_Model

• Exclude checks
  • Disable engine
  • Disable check

The class KnowledgeBase_DetailView_Model is not named in CamelCase.

Open

class KnowledgeBase_DetailView_Model extends Vtiger_DetailView_Model
{
    /** {@inheritdoc} */
    public function getDetailViewLinks(array $linkParams): array
    {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

                ],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($relatedLinks as $relatedLink) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $recordModel = $this->getRecord();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $relatedLinkEntries = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $linkModelList;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    'id' => $recordModel->getId(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'linkhint' => \App\Language::translate('LBL_GO_TO_PREVIEW', $moduleName),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $recordModel->getModuleName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return parent::getDetailViewLinks($linkParams);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'linkdata' => [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $linkModelList = parent::getDetailViewLinks($linkParams);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($this->getRecord()->isReadOnly() || \App\RequestUtil::getBrowserInfo()->ie) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'linkclass' => 'btn-outline-dark btn-sm js-show-article-preview',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    'module-name' => $moduleName

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'vueId' => 'ArticlePreview',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $linkModelList[$relatedLink->getType()][] = $relatedLink;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($relatedLinkEntries as $relatedLinkEntry) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getDetailViewLinks(array $linkParams): array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'linkicon' => 'fas fa-expand',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'title' => \App\Language::translate('LBL_GO_TO_PREVIEW', $moduleName),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $relatedLinks[] = Vtiger_Link_Model::getInstanceFromValues($relatedLinkEntry);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'linktype' => 'DETAIL_VIEW_ADDITIONAL',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $relatedLinks = [];

• Exclude checks
  • Disable engine
  • Disable check

Class name "KnowledgeBase_DetailView_Model" is not in camel caps format

Open

class KnowledgeBase_DetailView_Model extends Vtiger_DetailView_Model

• Exclude checks
  • Disable engine
  • Disable check