Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Leads/dashboards/LeadsBySource.php

Summary

Maintainability
F
3 days
Test Coverage
F
0%

Method getLeadsBySource has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getLeadsBySource($owner, $dateFilter)
    {
        $query = new \App\Db\Query();
        $query->select([
            'leadsourceid' => 'vtiger_leadsource.leadsourceid',
Severity: Minor
Found in modules/Leads/dashboards/LeadsBySource.php - About 1 hr to fix

    Method process has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/Leads/dashboards/LeadsBySource.php - About 1 hr to fix

      Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '42', column '29').
      Open

                  'leadsourcevalue' => new \yii\db\Expression("CASE WHEN vtiger_leaddetails.leadsource IS NULL OR vtiger_leaddetails.leadsource = '' THEN '' ELSE vtiger_leaddetails.leadsource END"), ])
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '38', column '16').
      Open

              $query = new \App\Db\Query();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '41', column '19').
      Open

                  'count' => new \yii\db\Expression('COUNT(*)'),
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class '\App\Language' in method 'getLeadsBySource'.
      Open

                  $chartData['labels'][] = \App\Language::translate($row['leadsourcevalue'], 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\PrivilegeQuery' in method 'getLeadsBySource'.
      Open

              \App\PrivilegeQuery::getConditions($query, 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\User' in method 'process'.
      Open

              $currentUserId = \App\User::getCurrentUserId();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Fields\Date' in method 'process'.
      Open

              $createdTime = \App\Fields\Date::formatRangeToDisplay($createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
      Open

                  $createdTime = Settings_WidgetsManagement_Module_Model::getDefaultDateRange($widget);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $owner = $request->getByType('owner', 2);
        }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\App\Fields\Picklist' in method 'getLeadsBySource'.
      Open

              $colors = \App\Fields\Picklist::getColors('leadsource');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
      Open

              $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
      Open

                  $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $viewer->view('dashboards/LeadsBySource.tpl', $moduleName);
        }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Define a constant instead of duplicating this literal "names" 4 times.
      Open

                          'names' => [],
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "leadsourcevalue" 3 times.
      Open

                  'leadsourcevalue' => new \yii\db\Expression("CASE WHEN vtiger_leaddetails.leadsource IS NULL OR vtiger_leaddetails.leadsource = '' THEN '' ELSE vtiger_leaddetails.leadsource END"), ])
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "Leads" 5 times.
      Open

              \App\PrivilegeQuery::getConditions($query, 'Leads');
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "datasets" 8 times.
      Open

                  'datasets' => [
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "createdtime" 3 times.
      Open

                  array_push($conditions, ['createdtime', 'bw', $dates[0] . ' 00:00:00,' . $dates[1] . ' 23:59:59']);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Call to method __construct from undeclared class \yii\db\Expression
      Open

                  'count' => new \yii\db\Expression('COUNT(*)'),
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('DTIME', $createdTime);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method getInstance from undeclared class \App\Fields\Owner
      Open

              $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleGroupForModule());
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \App\Db\Query::andWhere
      Open

                  $query->andWhere(['smownerid' => $owner]);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('WIDGET', $widget);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \App\Db\Query::andWhere
      Open

                  $query->andWhere(['between', 'createdtime', $dateFilter[0] . ' 00:00:00', $dateFilter[1] . ' 23:59:59']);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleUsersForModule());
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method getInstance from undeclared class \Vtiger_Widget_Model
      Open

              $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method __construct from undeclared class \yii\db\Expression
      Open

                  'leadsourcevalue' => new \yii\db\Expression("CASE WHEN vtiger_leaddetails.leadsource IS NULL OR vtiger_leaddetails.leadsource = '' THEN '' ELSE vtiger_leaddetails.leadsource END"), ])
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('MODULE_NAME', $moduleName);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('DATA', $data);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \App\Db\Query::groupBy
      Open

              $query->groupBy(['vtiger_leaddetails.leadsource', 'vtiger_leadsource.leadsourceid']);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('OWNER', $ownerForwarded);
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method close from undeclared class \yii\db\DataReader
      Open

              $dataReader->close();
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
      Open

              $currentUserId = \App\User::getCurrentUserId();
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method getInstance from undeclared class \App\Fields\Owner
      Open

              $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleUsersForModule());
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \App\Db\Query::select
      Open

              $query->select([
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to method read from undeclared class \yii\db\DataReader
      Open

              while ($row = $dataReader->read()) {
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Call to undeclared method \Vtiger_Viewer::assign
      Open

              $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleGroupForModule());
      Severity: Critical
      Found in modules/Leads/dashboards/LeadsBySource.php by phan

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
        $viewer = $this->getViewer($request);
        $moduleName = $request->getModule();
      Severity: Major
      Found in modules/Leads/dashboards/LeadsBySource.php and 1 other location - About 2 days to fix
      modules/Leads/dashboards/LeadsByStatusConverted.php on lines 84..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 486.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function getSearchParams($value, $assignedto, $dates)
    {
        $listSearchParams = [];
        $conditions = [['leadsource', 'e', $value]];
        if ('' != $assignedto) {
      Severity: Major
      Found in modules/Leads/dashboards/LeadsBySource.php and 3 other locations - About 3 hrs to fix
      modules/Leads/dashboards/LeadsByIndustry.php on lines 14..26
      modules/Leads/dashboards/LeadsByStatus.php on lines 16..29
      modules/Leads/dashboards/LeadsByStatusConverted.php on lines 14..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class Leads_LeadsBySource_Dashboard extends Vtiger_IndexAjax_View
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      The class Leads_LeadsBySource_Dashboard is not named in CamelCase.
      Open

      class Leads_LeadsBySource_Dashboard extends Vtiger_IndexAjax_View
{
    public function getSearchParams($value, $assignedto, $dates)
    {
        $listSearchParams = [];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  array_push($conditions, ['assigned_user_id', 'e', $assignedto]);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return '&search_params=' . json_encode($listSearchParams);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'count' => new \yii\db\Expression('COUNT(*)'),
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Line exceeds 120 characters; contains 195 characters
      Open

                  'leadsourcevalue' => new \yii\db\Expression("CASE WHEN vtiger_leaddetails.leadsource IS NULL OR vtiger_leaddetails.leadsource = '' THEN '' ELSE vtiger_leaddetails.leadsource END"), ])
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($owner)) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              while ($row = $dataReader->read()) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer = $this->getViewer($request);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $query->andWhere(['smownerid' => $owner]);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $viewer->view('dashboards/LeadsBySource.tpl', $moduleName);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getSearchParams($value, $assignedto, $dates)
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'show_chart' => false,
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $moduleName = $request->getModule();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $listViewUrl = Vtiger_Module_Model::getInstance($moduleName)->getListViewUrl();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              } else {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($dates)) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $listSearchParams[] = $conditions;
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @param int   $owner
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'labels' => [],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Line exceeds 120 characters; contains 133 characters
      Open

              $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleGroupForModule());
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->where(['deleted' => 0, 'converted' => 0]);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'datasets' => [
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          'backgroundColor' => [],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          'names' => [],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $ownerForwarded = $owner;
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $createdTime = \App\Fields\Date::formatRangeToDisplay($createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $leadSourceAmount = \count($data['datasets'][0]['names']);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('MODULE_NAME', $moduleName);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Function returns Leads grouped by Source.
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          'links' => [], // links generated in proccess method
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $chartData['datasets'][0]['backgroundColor'][] = $colors[$row['leadsourceid']];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $data['datasets'][0]['links'][$i] = $listViewUrl . '&viewname=All&entityState=Active' . $this->getSearchParams($data['datasets'][0]['names'][$i], $owner, $createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Line exceeds 120 characters; contains 132 characters
      Open

              $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleUsersForModule());
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  array_push($conditions, ['createdtime', 'bw', $dates[0] . ' 00:00:00,' . $dates[1] . ' 23:59:59']);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $query->select([
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $conditions = [['leadsource', 'e', $value]];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return array
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $query = new \App\Db\Query();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('OWNER', $ownerForwarded);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ('' != $assignedto) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $query->groupBy(['vtiger_leaddetails.leadsource', 'vtiger_leadsource.leadsourceid']);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $colors = \App\Fields\Picklist::getColors('leadsource');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $chartData['labels'][] = \App\Language::translate($row['leadsourcevalue'], 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $chartData['datasets'][0]['names'][] = $row['leadsourcevalue'];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $chartData['show_chart'] = (bool) \count($chartData['datasets'][0]['data']);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $owner = '';
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @param array $dateFilter
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'leadsourceid' => 'vtiger_leadsource.leadsourceid',
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->innerJoin('vtiger_crmentity', 'vtiger_leaddetails.leadid = vtiger_crmentity.crmid')
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $chartData = [
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $owner = $request->getByType('owner', 2);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $data = (false === $owner) ? [] : $this->getLeadsBySource($owner, $createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              //Include special script and css needed for this widget
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $viewer->view('dashboards/DashBoardWidgetContents.tpl', $moduleName);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getLeadsBySource($owner, $dateFilter)
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'leadsourcevalue' => new \yii\db\Expression("CASE WHEN vtiger_leaddetails.leadsource IS NULL OR vtiger_leaddetails.leadsource = '' THEN '' ELSE vtiger_leaddetails.leadsource END"), ])
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($dateFilter)) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $query->andWhere(['between', 'createdtime', $dateFilter[0] . ' 00:00:00', $dateFilter[1] . ' 23:59:59']);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $dataReader = $query->createCommand()->query();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $dataReader->close();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $currentUserId = \App\User::getCurrentUserId();
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleUsersForModule());
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($request->has('content')) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $listSearchParams = [];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      [
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      ],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->innerJoin('vtiger_leadsource', 'vtiger_leaddetails.leadsource = vtiger_leadsource.leadsource')
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $chartData['datasets'][0]['data'][] = (int) $row['count'];
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ('all' == $owner) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (empty($createdTime)) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              \App\PrivilegeQuery::getConditions($query, 'Leads');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          'data' => [],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ],
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $chartData;
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $createdTime = Settings_WidgetsManagement_Module_Model::getDefaultDateRange($widget);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('DATA', $data);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('DTIME', $createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance('Leads', $currentUserId)->getAccessibleGroupForModule());
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function process(App\Request $request)
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $createdTime = $request->getDateRange('createdtime');
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!$request->has('owner')) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Line exceeds 120 characters; contains 180 characters
      Open

                  $data['datasets'][0]['links'][$i] = $listViewUrl . '&viewname=All&entityState=Active' . $this->getSearchParams($data['datasets'][0]['names'][$i], $owner, $createdTime);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $viewer->assign('WIDGET', $widget);
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->from('vtiger_leaddetails')
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              } else {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              for ($i = 0; $i < $leadSourceAmount; ++$i) {
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      Class name "Leads_LeadsBySource_Dashboard" is not in camel caps format
      Open

      class Leads_LeadsBySource_Dashboard extends Vtiger_IndexAjax_View
      Severity: Minor
      Found in modules/Leads/dashboards/LeadsBySource.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status