YetiForceCompany/YetiForceCRM

View on GitHub
modules/Leads/summary_blocks/TotalEvent.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '25', column '17').
Open

        $count = (new App\Db\Query())->from('vtiger_activity')

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\App\Log' in method 'process'.
Open

        \App\Log::trace('Entering TotalEvent::process() method ...');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Log' in method 'process'.
Open

        \App\Log::trace('Exiting TotalEvent::process() method ...');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \App\Db\Query::from
Open

        $count = (new App\Db\Query())->from('vtiger_activity')

Call to method trace from undeclared class \App\Log
Open

        \App\Log::trace('Entering TotalEvent::process() method ...');

Call to method trace from undeclared class \App\Log
Open

        \App\Log::trace('Exiting TotalEvent::process() method ...');

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class TotalEvent

Spaces must be used to indent lines; tabs are not allowed
Open

        $count = (new App\Db\Query())->from('vtiger_activity')

Spaces must be used to indent lines; tabs are not allowed
Open

            ->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_activity.activityid')

Spaces must be used to indent lines; tabs are not allowed
Open

                ['vtiger_activity.link' => $recordModel->getId()],

Spaces must be used to indent lines; tabs are not allowed
Open

                'and',

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

            ->where([

Spaces must be used to indent lines; tabs are not allowed
Open

    public $reference = 'Calendar';

Spaces must be used to indent lines; tabs are not allowed
Open

     * Process.

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        \App\Log::trace('Entering TotalEvent::process() method ...');

Spaces must be used to indent lines; tabs are not allowed
Open

    public $name = 'Total event';

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param Vtiger_Record_Model $recordModel

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return int

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(Vtiger_Record_Model $recordModel)

Spaces must be used to indent lines; tabs are not allowed
Open

    public $sequence = 3;

Spaces must be used to indent lines; tabs are not allowed
Open

            ])->count('vtiger_activity.activityid');

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

                ['<>', 'vtiger_activity.activitytype', 'Task'],

Spaces must be used to indent lines; tabs are not allowed
Open

                ['vtiger_crmentity.deleted' => 0],

Spaces must be used to indent lines; tabs are not allowed
Open

        return $count;

Spaces must be used to indent lines; tabs are not allowed
Open

        \App\Log::trace('Exiting TotalEvent::process() method ...');

There are no issues that match your filters.

Category
Status