modules/Leads/views/SaveConvertLead.php
Method process has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function process(App\Request $request)
{
$recordId = $request->getInteger('record');
$modules = $request->getArray('modules', 'Alnum');
$assignId = $request->getInteger('assigned_user_id');Function process has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
Open
public function process(App\Request $request)
{
$recordId = $request->getInteger('record');
$modules = $request->getArray('modules', 'Alnum');
$assignId = $request->getInteger('assigned_user_id');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method process() has an NPath complexity of 400. The configured NPath complexity threshold is 200. Open
Open
public function process(App\Request $request)
{
$recordId = $request->getInteger('record');
$modules = $request->getArray('modules', 'Alnum');
$assignId = $request->getInteger('assigned_user_id');- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method process() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
Open
public function process(App\Request $request)
{
$recordId = $request->getInteger('record');
$modules = $request->getArray('modules', 'Alnum');
$assignId = $request->getInteger('assigned_user_id');- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. Open
Open
public function process(App\Request $request)- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
The class Leads_SaveConvertLead_View has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. Open
Open
class Leads_SaveConvertLead_View extends \App\Controller\View\Page
{
/**
* Record model instance.
*- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '37', column '14'). Open
Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '97', column '14'). Open
Open
throw new \App\Exceptions\AppException($e->getMessage());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method showError has a boolean flag argument $exception, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function showError(App\Request $request, $exception = false, $message = '')- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Missing class import via use statement (line '115', column '14'). Open
Open
throw new \App\Exceptions\AppException('Error');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '44', column '14'). Open
Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '103', column '14'). Open
Open
throw new \App\Exceptions\AppException($e->getMessage());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '41', column '14'). Open
Open
throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method preProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Vtiger_Record_Model' in method 'checkPermission'. Open
Open
$this->record = Vtiger_Record_Model::getInstanceById($recordId, $moduleName);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Privileges_Model' in method 'checkPermission'. Open
Open
$userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\User' in method 'process'. Open
Open
ModTracker_Record_Model::addConvertToAccountRelation('Accounts', $accountId, \App\User::getCurrentUserRealId());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$this->showError($request);
throw new \App\Exceptions\AppException('Error');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Language' in method 'showError'. Open
Open
$viewer->assign('EXCEPTION', \App\Language::translate($exception->getMessage(), $moduleName));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Module_Model' in method 'process'. Open
Open
$leadModel = Vtiger_Module_Model::getCleanInstance($request->getModule());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Leads_Module_Model' in method 'checkPermission'. Open
Open
if (!Leads_Module_Model::checkIfAllowedToConvert($this->record->get('leadstatus'))) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Processes_Model' in method 'process'. Open
Open
$createAlways = Vtiger_Processes_Model::getConfig('marketing', 'conversion', 'create_always');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'process'. Open
Open
$message = \App\Language::translate('LBL_TOO_MANY_ACCOUNTS_TO_CONVERT', $request->getModule(), '');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Record_Model' in method 'process'. Open
Open
$currentUser = Users_Record_Model::getCurrentUserModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'process'. Open
Open
$message = \App\Language::translate('LBL_TOO_MANY_ACCOUNTS_TO_CONVERT', $request->getModule(), '<a href="index.php?module=MarketingProcesses&view=Index&parent=Settings"><span class="fas fa-folder-open"></span></a>');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker_Record_Model' in method 'process'. Open
Open
ModTracker_Record_Model::addConvertToAccountRelation('Accounts', $accountId, \App\User::getCurrentUserRealId());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\WebservicesConvertLead' in method 'process'. Open
Open
$result = \WebservicesConvertLead::vtwsConvertlead($entityValues, $currentUser);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Module' in method 'process'. Open
Open
if (\App\Module::isModuleActive($module) && \in_array($module, $modules)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "Accounts" 5 times. Open
Open
$availableModules = ['Accounts'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "entities" 4 times. Open
Open
$entityValues['entities'][$module]['create'] = true;- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Avoid unused parameters such as '$display'. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$request'. Open
Open
public function preProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Argument 2 (exception) is \Exception|\Throwable but \Leads_SaveConvertLead_View::showError() takes bool|false defined at /code/modules/Leads/views/SaveConvertLead.php:126 Open
Open
$this->showError($request, $e);- Exclude checks
Assigning false to property but \Leads_SaveConvertLead_View->record is \Vtiger_Record_Model Open
Open
protected $record = false;- Exclude checks
true to array comparison Open
Open
if (true === $createAlways || 'true' === $createAlways) {- Exclude checks
Call to undeclared method \Vtiger_Module_Model::searchAccountsToConvert Open
Open
$results = $leadModel->searchAccountsToConvert($this->record);- Exclude checks
Call to undeclared method \Vtiger_Record_Model::getConvertLeadFields Open
Open
$convertLeadFields = $this->record->getConvertLeadFields();- Exclude checks
Argument 1 (entityvalues) is array{entities:array{Accounts:array{convert_to_id:}}}|array{entities:array{Accounts:array{create:true}}}|array{entities:array{Accounts:array{name:'Accounts'}}}|array{entities:array{Accounts:array}}|array{leadId:int,assignedTo:int,transferRelatedRecordsTo:bool|mixed} but \WebservicesConvertLead::vtwsConvertlead() takes string defined at /code/include/Webservices/ConvertLead.php:22 Open
Open
$result = \WebservicesConvertLead::vtwsConvertlead($entityValues, $currentUser);- Exclude checks
Argument 2 (exception) is \Exception|\Throwable but \Leads_SaveConvertLead_View::showError() takes bool|false defined at /code/modules/Leads/views/SaveConvertLead.php:126 Open
Open
$this->showError($request, $e);- Exclude checks
Call to method getMessage on non-class type true Open
Open
$viewer->assign('EXCEPTION', \App\Language::translate($exception->getMessage(), $moduleName));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('EXCEPTION', \App\Language::translate($exception->getMessage(), $moduleName));- Exclude checks
Call to method getCurrentUserRealId from undeclared class \App\User (Did you mean class \Tests\App\User) Open
Open
ModTracker_Record_Model::addConvertToAccountRelation('Accounts', $accountId, \App\User::getCurrentUserRealId());- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('EXCEPTION', $message);- Exclude checks
string to array comparison Open
Open
if (true === $createAlways || 'true' === $createAlways) {- Exclude checks
Suspicious array access to int Open
Open
$accountId = $result['Accounts'];- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('MODULE', $moduleName);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Leads_SaveConvertLead_View extends \App\Controller\View\Page- Exclude checks
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 13 and the first side effect is on line 11. Open
Open
<?php- Exclude checks
The class Leads_SaveConvertLead_View is not named in CamelCase. Open
Open
class Leads_SaveConvertLead_View extends \App\Controller\View\Page
{
/**
* Record model instance.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$assignId = $request->getInteger('assigned_user_id');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$leadModel = Vtiger_Module_Model::getCleanInstance($request->getModule());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws \App\Exceptions\NoPermitted- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function checkPermission(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function preProcess(App\Request $request, $display = true)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['assignedTo'] = $assignId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$uitypeModel->validate($request->get($fieldName, null), true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$results = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$message = \App\Language::translate('LBL_TOO_MANY_ACCOUNTS_TO_CONVERT', $request->getModule(), '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\AppException('Error');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} elseif ($message) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record model instance.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!Leads_Module_Model::checkIfAllowedToConvert($this->record->get('leadstatus'))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$availableModules = ['Accounts'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (false !== $exception) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$request->validateWriteAccess();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordId = $request->getInteger('record');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$userPrivilegesModel->hasModuleActionPermission($moduleName, 'ConvertLead')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$results = $leadModel->searchAccountsToConvert($this->record);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\AppException($e->getMessage());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\AppException($e->getMessage());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('EXCEPTION', $message);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$this->record->isEditable()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['transferRelatedRecordsTo'] = $request->getByType('transferModule', 'Alnum');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($availableModules as $module) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['entities'][$module]['create'] = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->showError($request, false, $message);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (Exception $e) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->showError($request, $e);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($result['Accounts'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->showError($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to check permission.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$modules = $request->getArray('modules', 'Alnum');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\App\Module::isModuleActive($module) && \in_array($module, $modules)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$uitypeModel = $fieldModel->getUITypeModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$message = \App\Language::translate('LBL_TOO_MANY_ACCOUNTS_TO_CONVERT', $request->getModule(), '<a href="index.php?module=MarketingProcesses&view=Index&parent=Settings"><span class="fas fa-folder-open"></span></a>');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->showError($request, $e);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function showError(App\Request $request, $exception = false, $message = '')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['leadId'] = $recordId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['entities']['Accounts']['convert_to_id'] = $results;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $record = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$accountId = $result['Accounts'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldName = $fieldModel->getName();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
header("location: index.php?view=Detail&module=Accounts&record=$accountId");- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['entities'][$module][$fieldName] = $fieldValue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
ModTracker_Record_Model::addConvertToAccountRelation('Accounts', $accountId, \App\User::getCurrentUserRealId());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$results) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$result = \WebservicesConvertLead::vtwsConvertlead($entityValues, $currentUser);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @var Vtiger_Record_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws \App\Exceptions\NoPermittedToRecord- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($convertLeadFields[$module] as $fieldModel) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('ConvertLeadError.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues['entities'][$module]['name'] = $module;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* This function shows an error.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('MODULE', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$createAlways = Vtiger_Processes_Model::getConfig('marketing', 'conversion', 'create_always');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (Exception $e) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!empty($accountId)) {- Exclude checks
Line exceeds 120 characters; contains 124 characters Open
Open
ModTracker_Record_Model::addConvertToAccountRelation('Accounts', $accountId, \App\User::getCurrentUserRealId());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->record = Vtiger_Record_Model::getInstanceById($recordId, $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$entityValues = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordId = $request->getInteger('record');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$convertLeadFields = $this->record->getConvertLeadFields();- Exclude checks
Line exceeds 120 characters; contains 236 characters Open
Open
$message = \App\Language::translate('LBL_TOO_MANY_ACCOUNTS_TO_CONVERT', $request->getModule(), '<a href="index.php?module=MarketingProcesses&view=Index&parent=Settings"><span class="fas fa-folder-open"></span></a>');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$currentUser = Users_Record_Model::getCurrentUserModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldValue = $uitypeModel->getDBValue($request->get($fieldName, null));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (true === $createAlways || 'true' === $createAlways) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($currentUser->isAdminUser()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param bool $exception- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $message- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('EXCEPTION', \App\Language::translate($exception->getMessage(), $moduleName));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function validateRequest(App\Request $request)- Exclude checks
Class name "Leads_SaveConvertLead_View" is not in camel caps format Open
Open
class Leads_SaveConvertLead_View extends \App\Controller\View\Page- Exclude checks