Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/ModComments/actions/MassSaveAjax.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '31', column '14').
Open

            throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '26', column '14').
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '48', column '19').
Open

        $response = new Vtiger_Response();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.
Open

        $relationModel = Vtiger_Relation_Model::getInstance(Vtiger_Module_Model::getInstance($request->getByType('source_module', 2)), Vtiger_Module_Model::getInstance($request->getModule()));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Utils\Completions' in method 'getRecordModelsFromRequest'.
Open

            $recordModel->set('commentcontent', \App\Utils\Completions::encodeAll(\App\Purifier::decodeHtml($request->getForHtml('commentcontent'))));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Module_Model' in method 'process'.
Open

        $relationModel = Vtiger_Relation_Model::getInstance(Vtiger_Module_Model::getInstance($request->getByType('source_module', 2)), Vtiger_Module_Model::getInstance($request->getModule()));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\User' in method 'getRecordModelsFromRequest'.
Open

        $userId = \App\User::getCurrentUserRealId();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Users_Privileges_Model' in method 'checkPermission'.
Open

        $userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Record_Model' in method 'getRecordModelsFromRequest'.
Open

            $recordModel = Vtiger_Record_Model::getCleanInstance($moduleName);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Relation_Model' in method 'process'.
Open

        $relationModel = Vtiger_Relation_Model::getInstance(Vtiger_Module_Model::getInstance($request->getByType('source_module', 2)), Vtiger_Module_Model::getInstance($request->getModule()));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Module_Model' in method 'checkPermission'.
Open

        $moduleModel = Vtiger_Module_Model::getInstance($sourceModule);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Purifier' in method 'getRecordModelsFromRequest'.
Open

            $recordModel->set('commentcontent', \App\Utils\Completions::encodeAll(\App\Purifier::decodeHtml($request->getForHtml('commentcontent'))));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method getCurrentUserRealId from undeclared class \App\User (Did you mean class \Tests\App\User)
Open

        $userId = \App\User::getCurrentUserRealId();
Severity: Critical
Found in modules/ModComments/actions/MassSaveAjax.php by phan

Returning type array<int>|array{}</int> but getRecordModelsFromRequest() is declared to return \Vtiger_Record_Model
Open

        return $recordModels;
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phan

Class \Vtiger_Record_Model was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)
Open

        foreach ($recordModels as $relatedRecordId => &$recordModel) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phan

Call to method encodeAll from undeclared class \App\Utils\Completions
Open

            $recordModel->set('commentcontent', \App\Utils\Completions::encodeAll(\App\Purifier::decodeHtml($request->getForHtml('commentcontent'))));
Severity: Critical
Found in modules/ModComments/actions/MassSaveAjax.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class ModComments_MassSaveAjax_Action extends Vtiger_Mass_Action
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

The class ModComments_MassSaveAjax_Action is not named in CamelCase.
Open

class ModComments_MassSaveAjax_Action extends Vtiger_Mass_Action
{
    /**
     * Function to check permission.
     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel->save();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $response = new Vtiger_Response();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @throws \App\Exceptions\NoPermittedToRecord
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to get the record model based on the request parameters.
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModels = [];
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$userPrivilegesModel->hasModuleActionPermission($request->getModule(), 'CreateView')) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$moduleModel->isCommentEnabled() || !$userPrivilegesModel->hasModuleActionPermission($sourceModule, 'MassAddComment')) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Line exceeds 120 characters; contains 192 characters
Open

        $relationModel = Vtiger_Relation_Model::getInstance(Vtiger_Module_Model::getInstance($request->getByType('source_module', 2)), Vtiger_Module_Model::getInstance($request->getModule()));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel->set('assigned_user_id', $userId);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleModel = Vtiger_Module_Model::getInstance($sourceModule);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach ($recordModels as $relatedRecordId => &$recordModel) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $response->emit();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return Vtiger_Record_Model or Module specific Record Model instance
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @throws \App\Exceptions\NoPermitted
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $sourceModule = $request->getByType('source_module', 2);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Main process.
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel->set('commentcontent', \App\Utils\Completions::encodeAll(\App\Purifier::decodeHtml($request->getForHtml('commentcontent'))));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel = Vtiger_Record_Model::getCleanInstance($moduleName);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModels = $this->getRecordModelsFromRequest($request);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $relationModel = Vtiger_Relation_Model::getInstance(Vtiger_Module_Model::getInstance($request->getByType('source_module', 2)), Vtiger_Module_Model::getInstance($request->getModule()));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $response->setResult(true);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordIds = self::getRecordsListFromRequest($request);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $userId = \App\User::getCurrentUserRealId();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $recordModels;
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function checkPermission(App\Request $request)
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    private function getRecordModelsFromRequest(App\Request $request)
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Line exceeds 120 characters; contains 150 characters
Open

            $recordModel->set('commentcontent', \App\Utils\Completions::encodeAll(\App\Purifier::decodeHtml($request->getForHtml('commentcontent'))));
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to check permission.
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            throw new \App\Exceptions\NoPermittedToRecord('ERR_NO_PERMISSIONS_FOR_THE_RECORD', 406);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModels[$recordId] = $recordModel;
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $userPrivilegesModel = Users_Privileges_Model::getCurrentUserPrivilegesModel();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        foreach ($recordIds as $recordId) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $relationModel->addRelation($relatedRecordId, $recordModel->getId());
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Line exceeds 120 characters; contains 133 characters
Open

        if (!$moduleModel->isCommentEnabled() || !$userPrivilegesModel->hasModuleActionPermission($sourceModule, 'MassAddComment')) {
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $recordModel->set('related_to', $recordId);
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

Class name "ModComments_MassSaveAjax_Action" is not in camel caps format
Open

class ModComments_MassSaveAjax_Action extends Vtiger_Mass_Action
Severity: Minor
Found in modules/ModComments/actions/MassSaveAjax.php by phpcodesniffer

There are no issues that match your filters.

Category
Status