modules/ModComments/models/Comments.php
Missing class import via use statement (line '32', column '15'). Open
Open
$date = new DateTimeField($this->data['modifiedtime']);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'App\Purifier' in method 'content'. Open
Open
return App\Purifier::decodeHtml($this->data['commentcontent']);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Owner' in method 'author'. Open
Open
self::$ownerNamesCache[$authorid] = \App\Fields\Owner::getLabel($authorid);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to method getLabel from undeclared class \App\Fields\Owner Open
Open
self::$ownerNamesCache[$authorid] = \App\Fields\Owner::getLabel($authorid);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class ModComments_CommentsModel- Exclude checks
The class ModComments_CommentsModel is not named in CamelCase. Open
Open
class ModComments_CommentsModel
{
private $data;
public static $ownerNamesCache = [];
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function author()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$authorid = $this->data['smcreatorid'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$date = new DateTimeField($this->data['modifiedtime']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function content()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return self::$ownerNamesCache[$authorid];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static $ownerNamesCache = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct($datarow)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!isset(self::$ownerNamesCache[$authorid])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private $data;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->data = $datarow;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return App\Purifier::decodeHtml($this->data['commentcontent']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
self::$ownerNamesCache[$authorid] = \App\Fields\Owner::getLabel($authorid);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function timestamp()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $date->getDisplayDateTimeValue();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "ModComments_CommentsModel" is not in camel caps format Open
Open
class ModComments_CommentsModel- Exclude checks