modules/ModTracker/models/Relation.php
Missing class import via use statement (line '52', column '14'). Open
Open
$id = (new \App\Db\Query())->from('u_#__reviewed_queue')->max('id') + 1;- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method reviewChanges has a boolean flag argument $userId, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public static function reviewChanges($recordsList, $userId = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Vtiger_Module_Model' in method 'getDetailViewUrl'. Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($this->get('targetmodule'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Module' in method 'reviewChangesQueue'. Open
Open
'tabid' => \App\Module::getModuleId($module),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'reviewChangesQueue'. Open
Open
'data' => \App\Json::encode($data),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Record_Model' in method 'reviewChangesQueue'. Open
Open
$currentUserModel = Users_Record_Model::getCurrentUserModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker_Record_Model' in method 'reviewChanges'. Open
Open
ModTracker_Record_Model::unsetReviewed($record, $userId, $result);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Db' in method 'reviewChangesQueue'. Open
Open
$db = \App\Db::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker_Record_Model' in method 'reviewChanges'. Open
Open
$result = ModTracker_Record_Model::setLastReviewed($record);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getValue'. Open
Open
return \App\Record::getLabel($this->get('targetid'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \App\Db::createCommand Open
Open
$db->createCommand()->insert('u_#__reviewed_queue', [- Exclude checks
Default value for int $userId can't be false Open
Open
public static function reviewChanges($recordsList, $userId = false)- Exclude checks
Reference to undeclared property \ModTracker_Relation_Model->parent Open
Open
return $this->parent;- Exclude checks
Reference to undeclared property \ModTracker_Relation_Model->parent (Did you mean $parent) Open
Open
$this->parent = $parent;- Exclude checks
Call to undeclared method \App\Db\Query::from Open
Open
$id = (new \App\Db\Query())->from('u_#__reviewed_queue')->max('id') + 1;- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class ModTracker_Relation_Model extends Vtiger_Record_Model- Exclude checks
The class ModTracker_Relation_Model is not named in CamelCase. Open
Open
class ModTracker_Relation_Model extends Vtiger_Record_Model
{
protected $linkedRecordCache = [];
public function getValue()- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = \App\Db::getInstance();- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
$id = (new \App\Db\Query())->from('u_#__reviewed_queue')->max('id') + 1;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getParent()- Exclude checks
Line exceeds 120 characters; contains 149 characters Open
Open
return 'index.php?module=' . $this->get('targetmodule') . '&view=' . $moduleModel->getDetailViewName() . '&record=' . $this->get('targetid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $module - Module name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = \App\Db::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'id' => $id,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'data' => \App\Json::encode($data),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$id = (new \App\Db\Query())->from('u_#__reviewed_queue')->max('id') + 1;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \App\Record::getLabel($this->get('targetid'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'tabid' => \App\Module::getModuleId($module),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->parent;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
ModTracker_Record_Model::unsetReviewed($record, $userId, $result);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$currentUserModel = Users_Record_Model::getCurrentUserModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'userid' => $currentUserModel->getRealId(),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'time' => date('Y-m-d H:i:s'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function reviewChangesQueue($data, $module)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function reviewChanges($recordsList, $userId = false)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDetailViewUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $data - List of records to update- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db->createCommand()->insert('u_#__reviewed_queue', [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function setParent($parent)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$result = ModTracker_Record_Model::setLastReviewed($record);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'index.php?module=' . $this->get('targetmodule') . '&view=' . $moduleModel->getDetailViewName() . '&record=' . $this->get('targetid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function adds records to task queue that updates reviewing changes in records.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $userId - User id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $recordsList - List of records to update- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getValue()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->parent = $parent;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function return link to record.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleModel = Vtiger_Module_Model::getInstance($this->get('targetmodule'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($recordsList as $record) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $linkedRecordCache = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function marks forwarded records as reviewed.- Exclude checks
Class name "ModTracker_Relation_Model" is not in camel caps format Open
Open
class ModTracker_Relation_Model extends Vtiger_Record_Model- Exclude checks