Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Notification/dashboards/Notifications.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Notification_Module_Model' in method 'process'.
Open

        $notificationModel = Notification_Module_Model::getInstance($moduleName);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $viewer->view('dashboards/Notifications.tpl', $moduleName);
        }
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\App\User' in method 'process'.
Open

        $currentUserId = \App\User::getCurrentUserId();
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
Open

        $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Language' in method 'process'.
Open

        array_unshift($typesNotification, \App\Language::translate('All'));
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('MODULE_NAME', $moduleName);
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('WIDGET', $widget);
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Call to method getInstance from undeclared class \Vtiger_Widget_Model
Open

        $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('NOTIFICATIONS', $notifications);
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)
Open

        $currentUserId = \App\User::getCurrentUserId();
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Call to undeclared method \Vtiger_Viewer::assign
Open

        $viewer->assign('TYPES_NOTIFICATION', $typesNotification);
Severity: Critical
Found in modules/Notification/dashboards/Notifications.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Notification_Notifications_Dashboard extends Vtiger_IndexAjax_View
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

The class Notification_Notifications_Dashboard is not named in CamelCase.
Open

class Notification_Notifications_Dashboard extends Vtiger_IndexAjax_View
{
    public function process(App\Request $request)
    {
        $currentUserId = \App\User::getCurrentUserId();
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if ($request->has('content')) {
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $condition = ['u_#__notification.notification_type' => $request->getByType('type', 'Text')];
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $notificationModel = Notification_Module_Model::getInstance($moduleName);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $typesNotification = $notificationModel->getTypes();
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $viewer->view('dashboards/Notifications.tpl', $moduleName);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (!$request->isEmpty('type', true)) {
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        array_unshift($typesNotification, \App\Language::translate('All'));
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('WIDGET', $widget);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $widget = Vtiger_Widget_Model::getInstance($request->getInteger('linkid'), $currentUserId);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (empty($limit)) {
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('MODULE_NAME', $moduleName);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $limit = 10;
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        } else {
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('NOTIFICATIONS', $notifications);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('TYPES_NOTIFICATION', $typesNotification);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $notifications = $notificationModel->getEntriesInstance($limit, $condition);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $limit = $widget->get('limit');
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $viewer->view('dashboards/NotificationsContents.tpl', $moduleName);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $currentUserId = \App\User::getCurrentUserId();
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $condition = [];
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

Class name "Notification_Notifications_Dashboard" is not in camel caps format
Open

class Notification_Notifications_Dashboard extends Vtiger_IndexAjax_View
Severity: Minor
Found in modules/Notification/dashboards/Notifications.php by phpcodesniffer

There are no issues that match your filters.

Category
Status