Function save has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function save(): bool
{
$relatedRecord = $this->getRelatedRecord();
$relatedId = $relatedModule = false;
if (false !== $relatedRecord) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method save has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function save(): bool
{
$relatedRecord = $this->getRelatedRecord();
$relatedId = $relatedModule = false;
if (false !== $relatedRecord) {Function getRelatedRecord has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function getRelatedRecord()
{
$relatedId = false;
$subprocess = $this->get('subprocess');
$process = $this->get('process');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if (!empty($sl) && \App\Record::isExists($sl)) {
$relatedId = $sl;
} elseif (!empty($subprocess) && \App\Record::isExists($subprocess)) {
$relatedId = $subprocess;
} elseif (!empty($process) && \App\Record::isExists($process)) {The method save() has an NPath complexity of 9856. The configured NPath complexity threshold is 200. Open
public function save(): bool
{
$relatedRecord = $this->getRelatedRecord();
$relatedId = $relatedModule = false;
if (false !== $relatedRecord) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getRelatedRecord() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function getRelatedRecord()
{
$relatedId = false;
$subprocess = $this->get('subprocess');
$process = $this->get('process');- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method save() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10. Open
public function save(): bool
{
$relatedRecord = $this->getRelatedRecord();
$relatedId = $relatedModule = false;
if (false !== $relatedRecord) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed. Open
public function save(): bool- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
The class Notification_Record_Model has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Open
class Notification_Record_Model extends Vtiger_Record_Model
{
/**
* Function to parse content.
*- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid using static access to class '\App\TextParser' in method 'getParseField'. Open
$textParser = \App\TextParser::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getRelatedRecord'. Open
} elseif (!empty($process) && \App\Record::isExists($process)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Owner' in method 'save'. Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getParseField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$textParser = \App\TextParser::getInstance();
$textParser->setContent($value)->parseTranslations();
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Fields\Owner' in method 'save'. Open
$userType = \App\Fields\Owner::getType($userId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getRelatedRecord'. Open
if (!empty($sl) && \App\Record::isExists($sl)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Link_Model' in method 'getRecordListViewLinksLeftSide'. Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getRelatedRecord'. Open
} elseif (!empty($linkextend) && \App\Record::isExists($linkextend)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'save'. Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && \App\Record::isExists($relatedId)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getParseField'. Open
if (\App\Record::isExists($relatedId)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'save'. Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\TextParser' in method 'getParseField'. Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'save'. Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Record' in method 'getRelatedRecord'. Open
} elseif (!empty($link) && \App\Record::isExists($link)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Owner' in method 'getCreatorUser'. Open
return \App\Fields\Owner::getLabel($userid);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'save'. Open
\App\Log::error('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) .
' does not have permission for this record ' . $relatedId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getIcon uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$icon = [
'icon' => 'fas fa-hdd',
];
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getRelatedRecord uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return false;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Utils\Completions' in method 'getMessage'. Open
return \App\Utils\Completions::decode($this->getDisplayValue('description', $this->getId(), $this));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Privilege' in method 'save'. Open
if (!\App\Privilege::isPermitted('Notification', 'DetailView')) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'save'. Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\vtlib\Functions' in method 'getRelatedRecord'. Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$usersCollection[] = $userId;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Record' in method 'getRelatedRecord'. Open
} elseif (!empty($subprocess) && \App\Record::isExists($subprocess)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Privilege' in method 'save'. Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\TextParser' in method 'save'. Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\PrivilegeUtil' in method 'save'. Open
$usersCollection = array_merge($usersCollection, \App\PrivilegeUtil::getUsersByGroup($userId));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\TextUtils' in method 'save'. Open
$this->setFromUserValue('title', \App\TextUtils::textTruncate(\App\Purifier::purifyByType($textParser->setContent($this->get('title'))->parse()->getContent(), 'Text'), $this->getField('title')->getMaxValue(), false));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Purifier' in method 'save'. Open
$this->setFromUserValue('title', \App\TextUtils::textTruncate(\App\Purifier::purifyByType($textParser->setContent($this->get('title'))->parse()->getContent(), 'Text'), $this->getField('title')->getMaxValue(), false));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Privilege' in method 'save'. Open
if ($isNew && $relatedId && 'PLL_SYSTEM' === $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId, $userId)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Owner' in method 'save'. Open
\App\Log::error('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) .- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "module" 3 times. Open
$relatedModule = $relatedRecords['module'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "PLL_USERS" 3 times. Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId)) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "assigned_user_id" 5 times. Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "notification_type" 3 times. Open
return $this->get('notification_type');- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "description" 3 times. Open
return \App\Utils\Completions::decode($this->getDisplayValue('description', $this->getId(), $this));- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "title" 4 times. Open
return $this->getDisplayValue('title', $this->getId(), $this);- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "DetailView" 3 times. Open
if (!\App\Privilege::isPermitted('Notification', 'DetailView')) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Argument 3 (rawText) is \App\Base|\Notification_Record_Model|\Vtiger_Record_Model but \Notification_Record_Model::getDisplayValue() takes bool|false defined at /code/modules/Vtiger/models/Record.php:416 Open
return \App\Utils\Completions::decode($this->getDisplayValue('description', $this->getId(), $this));- Exclude checks
Call to method getLabel from undeclared class \App\Fields\Owner Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Exclude checks
Call to method warning from undeclared class \App\Log Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Exclude checks
Call to method trace from undeclared class \App\Log Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Exclude checks
Call to method getInstanceById from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser) Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Exclude checks
Call to method getType from undeclared class \App\Fields\Owner Open
$userType = \App\Fields\Owner::getType($userId);- Exclude checks
Call to method getInstance from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser) Open
$textParser = \App\TextParser::getInstance();- Exclude checks
Call to method decode from undeclared class \App\Utils\Completions Open
return \App\Utils\Completions::decode($this->getDisplayValue('description', $this->getId(), $this));- Exclude checks
Call to method trace from undeclared class \App\Log Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Exclude checks
Argument 3 (rawText) is \App\Base|\Notification_Record_Model|\Vtiger_Record_Model but \Notification_Record_Model::getDisplayValue() takes bool|false defined at /code/modules/Vtiger/models/Record.php:416 Open
return $this->getDisplayValue('title', $this->getId(), $this);- Exclude checks
Call to method getLabel from undeclared class \App\Fields\Owner Open
return \App\Fields\Owner::getLabel($userid);- Exclude checks
Returning type false but getRelatedRecord() is declared to return array Open
return false;- Exclude checks
Call to method getLabel from undeclared class \App\Fields\Owner Open
\App\Log::error('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) .- Exclude checks
Call to method getInstanceById from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser) Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Exclude checks
false to array comparison Open
if (false !== $relatedRecord) {- Exclude checks
Call to method error from undeclared class \App\Log Open
\App\Log::error('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) .- Exclude checks
Call to method getUserModel from undeclared class \App\User (Did you mean class \Tests\App\User) Open
$icon = \App\User::getUserModel($this->get('smcreatorid'))->getImage();- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Notification_Record_Model extends Vtiger_Record_Model- Exclude checks
Avoid variables with short names like $sl. Configured minimum length is 3. Open
$sl = $this->get('subprocess_sl');- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Notification_Record_Model is not named in CamelCase. Open
class Notification_Record_Model extends Vtiger_Record_Model
{
/**
* Function to parse content.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$value = $this->get($fieldName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$textParser->setContent($value)->parseTranslations();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$subprocess = $this->get('subprocess');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getCreatorUser()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $relatedModule = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($userid)) {- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->set('shownerid', null);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return Vtiger_Link_Model[] - Associate array of Vtiger_Link_Model instances- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linktype' => 'LIST_VIEW_ACTIONS_RECORD_LEFT_SIDE',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $sl;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param string $fieldName- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} elseif (!empty($subprocess) && \App\Record::isExists($subprocess)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return false;- Exclude checks
Line exceeds 120 characters; contains 134 characters Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$users = \is_array($users) ? $users : explode(',', $users);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($isNew) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Return message of notification.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getMessage(): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get the most important records.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $subprocess;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get name of user who create this notification.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::error('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) .- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->isNew = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedModule = $relatedRecords['module'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (\App\Record::isExists($relatedId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$textParser->setContent($value)->parse();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $process;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return ['id' => $relatedId, 'module' => \vtlib\Functions::getCRMRecordMetadata($relatedId)['setype']];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userid = $this->get('smcreatorid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->setFromUserValue('title', \App\TextUtils::textTruncate(\App\Purifier::purifyByType($textParser->setContent($this->get('title'))->parse()->getContent(), 'Text'), $this->getField('title')->getMaxValue(), false));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($users)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userType = \App\Fields\Owner::getType($userId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$usersCollection[] = $userId;- Exclude checks
Line exceeds 120 characters; contains 160 characters Open
if ($isNew && $relatedId && 'PLL_SYSTEM' === $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId, $userId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $icon;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return nl2br(str_replace("<br>\n", '<br>', $textParser->getContent()));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$link = $this->get('link');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($this->getModule()->isPermitted('EditView') && $this->isEditable()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linklabel' => 'LBL_MARK_AS_READ',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkurl' => 'javascript:Notification_List_Js.setAsMarked(' . $this->getId() . ')',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkicon' => 'fas fa-check',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getParseField($fieldName)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return \App\Fields\Owner::getLabel($userid);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (false !== $relatedRecord) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($isNew && $relatedId && 'PLL_SYSTEM' === $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId, $userId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$icon = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get the list view actions for the record.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$recordLinks[] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getTitle()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getTypeName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function setMarked()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} elseif (!empty($link) && \App\Record::isExists($link)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$notificationType = $this->get('notification_type');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
' does not have permission for this record ' . $relatedId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->setFromUserValue('description', $textParser->withoutTranslations()->setContent($this->get('description'))->parse()->getContent());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
parent::save();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$icon = \App\User::getUserModel($this->get('smcreatorid'))->getImage();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$isNew = $this->isNew;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$icon = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($recordLinks as $recordLink) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($relatedRecords['id'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($sl) && \App\Record::isExists($sl)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function save(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $relatedRecord['id'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && !\App\Privilege::isPermitted($relatedModule, 'DetailView', $relatedId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$usersCollection = $this->isEmpty('assigned_user_id') ? [] : [$this->get('assigned_user_id')];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->set('assigned_user_id', $userId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$links = parent::getRecordListViewLinksLeftSide();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$recordLinks = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to set notification as read.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} elseif (!empty($process) && \App\Record::isExists($process)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $link;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Line exceeds 120 characters; contains 229 characters Open
$this->setFromUserValue('title', \App\TextUtils::textTruncate(\App\Purifier::purifyByType($textParser->setContent($this->get('title'))->parse()->getContent(), 'Text'), $this->getField('title')->getMaxValue(), false));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to parse content.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$textParser = \App\TextParser::getInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Title.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->save();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$linkextend = $this->get('linkextend');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sl = $this->get('subprocess_sl');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} elseif (!empty($linkextend) && \App\Record::isExists($linkextend)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $linkextend;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedRecord = $this->getRelatedRecord();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$usersCollection = array_unique($usersCollection);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'linkclass' => 'btn-sm btn-default',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Return name type notification.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $this->get('notification_type');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getRelatedRecord()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$users = $this->get('shownerid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
continue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedRecords = $this->getRelatedRecord();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$textParser = \App\TextParser::getInstanceById($relatedId, $relatedModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @throws \Exception- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedModule = $relatedRecord['module'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::warning('User ' . \App\Fields\Owner::getLabel($this->get('assigned_user_id')) . ' has no active notifications');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ('Groups' === $userType) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get icon for notification.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'icon' => 'fas fa-hdd',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getRecordListViewLinksLeftSide()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $this->getDisplayValue('title', $this->getId(), $this);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return \App\Utils\Completions::decode($this->getDisplayValue('description', $this->getId(), $this));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return array- Exclude checks
Line exceeds 120 characters; contains 149 characters Open
$this->setFromUserValue('description', $textParser->withoutTranslations()->setContent($this->get('description'))->parse()->getContent());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($usersCollection as $userId) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return array params icon- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ('PLL_USERS' === $this->get('notification_type')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$relatedId = $relatedRecords['id'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->set('notification_status', 'PLL_READ');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$process = $this->get('process');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to save record.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!\App\Privilege::isPermitted('Notification', 'DetailView')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::trace('Exiting ' . __METHOD__ . ' - return true');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($relatedModule && 'PLL_USERS' !== $notificationType && \App\Record::isExists($relatedId)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($users as $userId) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$usersCollection = array_merge($usersCollection, \App\PrivilegeUtil::getUsersByGroup($userId));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getIcon()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $links;- Exclude checks
Class name "Notification_Record_Model" is not in camel caps format Open
class Notification_Record_Model extends Vtiger_Record_Model- Exclude checks