modules/OSSMailScanner/scanneractions/BindPartners.php
Avoid unused parameters such as '$moduleName'. Open
Open
public function process(OSSMail_Mail_Model $mail, $moduleName = 'Partners')- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid excessively long class names like OSSMailScanner_BindPartners_ScannerAction. Keep class name length under 40. Open
Open
class OSSMailScanner_BindPartners_ScannerAction extends OSSMailScanner_EmailScannerAction_Model
{
public function process(OSSMail_Mail_Model $mail, $moduleName = 'Partners')
{
return parent::process($mail, 'Partners');- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class OSSMailScanner_BindPartners_ScannerAction extends OSSMailScanner_EmailScannerAction_Model- Exclude checks
The class OSSMailScanner_BindPartners_ScannerAction is not named in CamelCase. Open
Open
class OSSMailScanner_BindPartners_ScannerAction extends OSSMailScanner_EmailScannerAction_Model
{
public function process(OSSMail_Mail_Model $mail, $moduleName = 'Partners')
{
return parent::process($mail, 'Partners');- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(OSSMail_Mail_Model $mail, $moduleName = 'Partners')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return parent::process($mail, 'Partners');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Class name "OSSMailScanner_BindPartners_ScannerAction" is not in camel caps format Open
Open
class OSSMailScanner_BindPartners_ScannerAction extends OSSMailScanner_EmailScannerAction_Model- Exclude checks