Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/OSSMailScanner/scanneractions/BindServiceContracts.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(OSSMail_Mail_Model $mail)
    {
        $mailId = $mail->getMailCrmId();
        $returnIds = [];
        if (!$mailId) {
Severity: Minor
Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(OSSMail_Mail_Model $mail)
    {
        $mailId = $mail->getMailCrmId();
        $returnIds = [];
        if (!$mailId) {
Severity: Minor
Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php - About 1 hr to fix

    The method process() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function process(OSSMail_Mail_Model $mail)
    {
        $mailId = $mail->getMailCrmId();
        $returnIds = [];
        if (!$mailId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '43', column '19').
    Open

                $result = (new App\Db\Query())->select(['servicecontractsid'])->from('vtiger_servicecontracts')->innerJoin('vtiger_crmentity', 'vtiger_servicecontracts.servicecontractsid = vtiger_crmentity.crmid')->where(['vtiger_crmentity.deleted' => 0, 'sc_related_to' => $accountNumbers, 'contract_status' => 'In Progress'])->limit(2)->column();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '46', column '20').
    Open

                    $status = (new OSSMailView_Relation_Model())->addRelation($mailId, $serviceContractsId, $mail->get('date'));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Call to undeclared method \App\Db\Query::select
    Open

                $result = (new App\Db\Query())->select(['servicecontractsid'])->from('vtiger_servicecontracts')->innerJoin('vtiger_crmentity', 'vtiger_servicecontracts.servicecontractsid = vtiger_crmentity.crmid')->where(['vtiger_crmentity.deleted' => 0, 'sc_related_to' => $accountNumbers, 'contract_status' => 'In Progress'])->limit(2)->column();
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phan

    Avoid excessively long class names like OSSMailScanner_BindServiceContracts_ScannerAction. Keep class name length under 40.
    Open

    class OSSMailScanner_BindServiceContracts_ScannerAction
{
    /**
     * Process.
     *
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class OSSMailScanner_BindServiceContracts_ScannerAction
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    The class OSSMailScanner_BindServiceContracts_ScannerAction is not named in CamelCase.
    Open

    class OSSMailScanner_BindServiceContracts_ScannerAction
{
    /**
     * Process.
     *
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $returnIds = [];
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param OSSMail_Mail_Model $mail
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $accountNumbers = [];
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($accounts) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $mailId = $mail->getMailCrmId();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $serviceContractsId = current($result);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $returnIds[] = $serviceContractsId;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (isset($accounts[$key]) && \is_array($accounts[$key])) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($keys as $key) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $status = (new OSSMailView_Relation_Model())->addRelation($mailId, $serviceContractsId, $mail->get('date'));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(OSSMail_Mail_Model $mail)
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Process.
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return $returnIds;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $result = (new App\Db\Query())->select(['servicecontractsid'])->from('vtiger_servicecontracts')->innerJoin('vtiger_crmentity', 'vtiger_servicecontracts.servicecontractsid = vtiger_crmentity.crmid')->where(['vtiger_crmentity.deleted' => 0, 'sc_related_to' => $accountNumbers, 'contract_status' => 'In Progress'])->limit(2)->column();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

                    $status = (new OSSMailView_Relation_Model())->addRelation($mailId, $serviceContractsId, $mail->get('date'));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $accountNumbers = array_merge($accountNumbers, $accounts[$key]);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($accountNumbers) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$mailId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Line exceeds 120 characters; contains 344 characters
    Open

                $result = (new App\Db\Query())->select(['servicecontractsid'])->from('vtiger_servicecontracts')->innerJoin('vtiger_crmentity', 'vtiger_servicecontracts.servicecontractsid = vtiger_crmentity.crmid')->where(['vtiger_crmentity.deleted' => 0, 'sc_related_to' => $accountNumbers, 'contract_status' => 'In Progress'])->limit(2)->column();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $returnIds;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $keys = ['BindAccounts', 'BindContacts', 'BindLeads', 'BindHelpDesk'];
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($result && 1 === \count($result)) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($status) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $accounts = $mail->getActionResult('Accounts');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    Class name "OSSMailScanner_BindServiceContracts_ScannerAction" is not in camel caps format
    Open

    class OSSMailScanner_BindServiceContracts_ScannerAction
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/BindServiceContracts.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status