Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php

Summary

Maintainability
B
6 hrs
Test Coverage
F
0%

Method add has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
Severity: Major
Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php - About 2 hrs to fix

    Function add has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function process(OSSMail_Mail_Model $mail)
    {
        $this->mail = $mail;
        $id = $recordId = 0;
        $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('subject'), 'HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method add() has an NPath complexity of 2880. The configured NPath complexity threshold is 200.
    Open

        public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method add() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
    Open

        public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
    Open

        public function add()
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Missing class import via use statement (line '57', column '21').
    Open

                $parentId = (new App\Db\Query())->select(['parentid'])->from('vtiger_contactdetails')->where(['contactid' => $contactId])->scalar();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '104', column '18').
    Open

                $query = (new App\Db\Query())->select(['documentsid'])->from('vtiger_ossmailview_files')->where(['ossmailviewid' => $mailId]);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '61', column '26').
    Open

                $queryGenerator = new \App\QueryGenerator('ServiceContracts');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Vtiger_Record_Model' in method 'add'.
    Open

            $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'OSSMailScanner_Record_Model' in method 'process'.
    Open

            $exceptionsAll = OSSMailScanner_Record_Model::getConfig('exceptions');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method add uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $queryGenerator->addCondition('contract_status', 'In Progress', 'e');
            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\App\Mail\RecordFinder' in method 'process'.
    Open

                $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('body'), 'HelpDesk', true);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '65', column '116').
    Open

        public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\TextUtils' in method 'add'.
    Open

            $record->set('description', \App\TextUtils::htmlTruncate($this->mail->getContent(), $record->getField('description')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\RecordStatus' in method 'add'.
    Open

                if (($queryGenerator->getModuleField('contract_status')->getFieldParams()['isProcessStatusField'] ?? false) && ($status = \App\RecordStatus::getStates('ServiceContracts', \App\RecordStatus::RECORD_STATE_OPEN))) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Fields\Picklist' in method 'add'.
    Open

                    if (App\Fields\Picklist::isExists('ticketpriorities', $serviceContracts['contract_priority'])) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Mail\RecordFinder' in method 'process'.
    Open

            $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('subject'), 'HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '93', column '7').
    Open

        public function add()
    {
        $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
        $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
        $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\TextUtils' in method 'add'.
    Open

            $record->setFromUserValue('ticket_title', \App\TextUtils::textTruncate($this->mail->get('subject'), $record->getField('ticket_title')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "contract_status" 3 times.
    Open

                if (($queryGenerator->getModuleField('contract_status')->getFieldParams()['isProcessStatusField'] ?? false) && ($status = \App\RecordStatus::getStates('ServiceContracts', \App\RecordStatus::RECORD_STATE_OPEN))) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "contract_priority" 3 times.
    Open

                $queryGenerator->setFields(['id', 'contract_priority']);
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "HelpDesk" 3 times.
    Open

            $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('subject'), 'HelpDesk');
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "from_email" 3 times.
    Open

                    if (false !== strpos($mail->get('from_email'), $exception)) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Reference to static property helpdeskCreateDefaultStatus from undeclared class \Config\Modules\OSSMailScanner
    Open

            if (!empty(\Config\Modules\OSSMailScanner::$helpdeskCreateDefaultStatus)) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method getConfig from undeclared class \OSSMailScanner_Record_Model
    Open

            $exceptionsAll = OSSMailScanner_Record_Model::getConfig('exceptions');
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Reference to instance property permissions from undeclared class \App\QueryGenerator
    Open

                $queryGenerator->permissions = false;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Declaration of function add() : int should be compatible with function add() : array defined in /code/modules/OSSMailScanner/models/PrefixScannerAction.php:70
    Open

        public function add()
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                $queryGenerator->addNativeCondition(['vtiger_servicecontracts.sc_related_to' => $parentId]);
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method addCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator->addCondition('contract_status', $status, 'e');
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method createQuery from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                $dataReader = $queryGenerator->createQuery()->createCommand()->query();
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Reference to static property searchPrefixInBody from undeclared class \Config\Modules\OSSMailScanner
    Open

            if (empty($this->prefix) && \Config\Modules\OSSMailScanner::$searchPrefixInBody) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method getModuleField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                if (($queryGenerator->getModuleField('contract_status')->getFieldParams()['isProcessStatusField'] ?? false) && ($status = \App\RecordStatus::getStates('ServiceContracts', \App\RecordStatus::RECORD_STATE_OPEN))) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                $queryGenerator = new \App\QueryGenerator('ServiceContracts');
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Reference to static property helpdeskCreateWithoutNoRelation from undeclared class \Config\Modules\OSSMailScanner
    Open

            if (!$contactId && !$parentId && !\Config\Modules\OSSMailScanner::$helpdeskCreateWithoutNoRelation) {
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method addCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator->addCondition('contract_status', 'In Progress', 'e');
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

            $dbCommand = \App\Db::getInstance()->createCommand();
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Reference to static property helpdeskCreateDefaultStatus from undeclared class \Config\Modules\OSSMailScanner
    Open

                $record->set('ticketstatus', \Config\Modules\OSSMailScanner::$helpdeskCreateDefaultStatus);
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

                $parentId = (new App\Db\Query())->select(['parentid'])->from('vtiger_contactdetails')->where(['contactid' => $contactId])->scalar();
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                $queryGenerator->setFields(['id', 'contract_priority']);
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

                $query = (new App\Db\Query())->select(['documentsid'])->from('vtiger_ossmailview_files')->where(['ossmailviewid' => $mailId]);
    Severity: Critical
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phan

    Avoid excessively long class names like OSSMailScanner_CreatedHelpDesk_ScannerAction. Keep class name length under 40.
    Open

    class OSSMailScanner_CreatedHelpDesk_ScannerAction extends OSSMailScanner_BindHelpDesk_ScannerAction
{
    /** {@inheritdoc} */
    public function process(OSSMail_Mail_Model $mail)
    {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class OSSMailScanner_CreatedHelpDesk_ScannerAction extends OSSMailScanner_BindHelpDesk_ScannerAction
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            $id = $recordId = 0;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class OSSMailScanner_CreatedHelpDesk_ScannerAction is not named in CamelCase.
    Open

    class OSSMailScanner_CreatedHelpDesk_ScannerAction extends OSSMailScanner_BindHelpDesk_ScannerAction
{
    /** {@inheritdoc} */
    public function process(OSSMail_Mail_Model $mail)
    {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

            $id = $record->getId();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $exceptionsAll = OSSMailScanner_Record_Model::getConfig('exceptions');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($exceptions as $exception) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record = Vtiger_Record_Model::getCleanInstance('HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $record->set('parent_id', $parentId);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        return '';
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$contactId && !$parentId && !\Config\Modules\OSSMailScanner::$helpdeskCreateWithoutNoRelation) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return 0;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $accountOwner = $this->mail->getAccountOwner();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 142 characters
    Open

            $record->set('description', \App\TextUtils::htmlTruncate($this->mail->getContent(), $record->getField('description')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'relatedModule' => 'Contacts',
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                while ($documentId = $dataReader->readColumn(0)) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('body'), 'HelpDesk', true);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$recordId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $queryGenerator->addNativeCondition(['vtiger_servicecontracts.sc_related_to' => $parentId]);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record->setFromUserValue('ticket_title', \App\TextUtils::textTruncate($this->mail->get('subject'), $record->getField('ticket_title')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($contactId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dbCommand->update('vtiger_crmentity', ['createdtime' => $this->mail->get('date'), 'smcreatorid' => $accountOwner], ['crmid' => $id])->execute();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $record->set('ticketstatus', \Config\Modules\OSSMailScanner::$helpdeskCreateDefaultStatus);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $id = $recordId = 0;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($mailId = $this->mail->getMailCrmId()) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $exceptions = explode(',', $exceptionsAll['crating_tickets']);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $record->ext['relations'][] = [
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 224 characters
    Open

                if (($queryGenerator->getModuleField('contract_status')->getFieldParams()['isProcessStatusField'] ?? false) && ($status = \App\RecordStatus::getStates('ServiceContracts', \App\RecordStatus::RECORD_STATE_OPEN))) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $queryGenerator->addCondition('contract_status', $status, 'e');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $record->set('servicecontractsid', $serviceContracts['id']);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record->save();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->mail = $mail;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($this->prefix) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (false !== strpos($mail->get('from_email'), $exception)) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty(\Config\Modules\OSSMailScanner::$helpdeskCreateDefaultStatus)) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $parentId = (int) $this->mail->findEmailAddress('from_email', 'Accounts', false);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $parentId = (new App\Db\Query())->select(['parentid'])->from('vtiger_contactdetails')->where(['contactid' => $contactId])->scalar();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader->close();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record->set('assigned_user_id', $accountOwner);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $record->set('description', \App\TextUtils::htmlTruncate($this->mail->getContent(), $record->getField('description')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($mailId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 138 characters
    Open

                $query = (new App\Db\Query())->select(['documentsid'])->from('vtiger_ossmailview_files')->where(['ossmailviewid' => $mailId]);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($exceptionsAll['crating_tickets'])) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Creating a HelpDesk from an email.
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 159 characters
    Open

            $record->setFromUserValue('ticket_title', \App\TextUtils::textTruncate($this->mail->get('subject'), $record->getField('ticket_title')->getMaxValue()));
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $id = $this->add();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dbCommand = \App\Db::getInstance()->createCommand();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $serviceContracts = $dataReader->read();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $record->ext['relations'][] = [
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $id = $record->getId();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query = (new App\Db\Query())->select(['documentsid'])->from('vtiger_ossmailview_files')->where(['ossmailviewid' => $mailId]);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 144 characters
    Open

                $parentId = (new App\Db\Query())->select(['parentid'])->from('vtiger_contactdetails')->where(['contactid' => $contactId])->scalar();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $queryGenerator->addCondition('contract_status', 'In Progress', 'e');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return int
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($parentId) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (($queryGenerator->getModuleField('contract_status')->getFieldParams()['isProcessStatusField'] ?? false) && ($status = \App\RecordStatus::getStates('ServiceContracts', \App\RecordStatus::RECORD_STATE_OPEN))) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ];
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'params' => $this->mail->get('date'),
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $id;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->prefix = \App\Mail\RecordFinder::getRecordNumberFromString($mail->get('subject'), 'HelpDesk');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $id;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($parentId) && !empty($contactId)) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $queryGenerator = new \App\QueryGenerator('ServiceContracts');
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                } else {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'relatedRecords' => [$contactId],
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'relatedRecords' => [$mailId],
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($this->prefix) && \Config\Modules\OSSMailScanner::$searchPrefixInBody) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'reverse' => true,
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $dbCommand->insert('vtiger_senotesrel', ['crmid' => $id, 'notesid' => $documentId])->execute();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $queryGenerator->setFields(['id', 'contract_priority']);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (1 === $dataReader->count()) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Line exceeds 120 characters; contains 153 characters
    Open

            $dbCommand->update('vtiger_crmentity', ['createdtime' => $this->mail->get('date'), 'smcreatorid' => $accountOwner], ['crmid' => $id])->execute();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordId = $this->findRecord();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader = $queryGenerator->createQuery()->createCommand()->query();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(OSSMail_Mail_Model $mail)
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function add()
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $contactId = (int) $this->mail->findEmailAddress('from_email', 'Contacts', false);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $queryGenerator->permissions = false;
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (App\Fields\Picklist::isExists('ticketpriorities', $serviceContracts['contract_priority'])) {
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $record->set('ticketpriorities', $serviceContracts['contract_priority']);
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'relatedModule' => 'OSSMailView',
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ];
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader = $query->createCommand()->query();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader->close();
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    Class name "OSSMailScanner_CreatedHelpDesk_ScannerAction" is not in camel caps format
    Open

    class OSSMailScanner_CreatedHelpDesk_ScannerAction extends OSSMailScanner_BindHelpDesk_ScannerAction
    Severity: Minor
    Found in modules/OSSMailScanner/scanneractions/CreatedHelpDesk.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status