modules/OSSMailView/views/List.php
Avoid unused parameters such as '$moduleName'. Open
Open
public function isEditable($moduleName)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class OSSMailView_List_View extends Vtiger_List_View- Exclude checks
The class OSSMailView_List_View is not named in CamelCase. Open
Open
class OSSMailView_List_View extends Vtiger_List_View
{
public function isEditable($moduleName)
{
return false;- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function isEditable($moduleName)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return false;- Exclude checks
Class name "OSSMailView_List_View" is not in camel caps format Open
Open
class OSSMailView_List_View extends Vtiger_List_View- Exclude checks