Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/OSSTimeControl/models/Record.php

Summary

Maintainability
A
3 hrs
Test Coverage
F
0%

Missing class import via use statement (line '21', column '15').
Open

        $date = new DateTime();
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'DateTimeField' in method 'getDuplicateRecordUrl'.
Open

        $currDate = DateTimeField::convertToUserFormat($date->format('Y-m-d'));
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \App\Db::createCommand
Open

        \App\Db::getInstance()->createCommand()->update('vtiger_osstimecontrol', ['deleted' => $stateId], ['osstimecontrolid' => $this->getId()])->execute();
Severity: Critical
Found in modules/OSSTimeControl/models/Record.php by phan

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function getDuplicateRecordUrl()
    {
        $module = $this->getModule();
        $date = new DateTime();
        $currDate = DateTimeField::convertToUserFormat($date->format('Y-m-d'));
Severity: Major
Found in modules/OSSTimeControl/models/Record.php and 1 other location - About 2 hrs to fix
modules/Reservations/models/Record.php on lines 21..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function changeState($state)
    {
        parent::changeState($state);
        $stateId = 0;
        switch ($state) {
Severity: Major
Found in modules/OSSTimeControl/models/Record.php and 1 other location - About 1 hr to fix
modules/Calendar/models/Record.php on lines 307..325

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class OSSTimeControl_Record_Model extends Vtiger_Record_Model
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

The class OSSTimeControl_Record_Model is not named in CamelCase.
Open

class OSSTimeControl_Record_Model extends Vtiger_Record_Model
{
    /**
     * Recalculate status.
     */
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        $module = $this->getModule();
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return 'index.php?module=' . $this->getModuleName() . '&view=' . $module->getEditViewName() . '&record=' . $this->getId() . '&isDuplicate=true&date_start='
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function changeState($state)
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::changeState($state);
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $stateId = 0;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Line exceeds 120 characters; contains 163 characters
Open

        return 'index.php?module=' . $this->getModuleName() . '&view=' . $module->getEditViewName() . '&record=' . $this->getId() . '&isDuplicate=true&date_start='
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                break;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $time = $date->format('H:i');
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                break;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Line exceeds 120 characters; contains 157 characters
Open

        \App\Db::getInstance()->createCommand()->update('vtiger_osstimecontrol', ['deleted' => $stateId], ['osstimecontrolid' => $this->getId()])->execute();
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            default:
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $stateId = 0;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Recalculate status.
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $currDate = DateTimeField::convertToUserFormat($date->format('Y-m-d'));
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            case 'Archived':
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        \App\Db::getInstance()->createCommand()->update('vtiger_osstimecontrol', ['deleted' => $stateId], ['osstimecontrolid' => $this->getId()])->execute();
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            . $currDate . '&due_date=' . $currDate . '&time_start=' . $time . '&time_end=' . $time;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $date = new DateTime();
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            case 'Active':
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                break;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                break;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            case 'Trash':
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    const RECALCULATE_STATUS = 'Accepted';
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $stateId = 2;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getDuplicateRecordUrl()
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        switch ($state) {
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $stateId = 1;
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

Class name "OSSTimeControl_Record_Model" is not in camel caps format
Open

class OSSTimeControl_Record_Model extends Vtiger_Record_Model
Severity: Minor
Found in modules/OSSTimeControl/models/Record.php by phpcodesniffer

There are no issues that match your filters.

Category
Status