modules/Occurrences/views/Calendar.php
The method postProcess has a boolean flag argument $display, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function postProcess(App\Request $request, $display = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Call to undeclared method \Vtiger_Viewer::assign Open
Open
$viewer->assign('SHOW_TYPE', true);- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Occurrences_Calendar_View extends Vtiger_Calendar_View- Exclude checks
The class Occurrences_Calendar_View is not named in CamelCase. Open
Open
class Occurrences_Calendar_View extends Vtiger_Calendar_View
{
/** {@inheritdoc} */
public function postProcess(App\Request $request, $display = true)
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
parent::postProcess($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('SHOW_TYPE', true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function postProcess(App\Request $request, $display = true)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Class name "Occurrences_Calendar_View" is not in camel caps format Open
Open
class Occurrences_Calendar_View extends Vtiger_Calendar_View- Exclude checks