modules/Partners/models/Module.php
Missing class import via use statement (line '23', column '84'). Open
Open
$queryGenerator->addNativeCondition(['not in', 'u_#__partners.partnersid', (new App\Db\Query())->select(['crmid'])- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused parameters such as '$field'. Open
Open
public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to undeclared method \App\Db\Query::select Open
Open
$queryGenerator->addNativeCondition(['not in', 'u_#__partners.partnersid', (new App\Db\Query())->select(['crmid'])- Exclude checks
Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
$queryGenerator->addNativeCondition(['not in', 'u_#__partners.partnersid', (new App\Db\Query())->select(['crmid'])- Exclude checks
Parameter $queryGenerator has undeclared type \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator) Open
Open
public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Partners_Module_Model extends Vtiger_Module_Model- Exclude checks
The class Partners_Module_Model is not named in CamelCase. Open
Open
class Partners_Module_Model extends Vtiger_Module_Model
{
/**
* Function to get list view query for popup window.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ('Campaigns' == $sourceModule) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['campaignid' => $record]),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\QueryGenerator $queryGenerator- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
Open
$queryGenerator->addNativeCondition(['not in', 'u_#__partners.partnersid', (new App\Db\Query())->select(['crmid'])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $sourceModule Parent module- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $field parent fieldname- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $record parent id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get list view query for popup window.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$queryGenerator->addNativeCondition(['not in', 'u_#__partners.partnersid', (new App\Db\Query())->select(['crmid'])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->from('vtiger_campaign_records')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Partners_Module_Model" is not in camel caps format Open
Open
class Partners_Module_Model extends Vtiger_Module_Model- Exclude checks