YetiForceCompany/YetiForceCRM

View on GitHub
modules/PaymentsIn/handlers/PaymentsInHandler.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class 'PaymentsIn_SSingleOrdersPaymentStatus_Model' in method 'entityAfterSave'.
Open

        PaymentsIn_SSingleOrdersPaymentStatus_Model::updateIfPossible($recordModel);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PaymentsIn_FinvoicePaymentStatus_Model' in method 'entityAfterSave'.
Open

        PaymentsIn_FinvoicePaymentStatus_Model::updateIfPossible($recordModel);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'PaymentsIn_FinvoiceProformaPaymentStatus_Model' in method 'entityAfterSave'.
Open

        PaymentsIn_FinvoiceProformaPaymentStatus_Model::updateIfPossible($recordModel);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class PaymentsIn_PaymentsInHandler_Handler

The class PaymentsIn_PaymentsInHandler_Handler is not named in CamelCase.
Open

class PaymentsIn_PaymentsInHandler_Handler
{
    /**
     * EntityAfterSave handler function.
     *

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

        PaymentsIn_FinvoicePaymentStatus_Model::updateIfPossible($recordModel);

Spaces must be used to indent lines; tabs are not allowed
Open

    public function entityAfterSave(App\EventHandler $eventHandler)

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return void

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

     * EntityAfterSave handler function.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

        $recordModel = $eventHandler->getRecordModel();

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param App\EventHandler $eventHandler

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

        PaymentsIn_FinvoiceProformaPaymentStatus_Model::updateIfPossible($recordModel);

Spaces must be used to indent lines; tabs are not allowed
Open

        PaymentsIn_SSingleOrdersPaymentStatus_Model::updateIfPossible($recordModel);

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Class name "PaymentsIn_PaymentsInHandler_Handler" is not in camel caps format
Open

class PaymentsIn_PaymentsInHandler_Handler

There are no issues that match your filters.

Category
Status