modules/PriceBooks/models/Relation.php
Avoid using static access to class 'PriceBooks_Record_Model' in method 'addListPrice'. Open
Open
$priceBookModel = PriceBooks_Record_Model::getInstanceById($sourceRecordId, $this->getParentModuleModel()->get('name'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class PriceBooks_Relation_Model extends Vtiger_Relation_Model- Exclude checks
The class PriceBooks_Relation_Model is not named in CamelCase. Open
Open
class PriceBooks_Relation_Model extends Vtiger_Relation_Model
{
/**
* Function to add PriceBook-Products/Services Relation.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $sourceRecordId- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$priceBookModel = PriceBooks_Record_Model::getInstanceById($sourceRecordId, $this->getParentModuleModel()->get('name'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Line exceeds 120 characters; contains 128 characters Open
Open
$priceBookModel = PriceBooks_Record_Model::getInstanceById($sourceRecordId, $this->getParentModuleModel()->get('name'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function addListPrice(int $sourceRecordId, int $destinationRecordId, $value, string $name = 'listprice')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param mixed $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $priceBookModel->updateListPrice($destinationRecordId, $value, $name);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to add PriceBook-Products/Services Relation.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $destinationRecordId- Exclude checks
Class name "PriceBooks_Relation_Model" is not in camel caps format Open
Open
class PriceBooks_Relation_Model extends Vtiger_Relation_Model- Exclude checks