Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Products/relations/GetManyToMany.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Avoid using static access to class '\Vtiger_Relation_Model' in method 'getQuery'.
Open

            $referenceInfo = \Vtiger_Relation_Model::getReferenceTableInfo($relatedModuleName, $parentModuleName);
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method setCustomColumn from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
Open

            $this->relationModel->getQueryGenerator()->setCustomColumn(['qtyinstock' => $referenceInfo['table'] . '.qtyinstock']);
Severity: Critical
Found in modules/Products/relations/GetManyToMany.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Main file that includes basic operations on relations.
 *
 * @package   Relation
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php and 1 other location - About 1 hr to fix
modules/IStorages/relations/GetManyToMany.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Products_GetManyToMany_Relation extends Vtiger_GetManyToMany_Relation
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

The class Products_GetManyToMany_Relation is not named in CamelCase.
Open

class Products_GetManyToMany_Relation extends Vtiger_GetManyToMany_Relation
{
    /** {@inheritdoc} */
    public function getQuery()
    {
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getQuery()
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $relatedModuleName = $this->relationModel->getRelationModuleName();
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

            $this->relationModel->getQueryGenerator()->setCustomColumn(['qtyinstock' => $referenceInfo['table'] . '.qtyinstock']);
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $parentModuleName = $this->relationModel->getParentModuleModel()->getName();
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if ('IStorages' === $relatedModuleName) {
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $referenceInfo = \Vtiger_Relation_Model::getReferenceTableInfo($relatedModuleName, $parentModuleName);
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::getQuery();
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $this->relationModel->getQueryGenerator()->setCustomColumn(['qtyinstock' => $referenceInfo['table'] . '.qtyinstock']);
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

Class name "Products_GetManyToMany_Relation" is not in camel caps format
Open

class Products_GetManyToMany_Relation extends Vtiger_GetManyToMany_Relation
Severity: Minor
Found in modules/Products/relations/GetManyToMany.php by phpcodesniffer

There are no issues that match your filters.

Category
Status