modules/Products/views/Detail.php
Class extends undeclared class \Vtiger_Detail_View Open
Open
class Products_Detail_View extends Vtiger_Detail_View- Exclude checks
Call to undeclared method \Products_Detail_View::checkAndConvertJsScripts Open
Open
return array_merge($headerScriptInstances, $this->checkAndConvertJsScripts([- Exclude checks
Reference to undeclared class \Vtiger_Detail_View Open
Open
$headerScriptInstances = parent::getFooterScripts($request);- Exclude checks
Avoid excessively long variable names like $headerScriptInstances. Keep variable name length under 20. Open
Open
$headerScriptInstances = parent::getFooterScripts($request);- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $moduleRelatedListFile. Keep variable name length under 20. Open
Open
$moduleRelatedListFile = 'modules.' . $moduleName . '.resources.RelatedList';- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Products_Detail_View extends Vtiger_Detail_View- Exclude checks
The class Products_Detail_View is not named in CamelCase. Open
Open
class Products_Detail_View extends Vtiger_Detail_View
{
/** {@inheritdoc} */
public function getFooterScripts(App\Request $request)
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
]));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFooterScripts(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return array_merge($headerScriptInstances, $this->checkAndConvertJsScripts([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'modules.PriceBooks.resources.RelatedList', $moduleDetailFile, $moduleRelatedListFile- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleRelatedListFile = 'modules.' . $moduleName . '.resources.RelatedList';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($headerScriptInstances[$moduleDetailFile], $headerScriptInstances[$moduleRelatedListFile]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$headerScriptInstances = parent::getFooterScripts($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleDetailFile = 'modules.' . $moduleName . '.resources.Detail';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Products_Detail_View" is not in camel caps format Open
Open
class Products_Detail_View extends Vtiger_Detail_View- Exclude checks