YetiForceCompany/YetiForceCRM

View on GitHub
modules/Project/ConfigTemplate.php

Summary

Maintainability
A
0 mins
Test Coverage
C
75%

Define a constant instead of duplicating this literal "sanitization" 3 times.
Open

        'sanitization' => function () {
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "PLL_IN_PROGRESSING" 3 times.
Open

                    'PLL_IN_PROGRESSING' => '#1976D2',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "PLL_ON_HOLD" 3 times.
Open

                    'PLL_ON_HOLD' => '#455A64',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "validation" 3 times.
Open

        'validation' => '\App\Validator::naturalNumber',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "PLL_COMPLETED" 3 times.
Open

                    'PLL_COMPLETED' => '#388E3C',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "PLL_PLANNED" 3 times.
Open

                    'PLL_PLANNED' => '#7B1FA2',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "default" 5 times.
Open

        'default' => [],
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "PLL_CANCELLED" 3 times.
Open

                    'PLL_CANCELLED' => '#616161',
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "description" 5 times.
Open

        'description' => 'Columns visible in Project hierarchy [$label => $columnName]'
Severity: Critical
Found in modules/Project/ConfigTemplate.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Columns visible in Project hierarchy [$label => $columnName]'

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => [

Spaces must be used to indent lines; tabs are not allowed
Open

            ],

Spaces must be used to indent lines; tabs are not allowed
Open

    ],

Spaces must be used to indent lines; tabs are not allowed
Open

        'validation' => '\App\Validator::bool',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_CANCELLED' => '#616161',

Line exceeds 120 characters; contains 176 characters
Open

        'description' => 'Default colors of statuses for gantt chart. f not specified - picklists colors are taken or random color is assigned if there is not one in picklist.'

Spaces must be used to indent lines; tabs are not allowed
Open

                'projectstatus' => [

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_PLANNED' => '#7986CB',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_ON_HOLD' => '#90A4AE',

Spaces must be used to indent lines; tabs are not allowed
Open

    'MAX_HIERARCHY_DEPTH' => [

Spaces must be used to indent lines; tabs are not allowed
Open

        'sanitization' => function () {

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => true,

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_IN_APPROVAL' => '#F57C00',

Spaces must be used to indent lines; tabs are not allowed
Open

                'projecttaskstatus' => [

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => true,

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => 50,

Spaces must be used to indent lines; tabs are not allowed
Open

    ],

Spaces must be used to indent lines; tabs are not allowed
Open

            'Project' => [

Spaces must be used to indent lines; tabs are not allowed
Open

            'ProjectMilestone' => [

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Default colors of statuses for gantt chart. f not specified - picklists colors are taken or random color is assigned if there is not one in picklist.'

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Show / hide Gantt tab in module Projects',

Spaces must be used to indent lines; tabs are not allowed
Open

    'COUNT_IN_HIERARCHY' => [

Spaces must be used to indent lines; tabs are not allowed
Open

    'defaultGanttColors' => [

Spaces must be used to indent lines; tabs are not allowed
Open

                ]

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_IN_PROGRESSING' => '#2196F3',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_ON_HOLD' => '#607D8B',

Spaces must be used to indent lines; tabs are not allowed
Open

                ]

Spaces must be used to indent lines; tabs are not allowed
Open

        'default' => [],

Spaces must be used to indent lines; tabs are not allowed
Open

        'validation' => '\App\Validator::naturalNumber',

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_COMPLETED' => '#388E3C',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_IN_PROGRESSING' => '#64B5F6',

Spaces must be used to indent lines; tabs are not allowed
Open

    ],

Spaces must be used to indent lines; tabs are not allowed
Open

            return (int) func_get_arg(0);

Spaces must be used to indent lines; tabs are not allowed
Open

        'sanitization' => '\App\Purifier::bool'

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_PLANNED' => '#7B1FA2',

Spaces must be used to indent lines; tabs are not allowed
Open

        'validation' => '\App\Validator::bool',

Spaces must be used to indent lines; tabs are not allowed
Open

                ]

Spaces must be used to indent lines; tabs are not allowed
Open

            ],

Spaces must be used to indent lines; tabs are not allowed
Open

        ],

Spaces must be used to indent lines; tabs are not allowed
Open

    ],

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_ON_HOLD' => '#455A64',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_CANCELLED' => '#E0E0E0'

Spaces must be used to indent lines; tabs are not allowed
Open

    'showGanttTab' => [

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_IN_PROGRESSING' => '#1976D2',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_COMPLETED' => '#4CAF50',

Spaces must be used to indent lines; tabs are not allowed
Open

            'ProjectTask' => [

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_COMPLETED' => '#81C784',

Spaces must be used to indent lines; tabs are not allowed
Open

    ],

Spaces must be used to indent lines; tabs are not allowed
Open

    'COLUMNS_IN_HIERARCHY' => [

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Max depth of hierarchy',

Spaces must be used to indent lines; tabs are not allowed
Open

        'description' => 'Count Projects in hierarchy',

Spaces must be used to indent lines; tabs are not allowed
Open

                'projectmilestone_status' => [

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_PLANNED' => '#3F51B5',

Spaces must be used to indent lines; tabs are not allowed
Open

                    'PLL_CANCELLED' => '#9E9E9E',

Spaces must be used to indent lines; tabs are not allowed
Open

            ],

Spaces must be used to indent lines; tabs are not allowed
Open

        'sanitization' => '\App\Purifier::bool'

There are no issues that match your filters.

Category
Status