Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Project/models/RelationListView.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

The method getCreateViewUrl has a boolean flag argument $fullView, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getCreateViewUrl(bool $fullView = false)
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Project_RelationListView_Model extends Vtiger_RelationListView_Model
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

The class Project_RelationListView_Model is not named in CamelCase.
Open

class Project_RelationListView_Model extends Vtiger_RelationListView_Model
{
    /** {@inheritdoc} */
    public function getCreateViewUrl(bool $fullView = false)
    {
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $relationModuleModel = $this->getRelationModel()->getRelationModuleModel();
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $createViewUrl .= '&parent_id=' . $this->getParentRecordModel()->get('linktoaccountscontacts');
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if ('HelpDesk' == $relationModuleModel->getName() && $relationModuleModel->getFieldByName('parent_id')->isViewable()) {
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Line exceeds 120 characters; contains 127 characters
Open

        if ('HelpDesk' == $relationModuleModel->getName() && $relationModuleModel->getFieldByName('parent_id')->isViewable()) {
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $createViewUrl;
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $createViewUrl = parent::getCreateViewUrl($fullView);
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getCreateViewUrl(bool $fullView = false)
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

Class name "Project_RelationListView_Model" is not in camel caps format
Open

class Project_RelationListView_Model extends Vtiger_RelationListView_Model
Severity: Minor
Found in modules/Project/models/RelationListView.php by phpcodesniffer

There are no issues that match your filters.

Category
Status