modules/Reservations/models/RecordPopover.php
Define a constant instead of duplicating this literal "far fa-clock" 5 times. Open
Open
return ['date_start' => 'far fa-clock', 'time_start' => 'far fa-clock', 'time_end' => 'far fa-clock', 'due_date' => 'far fa-clock', 'sum_time' => 'far fa-clock',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Reservations_RecordPopover_Model extends Vtiger_RecordPopover_Model- Exclude checks
The class Reservations_RecordPopover_Model is not named in CamelCase. Open
Open
class Reservations_RecordPopover_Model extends Vtiger_RecordPopover_Model
{
/** {@inheritdoc} */
public function getFieldsIcon(): array
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFieldsIcon(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return ['date_start' => 'far fa-clock', 'time_start' => 'far fa-clock', 'time_end' => 'far fa-clock', 'due_date' => 'far fa-clock', 'sum_time' => 'far fa-clock',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'assigned_user_id' => 'fas fa-user'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'reservations_no' => 'fas fa-bars', 'linkextend' => '', 'link' => '', 'process' => '', 'subprocess' => '', 'reservations_status' => 'far fa-star',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Line exceeds 120 characters; contains 169 characters Open
Open
return ['date_start' => 'far fa-clock', 'time_start' => 'far fa-clock', 'time_end' => 'far fa-clock', 'due_date' => 'far fa-clock', 'sum_time' => 'far fa-clock',- Exclude checks
Line exceeds 120 characters; contains 158 characters Open
Open
'reservations_no' => 'fas fa-bars', 'linkextend' => '', 'link' => '', 'process' => '', 'subprocess' => '', 'reservations_status' => 'far fa-star',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Class name "Reservations_RecordPopover_Model" is not in camel caps format Open
Open
class Reservations_RecordPopover_Model extends Vtiger_RecordPopover_Model- Exclude checks