Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method getEstimatedValue has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getEstimatedValue($owner = false)
    {
        $moduleName = 'SSalesProcesses';
        $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
        $query = (new \App\Db\Query())->select([
Severity: Minor
Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php - About 1 hr to fix

    The class SSalesProcesses_EstimatedValueByStatus_Dashboard has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class SSalesProcesses_EstimatedValueByStatus_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Function to get search params in address listview.
     *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '46', column '17').
    Open

            $query = (new \App\Db\Query())->select([
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '47', column '23').
    Open

                'estimated' => new \yii\db\Expression('SUM(u_#__ssalesprocesses.estimated)'),
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method getEstimatedValue has a boolean flag argument $owner, which is a certain sign of a Single Responsibility Principle violation.
    Open

        private function getEstimatedValue($owner = false)
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid using static access to class 'Users_Record_Model' in method 'process'.
    Open

            $currentUser = Users_Record_Model::getCurrentUserModel();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'.
    Open

                $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $owner = $request->getByType('owner', 2);
        }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\App\Fields\Picklist' in method 'getEstimatedValue'.
    Open

            $colors = \App\Fields\Picklist::getColors('ssalesprocesses_status');
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $viewer->view('dashboards/EstimatedValueByStatus.tpl', $moduleName);
        }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Vtiger_Module_Model' in method 'getEstimatedValue'.
    Open

            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'getEstimatedValue'.
    Open

                $chartData['labels'][] = \App\Language::translate($row['ssalesprocesses_status'], $moduleName) . ' - ' . CurrencyField::convertToUserFormat($row['estimated']) . ' ' . $currencyInfo['currency_symbol'];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Widget_Model' in method 'process'.
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'CurrencyField' in method 'getEstimatedValue'.
    Open

                $chartData['labels'][] = \App\Language::translate($row['ssalesprocesses_status'], $moduleName) . ' - ' . CurrencyField::convertToUserFormat($row['estimated']) . ' ' . $currencyInfo['currency_symbol'];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Currency' in method 'getEstimatedValue'.
    Open

            $currencyInfo = \App\Fields\Currency::getDefault();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\PrivilegeQuery' in method 'getEstimatedValue'.
    Open

            \App\PrivilegeQuery::getConditions($query, $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "datasets" 5 times.
    Open

                'datasets' => [
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "ssalesprocesses_status" 4 times.
    Open

                $conditions[] = ['ssalesprocesses_status', 'e', $status];
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "estimated" 3 times.
    Open

                'estimated' => new \yii\db\Expression('SUM(u_#__ssalesprocesses.estimated)'),
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "u_#__ssalesprocesses.ssalesprocesses_status" 4 times.
    Open

                'u_#__ssalesprocesses.ssalesprocesses_status',
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Saw unextractable annotation for comment '* @return <array>'</array>
    Open

         * @return <Array>
    Severity: Info
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to method getInstance from undeclared class \Vtiger_Widget_Model
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleGroupForModule());
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to method __construct from undeclared class \yii\db\Expression
    Open

                'estimated' => new \yii\db\Expression('SUM(u_#__ssalesprocesses.estimated)'),
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to deprecated function \CurrencyField::convertToUserFormat() defined at /code/include/fields/CurrencyField.php:144
    Open

                $chartData['labels'][] = \App\Language::translate($row['ssalesprocesses_status'], $moduleName) . ' - ' . CurrencyField::convertToUserFormat($row['estimated']) . ' ' . $currencyInfo['currency_symbol'];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Default value for int $owner can't be false
    Open

        private function getEstimatedValue($owner = false)
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

            $query = (new \App\Db\Query())->select([
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to method getInstance from undeclared class \App\Fields\Owner
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleUsersForModule());
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('DATA', $data);
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to undeclared method \Vtiger_Viewer::assign
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleUsersForModule());
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Call to method getInstance from undeclared class \App\Fields\Owner
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleGroupForModule());
    Severity: Critical
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phan

    Avoid excessively long class names like SSalesProcesses_EstimatedValueByStatus_Dashboard. Keep class name length under 40.
    Open

    class SSalesProcesses_EstimatedValueByStatus_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Function to get search params in address listview.
     *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class SSalesProcesses_EstimatedValueByStatus_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    The class SSalesProcesses_EstimatedValueByStatus_Dashboard is not named in CamelCase.
    Open

    class SSalesProcesses_EstimatedValueByStatus_Dashboard extends Vtiger_IndexAjax_View
{
    /**
     * Function to get search params in address listview.
     *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = 'SSalesProcesses';
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'data' => [],
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 212 characters
    Open

                $chartData['labels'][] = \App\Language::translate($row['ssalesprocesses_status'], $moduleName) . ' - ' . CurrencyField::convertToUserFormat($row['estimated']) . ' ' . $currencyInfo['currency_symbol'];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $chartData;
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->innerJoin('vtiger_ssalesprocesses_status', 'u_#__ssalesprocesses.ssalesprocesses_status = vtiger_ssalesprocesses_status.ssalesprocesses_status')
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->where(['and', ['<>', 'u_#__ssalesprocesses.ssalesprocesses_status', ''], ['vtiger_crmentity.deleted' => 0], ['not', ['u_#__ssalesprocesses.ssalesprocesses_status' => null]]])
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'show_chart' => false,
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $chartData['show_chart'] = (bool) \count($chartData['datasets'][0]['data']);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return <Array>
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($owner)) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ('all' == $owner) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to get search params in address listview.
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return '&viewname=All&search_params=' . json_encode($listSearchParams);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private function getEstimatedValue($owner = false)
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->innerJoin('vtiger_crmentity', 'u_#__ssalesprocesses.ssalesprocessesid = vtiger_crmentity.crmid')
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            \App\PrivilegeQuery::getConditions($query, $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'labels' => [],
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 147 characters
    Open

                $chartData['datasets'][0]['links'][] = $moduleModel->getListViewUrl() . $this->getSearchParams($owner, $row['ssalesprocesses_status']);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['labels'][] = \App\Language::translate($row['ssalesprocesses_status'], $moduleName) . ' - ' . CurrencyField::convertToUserFormat($row['estimated']) . ' ' . $currencyInfo['currency_symbol'];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleGroupForModule());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param int    $owner  number id of user
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param int $owner
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 188 characters
    Open

                ->where(['and', ['<>', 'u_#__ssalesprocesses.ssalesprocesses_status', ''], ['vtiger_crmentity.deleted' => 0], ['not', ['u_#__ssalesprocesses.ssalesprocesses_status' => null]]])
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $colors = \App\Fields\Picklist::getColors('ssalesprocesses_status');
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['data'][] = round($row['estimated'], 2);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request $request
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to get data to chart.
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->orderBy(['vtiger_ssalesprocesses_status.sortorderid' => SORT_DESC]);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query->andWhere(['vtiger_crmentity.smownerid' => $owner]);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'links' => [], // links generated in proccess method
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ],
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dataReader->close();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($owner)) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param string $status
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $conditions = [];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $listSearchParams[] = $conditions;
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $query->groupBy(['u_#__ssalesprocesses.ssalesprocesses_status', 'vtiger_ssalesprocesses_status.ssalesprocesses_statusid']);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 131 characters
    Open

            $query->groupBy(['u_#__ssalesprocesses.ssalesprocesses_status', 'vtiger_ssalesprocesses_status.ssalesprocesses_statusid']);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dataReader = $query->createCommand()->query();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getSearchParams($owner, $status)
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'u_#__ssalesprocesses.ssalesprocesses_status',
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            while ($row = $dataReader->read()) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['backgroundColor'][] = $colors[$row['ssalesprocesses_statusid']];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!$request->has('owner')) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('WIDGET', $widget);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 143 characters
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleUsersForModule());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ],
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $data = $this->getEstimatedValue($owner);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('MODULE_NAME', $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 144 characters
    Open

            $viewer->assign('ACCESSIBLE_GROUPS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleGroupForModule());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    [
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $owner = $request->getByType('owner', 2);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $owner = '';
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $listSearchParams = [];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $currencyInfo = \App\Fields\Currency::getDefault();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'names' => [], // names for link generation
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $request->getModule();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $linkId = $request->getInteger('linkid');
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/DashBoardWidgetContents.tpl', $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($status)) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $conditions[] = ['ssalesprocesses_status', 'e', $status];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('DATA', $data);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'estimated' => new \yii\db\Expression('SUM(u_#__ssalesprocesses.estimated)'),
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $chartData = [
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $chartData['datasets'][0]['links'][] = $moduleModel->getListViewUrl() . $this->getSearchParams($owner, $row['ssalesprocesses_status']);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $currentUser = Users_Record_Model::getCurrentUserModel();
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer = $this->getViewer($request);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $viewer->assign('ACCESSIBLE_USERS', \App\Fields\Owner::getInstance($moduleName, $currentUser->getId())->getAccessibleUsersForModule());
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($request->has('content')) {
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $viewer->view('dashboards/EstimatedValueByStatus.tpl', $moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'vtiger_ssalesprocesses_status.ssalesprocesses_statusid',
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ])
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->from('u_yf_ssalesprocesses')
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Line exceeds 120 characters; contains 158 characters
    Open

                ->innerJoin('vtiger_ssalesprocesses_status', 'u_#__ssalesprocesses.ssalesprocesses_status = vtiger_ssalesprocesses_status.ssalesprocesses_status')
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Main function.
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $conditions[] = ['assigned_user_id', 'e', $owner];
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleModel = Vtiger_Module_Model::getInstance($moduleName);
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $query = (new \App\Db\Query())->select([
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'datasets' => [
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'backgroundColor' => [],
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    Class name "SSalesProcesses_EstimatedValueByStatus_Dashboard" is not in camel caps format
    Open

    class SSalesProcesses_EstimatedValueByStatus_Dashboard extends Vtiger_IndexAjax_View
    Severity: Minor
    Found in modules/SSalesProcesses/dashboards/EstimatedValueByStatus.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status