Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/SSalesProcesses/models/DetailView.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Consider simplifying this complex logical expression.
Open

            if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['OSSOutsourcedServices']) || isset($relations['Assets']) || isset($relations['OSSSoldServices']) || isset($relations['OutsourcedProducts'])) {
                $relatedLinks[] = [
                    'linktype' => 'DETAILVIEWTAB',
                    'linklabel' => 'LBL_RECORD_SUMMARY_PRODUCTS_SERVICES',
                    'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
Severity: Major
Found in modules/SSalesProcesses/models/DetailView.php - About 40 mins to fix

    Avoid using static access to class '\Vtiger_Relation_Model' in method 'getDetailViewRelatedLinks'.
    Open

                $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Config' in method 'getDetailViewRelatedLinks'.
    Open

            if (App\Config::module($recordModel->getModuleName(), 'SHOW_SUMMARY_PRODUCTS_SERVICES')) {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Config' in method 'getDetailViewRelatedLinks'.
    Open

                        'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Reference to undeclared class \Vtiger_DetailView_Model
    Open

            $relatedLinks = parent::getDetailViewRelatedLinks();
    Severity: Critical
    Found in modules/SSalesProcesses/models/DetailView.php by phan

    Class extends undeclared class \Vtiger_DetailView_Model
    Open

    class SSalesProcesses_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Critical
    Found in modules/SSalesProcesses/models/DetailView.php by phan

    Call to undeclared method \SSalesProcesses_DetailView_Model::getRecord
    Open

            $recordModel = $this->getRecord();
    Severity: Critical
    Found in modules/SSalesProcesses/models/DetailView.php by phan

    Call to undeclared method \SSalesProcesses_DetailView_Model::getModule
    Open

                $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
    Severity: Critical
    Found in modules/SSalesProcesses/models/DetailView.php by phan

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['OSSOutsourcedServices']) || isset($relations['Assets']) || isset($relations['OSSSoldServices']) || isset($relations['OutsourcedProducts'])) {
                $relatedLinks[] = [
                    'linktype' => 'DETAILVIEWTAB',
                    'linklabel' => 'LBL_RECORD_SUMMARY_PRODUCTS_SERVICES',
                    'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
    Severity: Major
    Found in modules/SSalesProcesses/models/DetailView.php and 1 other location - About 1 hr to fix
    modules/Accounts/models/DetailView.php on lines 70..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class SSalesProcesses_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    The class SSalesProcesses_DetailView_Model is not named in CamelCase.
    Open

    class SSalesProcesses_DetailView_Model extends Vtiger_DetailView_Model
{
    /** {@inheritdoc} */
    public function getDetailViewRelatedLinks()
    {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $relatedLinks = parent::getDetailViewRelatedLinks();
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $relatedLinks[] = [
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ];
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'related' => 'ProductsAndServices',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getDetailViewRelatedLinks()
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel = $this->getRecord();
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Line exceeds 120 characters; contains 241 characters
    Open

                if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['OSSOutsourcedServices']) || isset($relations['Assets']) || isset($relations['OSSSoldServices']) || isset($relations['OutsourcedProducts'])) {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linktype' => 'DETAILVIEWTAB',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

                        'linkurl' => $recordModel->getDetailViewUrl() . '&mode=showRelatedProductsServices&requestMode=summary',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkKey' => 'LBL_RECORD_SUMMARY',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $relations = \Vtiger_Relation_Model::getAllRelations($this->getModule(), false, true, true, 'modulename');
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (isset($relations['Products']) || isset($relations['Services']) || isset($relations['OSSOutsourcedServices']) || isset($relations['Assets']) || isset($relations['OSSSoldServices']) || isset($relations['OutsourcedProducts'])) {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'countRelated' => App\Config::relation('SHOW_RECORDS_COUNT'),
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (App\Config::module($recordModel->getModuleName(), 'SHOW_SUMMARY_PRODUCTS_SERVICES')) {
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linklabel' => 'LBL_RECORD_SUMMARY_PRODUCTS_SERVICES',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $relatedLinks;
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        'linkicon' => '',
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    Class name "SSalesProcesses_DetailView_Model" is not in camel caps format
    Open

    class SSalesProcesses_DetailView_Model extends Vtiger_DetailView_Model
    Severity: Minor
    Found in modules/SSalesProcesses/models/DetailView.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status