Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/ServiceContracts/relations/GetDependentsList.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Call to undeclared method \CRMEntity::updateHelpDeskRelatedTo
Open

            $entityInstance->updateHelpDeskRelatedTo($sourceRecordId, $destinationRecordId);
Severity: Critical
Found in modules/ServiceContracts/relations/GetDependentsList.php by phan

Call to undeclared method \CRMEntity::updateServiceContractState
Open

            $entityInstance->updateServiceContractState($sourceRecordId);
Severity: Critical
Found in modules/ServiceContracts/relations/GetDependentsList.php by phan

Avoid excessively long class names like ServiceContracts_GetDependentsList_Relation. Keep class name length under 40.
Open

class ServiceContracts_GetDependentsList_Relation extends Vtiger_GetDependentsList_Relation
{
    /** {@inheritdoc} */
    public function create(int $sourceRecordId, int $destinationRecordId): bool
    {
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class ServiceContracts_GetDependentsList_Relation extends Vtiger_GetDependentsList_Relation
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

The class ServiceContracts_GetDependentsList_Relation is not named in CamelCase.
Open

class ServiceContracts_GetDependentsList_Relation extends Vtiger_GetDependentsList_Relation
{
    /** {@inheritdoc} */
    public function create(int $sourceRecordId, int $destinationRecordId): bool
    {
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $entityInstance = $this->relationModel->getParentModuleModel()->getEntityInstance();
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $entityInstance->updateHelpDeskRelatedTo($sourceRecordId, $destinationRecordId);
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return true;
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function create(int $sourceRecordId, int $destinationRecordId): bool
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if ('HelpDesk' === $this->relationModel->getRelationModuleName()) {
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $entityInstance->updateServiceContractState($sourceRecordId);
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

Class name "ServiceContracts_GetDependentsList_Relation" is not in camel caps format
Open

class ServiceContracts_GetDependentsList_Relation extends Vtiger_GetDependentsList_Relation
Severity: Minor
Found in modules/ServiceContracts/relations/GetDependentsList.php by phpcodesniffer

There are no issues that match your filters.

Category
Status