Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Services/models/Module.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '28', column '22').
Open

                $subQuery = (new App\Db\Query())
Severity: Minor
Found in modules/Services/models/Module.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$field'.
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Services/models/Module.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
Open

            $queryGenerator->addNativeCondition($condition);
Severity: Critical
Found in modules/Services/models/Module.php by phan

Call to undeclared method \App\Db\Query::select
Open

                $subQuery = (new App\Db\Query())
Severity: Critical
Found in modules/Services/models/Module.php by phan

Parameter $queryGenerator has undeclared type \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Services/models/Module.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Services_Module_Model extends Products_Module_Model
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

The class Services_Module_Model is not named in CamelCase.
Open

class Services_Module_Model extends Products_Module_Model
{
    /**
     * Function to get list view query for popup window.
     *
Severity: Minor
Found in modules/Services/models/Module.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     * Function to get list view query for popup window.
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $supportedModulesList = ['Leads', 'Accounts', 'HelpDesk', 'PriceBooks'];
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    ->from('vtiger_pricebookproductrel')
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    ->where(['pricebookid' => $record]);
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            }
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            if ('PriceBooks' == $sourceModule) {
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $subQuery = (new App\Db\Query())
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getQueryByModuleField($sourceModule, $field, $record, App\QueryGenerator $queryGenerator)
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    ->select(['productid'])
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $record         parent id
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\QueryGenerator $queryGenerator
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

        if (\in_array($sourceModule, $supportedModulesList) || Vtiger_Module_Model::getInstance($sourceModule)->isInventory()) {
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $queryGenerator->addNativeCondition($condition);
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (\in_array($sourceModule, $supportedModulesList) || Vtiger_Module_Model::getInstance($sourceModule)->isInventory()) {
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $condition = ['and', ['vtiger_service.discontinued' => 1]];
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                $condition[] = ['not in', 'vtiger_service.serviceid', $subQuery];
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $sourceModule   Parent module
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string              $field          parent fieldname
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

Class name "Services_Module_Model" is not in camel caps format
Open

class Services_Module_Model extends Products_Module_Model
Severity: Minor
Found in modules/Services/models/Module.php by phpcodesniffer

There are no issues that match your filters.

Category
Status