Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Services/views/Detail.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Call to undeclared method \Services_Detail_View::checkAndConvertJsScripts
Open

        return array_merge($headerScriptInstances, $this->checkAndConvertJsScripts([
Severity: Critical
Found in modules/Services/views/Detail.php by phan

Avoid excessively long variable names like $headerScriptInstances. Keep variable name length under 20.
Open

        $headerScriptInstances = parent::getFooterScripts($request);
Severity: Minor
Found in modules/Services/views/Detail.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $moduleRelatedListFile. Keep variable name length under 20.
Open

        $moduleRelatedListFile = 'modules.' . $moduleName . '.resources.RelatedList';
Severity: Minor
Found in modules/Services/views/Detail.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Services_Detail_View extends Products_Detail_View
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

The class Services_Detail_View is not named in CamelCase.
Open

class Services_Detail_View extends Products_Detail_View
{
    /**
     * * {@inheritdoc}
     */
Severity: Minor
Found in modules/Services/views/Detail.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getFooterScripts(App\Request $request)
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $modulePopUpFile = 'modules.' . $moduleName . '.resources.Edit';
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $headerScriptInstances = parent::getFooterScripts($request);
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            'modules.Products.resources.RelatedList',
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleRelatedListFile = 'modules.' . $moduleName . '.resources.RelatedList';
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $moduleRelatedListFile
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * * {@inheritdoc}
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return array_merge($headerScriptInstances, $this->checkAndConvertJsScripts([
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        ]));
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            'modules.Products.resources.Edit',
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $moduleName = $request->getModule();
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $modulePopUpFile,
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        unset($headerScriptInstances[$modulePopUpFile], $headerScriptInstances[$moduleRelatedListFile]);
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

Class name "Services_Detail_View" is not in camel caps format
Open

class Services_Detail_View extends Products_Detail_View
Severity: Minor
Found in modules/Services/views/Detail.php by phpcodesniffer

There are no issues that match your filters.

Category
Status