modules/Settings/AdminAccess/views/Edit.php
Avoid using static access to class 'Settings_AdminAccess_Record_Model' in method 'process'. Open
Open
$recordModel = Settings_AdminAccess_Record_Model::getInstance($recordId);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \Settings_AdminAccess_Edit_View::getViewer Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Call to undeclared method \Settings_Vtiger_Module_Model::getEditFields (Did you mean expr->getListFields()) Open
Open
foreach ($recordModel->getModule()->getEditFields() as $fieldModel) {- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_AdminAccess_Edit_View extends \App\Controller\ModalSettings- Exclude checks
The class Settings_AdminAccess_Edit_View is not named in CamelCase. Open
Open
class Settings_AdminAccess_Edit_View extends \App\Controller\ModalSettings
{
/** {@inheritdoc} */
protected $pageTitle = 'LBL_EDIT_ADMIN_ACCESS';
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
* The function returns module fields.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->view('Edit.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($recordModel->getModule()->getEditFields() as $fieldModel) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel->uitype = 33;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($recordModel->getId()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RECORD_STRUCTURES', $this->getStructure($recordModel));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param Settings_AdminAccess_Record_Model $recordModel- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getStructure(Settings_AdminAccess_Record_Model $recordModel): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (16 === $fieldModel->getUiType()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $pageTitle = 'LBL_EDIT_ADMIN_ACCESS';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $request->getModule(false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordId = $request->getInteger('id', 0);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Line exceeds 120 characters; contains 133 characters Open
Open
$fieldModel->set('fieldvalue', $fieldModel->getUITypeModel()->getDBValue($recordModel->get($fieldModel->getName())));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordModel = Settings_AdminAccess_Record_Model::getInstance($recordId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$viewer->assign('RECORD_MODEL', $recordModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel->set('isEditableReadOnly', 'name' === $fieldModel->getName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $structures;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel->set('fieldvalue', $fieldModel->getUITypeModel()->getDBValue($recordModel->get($fieldModel->getName())));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $modalIcon = 'yfi yfi-full-editing-view';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$structures = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$structures[$fieldModel->getName()] = $fieldModel;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Class name "Settings_AdminAccess_Edit_View" is not in camel caps format Open
Open
class Settings_AdminAccess_Edit_View extends \App\Controller\ModalSettings- Exclude checks