Avoid using static access to class 'Settings_AdvancedPermission_Record_Model' in method 'process'. Open
$recordModel = Settings_AdvancedPermission_Record_Model::getInstance($record);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('RECORD_MODEL', $recordModel);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function process(App\Request $request)
{
$record = $request->getInteger('record');
$qualifiedModuleName = $request->getModule(false);
$recordModel = Settings_AdvancedPermission_Record_Model::getInstance($record);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 103.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Settings_AdvancedPermission_Detail_View extends Settings_Vtiger_Index_View- Exclude checks
The class Settings_AdvancedPermission_Detail_View is not named in CamelCase. Open
class Settings_AdvancedPermission_Detail_View extends Settings_Vtiger_Index_View
{
public function process(App\Request $request)
{
$record = $request->getInteger('record');- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('DetailView.tpl', $qualifiedModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$recordModel = Settings_AdvancedPermission_Record_Model::getInstance($record);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('RECORD_MODEL', $recordModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$record = $request->getInteger('record');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('QUALIFIED_MODULE', $qualifiedModuleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$qualifiedModuleName = $request->getModule(false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer = $this->getViewer($request);- Exclude checks
Class name "Settings_AdvancedPermission_Detail_View" is not in camel caps format Open
class Settings_AdvancedPermission_Detail_View extends Settings_Vtiger_Index_View- Exclude checks