Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/CronTasks/models/Module.php

Summary

Maintainability
B
5 hrs
Test Coverage
B
80%

Method getLastCronIteration has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getLastCronIteration()
    {
        $result = [];
        $totalDiff = $finalLastStart = $finalLastEnd = $finishedTasks = 0;
        $timedout = false;
Severity: Minor
Found in modules/Settings/CronTasks/models/Module.php - About 1 hr to fix

    Function getLastCronIteration has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getLastCronIteration()
    {
        $result = [];
        $totalDiff = $finalLastStart = $finalLastEnd = $finishedTasks = 0;
        $timedout = false;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '115', column '18').
    Open

                $record = new Settings_CronTasks_Record_Model($task);
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '57', column '71').
    Open

            $db->createCommand()->update('vtiger_cron_task', ['sequence' => new yii\db\Expression($caseSequence)])->execute();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '101', column '17').
    Open

            $tasks = (new \App\Db\Query())
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\Fields\DateTime' in method 'getLastCronIteration'.
    Open

            $result['laststart'] = empty($lastStart) ? ' - ' : \App\Fields\DateTime::formatToViewDate(date('Y-m-d H:i:s', $lastStart));
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'App\Db' in method 'updateSequence'.
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\RangeTime' in method 'getLastCronIteration'.
    Open

                $result['duration'] = \App\Fields\RangeTime::displayElapseTime($totalDiff, 's');
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getLastCronIteration uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $result['duration'] = \App\Fields\RangeTime::displayElapseTime($totalDiff, 's');
        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Define a constant instead of duplicating this literal "vtiger_cron_task" 3 times.
    Open

        public $baseTable = 'vtiger_cron_task';
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "status" 3 times.
    Open

            'status' => 'Status',
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "duration" 3 times.
    Open

            'duration' => 'LBL_DURATION',
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "laststart" 4 times.
    Open

            'laststart' => 'Last Start',
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to undeclared method \App\Db::quoteColumnName
    Open

                $caseSequence .= ' WHEN ' . $db->quoteColumnName('id') . ' = ' . $db->quoteValue($recordId) . ' THEN ' . $db->quoteValue($sequence);
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

            $tasks = (new \App\Db\Query())
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

            $db->createCommand()->update('vtiger_cron_task', ['sequence' => new yii\db\Expression($caseSequence)])->execute();
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by phan

    Call to undeclared method \App\Db::quoteValue
    Open

                $caseSequence .= ' WHEN ' . $db->quoteColumnName('id') . ' = ' . $db->quoteValue($recordId) . ' THEN ' . $db->quoteValue($sequence);
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by phan

    Call to method __construct from undeclared class \yii\db\Expression
    Open

            $db->createCommand()->update('vtiger_cron_task', ['sequence' => new yii\db\Expression($caseSequence)])->execute();
    Severity: Critical
    Found in modules/Settings/CronTasks/models/Module.php by phan

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function updateSequence($sequencesList)
    {
        $db = App\Db::getInstance();
        $caseSequence = 'CASE';
        foreach ($sequencesList as $sequence => $recordId) {
    Severity: Major
    Found in modules/Settings/CronTasks/models/Module.php and 1 other location - About 1 hr to fix
    modules/Settings/Countries/models/Module.php on lines 15..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_CronTasks_Module_Model extends Settings_Vtiger_Module_Model
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    The class Settings_CronTasks_Module_Model is not named in CamelCase.
    Open

    class Settings_CronTasks_Module_Model extends Settings_Vtiger_Module_Model
{
    public $baseTable = 'vtiger_cron_task';
    public $baseIndex = 'id';
    public $listFields = [
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'last_update' => 'Last update',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private $lastCronStart = 0;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getLastCronStart()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ],
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $finalLastStart = $lastStart;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array List of fieldNames
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($sequencesList as $sequence => $recordId) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    return $this->lastCronStart = (int) $cronConfig['last_start'];
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $timedout = false;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $cronConfig = include $cronConfigFileName;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $result = [];
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ])
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $finalLastEnd = $lastEnd;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $nameFields = [''];
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function hasCreatePermissions()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($this->lastCronStart) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->from('vtiger_cron_task')
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($tasks as $task) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $name = 'CronTasks';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Line exceeds 120 characters; contains 144 characters
    Open

                $caseSequence .= ' WHEN ' . $db->quoteColumnName('id') . ' = ' . $db->quoteValue($recordId) . ' THEN ' . $db->quoteValue($sequence);
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return int timestamp
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($cronConfig && isset($cronConfig['last_start'])) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->query()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @var int
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->where(['>=', 'laststart', $lastStart])
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $lastStart = (int) $record->get('laststart');
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($lastEnd > $finalLastEnd) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Get last executed Cron info formated by user settings.
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!$record->isRunning() && !$record->hadTimedout()) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'sequence' => 'Sequence',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to get editable fields from this module.
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $totalDiff = $finalLastStart = $finalLastEnd = $finishedTasks = 0;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    Settings_CronTasks_Record_Model::$STATUS_COMPLETED,
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $record = new Settings_CronTasks_Record_Model($task);
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $lastEnd = (int) $record->get('lastend');
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($lastStart > $finalLastStart) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'laststart' => 'Last Start',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        ];
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $lastStart = $this->getLastCronStart();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ++$finishedTasks;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $result['laststart'] = empty($lastStart) ? ' - ' : \App\Fields\DateTime::formatToViewDate(date('Y-m-d H:i:s', $lastStart));
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $result['tasks'] = \count($tasks);
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $result['finished_tasks'] = $finishedTasks;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'frequency' => 'Frequency(H:M)',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'status' => 'Status',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Save last cron time start between views (timestamp).
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getEditableFieldsList()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $caseSequence = 'CASE';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getLastCronIteration()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $result;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Line exceeds 120 characters; contains 131 characters
    Open

            $result['laststart'] = empty($lastStart) ? ' - ' : \App\Fields\DateTime::formatToViewDate(date('Y-m-d H:i:s', $lastStart));
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'name' => 'Cron Job',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($timedout) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return ['frequency', 'status'];
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Function to update sequence of several records.
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $caseSequence .= ' WHEN ' . $db->quoteColumnName('id') . ' = ' . $db->quoteValue($recordId) . ' THEN ' . $db->quoteValue($sequence);
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $caseSequence .= ' END';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return false;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Returns last iteration start time.
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->readAll();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $db->createCommand()->update('vtiger_cron_task', ['sequence' => new yii\db\Expression($caseSequence)])->execute();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return $this->lastCronStart;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $cronConfigFileName = ROOT_DIRECTORY . '/app_data/cron.php';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (file_exists($cronConfigFileName)) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $totalDiff += (int) $record->getTimeDiff();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                } elseif ($record->hadTimedout()) {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $timedout = $record;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $result['duration'] = $timedout->getDuration();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $result['duration'] = \App\Fields\RangeTime::displayElapseTime($totalDiff, 's');
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'lastend' => 'Last End',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function updateSequence($sequencesList)
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

            $db->createCommand()->update('vtiger_cron_task', ['sequence' => new yii\db\Expression($caseSequence)])->execute();
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function isPagingSupported()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return 0;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $tasks = (new \App\Db\Query())
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $listFields = [
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return false;
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    Settings_CronTasks_Record_Model::$STATUS_ENABLED,
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    Settings_CronTasks_Record_Model::$STATUS_RUNNING,
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $baseTable = 'vtiger_cron_task';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $baseIndex = 'id';
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'duration' => 'LBL_DURATION',
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param array $sequencesList
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array ['duration'=>'0g 0m 0s','laststart'=>'3 hours ago','tasks'=>2, 'finished_tasks'=>1]
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->where(['status', [
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ->createCommand()
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    Class name "Settings_CronTasks_Module_Model" is not in camel caps format
    Open

    class Settings_CronTasks_Module_Model extends Settings_Vtiger_Module_Model
    Severity: Minor
    Found in modules/Settings/CronTasks/models/Module.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status