YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/Currency/actions/SaveAjax.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method save has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save(App\Request $request)
    {
        if ($request->isEmpty('record')) {
            //get instance from currency name, Aleady deleted and adding again same currency case
            $recordModel = Settings_Currency_Record_Model::getInstance($request->getByType('currency_name', 'Text'));
Severity: Minor
Found in modules/Settings/Currency/actions/SaveAjax.php - About 1 hr to fix

    Function save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function save(App\Request $request)
        {
            if ($request->isEmpty('record')) {
                //get instance from currency name, Aleady deleted and adding again same currency case
                $recordModel = Settings_Currency_Record_Model::getInstance($request->getByType('currency_name', 'Text'));
    Severity: Minor
    Found in modules/Settings/Currency/actions/SaveAjax.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '52', column '24').
    Open

                    $recordModel = new Settings_Currency_Record_Model();

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '34', column '19').
    Open

            $response = new Vtiger_Response();

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '64', column '19').
    Open

            $response = new Vtiger_Response();

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '69', column '16').
    Open

                        throw new \App\Exceptions\AppException('Transfer currency id cannot be empty');

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Settings_Currency_Record_Model' in method 'save'.
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_Currency_Record_Model' in method 'save'.
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($id);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_Currency_Record_Model' in method 'setDefault'.
    Open

            $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));
            }

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Settings_Currency_Record_Model' in method 'save'.
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($request->getByType('currency_name', 'Text'));

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "currency_name" 3 times.
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($request->getByType('currency_name', 'Text'));

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "currency_status" 3 times.
    Open

            $recordModel->set('currency_status', $request->getByType('currency_status'));

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "record" 5 times.
    Open

            $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call with 0 arg(s) to \Settings_Currency_SaveAjax_Action::save() which requires 1 arg(s) defined at /code/modules/Settings/Currency/actions/SaveAjax.php:46
    Open

            $recordModel->save();

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_Currency_SaveAjax_Action extends Settings_Vtiger_Basic_Action

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

                $id = $recordModel->save();

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class Settings_Currency_SaveAjax_Action is not named in CamelCase.
    Open

    class Settings_Currency_SaveAjax_Action extends Settings_Vtiger_Basic_Action
    {
        use \App\Controller\ExposeMethod;
    
        /** {@inheritdoc} */

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function __construct()

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response->emit();

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $response->setError($e->getCode(), $e->getMessage());

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } else {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            //To make sure we are saving record as non deleted. This is useful if we are adding deleted currency

    Spaces must be used to indent lines; tabs are not allowed
    Open

        use \App\Controller\ExposeMethod;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ('Inactive' === $request->getByType('currency_status') && !$request->isEmpty('record')) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($request->getByType('currency_name', 'Text'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (empty($recordModel)) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $id = $recordModel->save();

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request $request

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->save();

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @throws Exception

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('currency_name', $request->getByType('currency_name', 'Text'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response->emit();

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->exposeMethod('setDefault');

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *

    Spaces must be used to indent lines; tabs are not allowed
    Open

                //get instance from currency name, Aleady deleted and adding again same currency case

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $recordModel = new Settings_Currency_Record_Model();

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('currency_code', $request->getByType('currency_code'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        throw new \App\Exceptions\AppException('Transfer currency id cannot be empty');

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Save currency.

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (empty($transforCurrencyToId)) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $recordModel = Settings_Currency_Record_Model::getInstance($id);

    Spaces must be used to indent lines; tabs are not allowed
    Open

            parent::__construct();

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('defaultid', -11);

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('currency_symbol', $request->getByType('currency_symbol', 'Text'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

            try {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } catch (Exception $e) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $this->exposeMethod('save');

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Set default currency.

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param \App\Request $request

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function setDefault(App\Request $request)

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('currency_status', $request->getByType('currency_status'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response = new Vtiger_Response();

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response->setResult(true);

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function save(App\Request $request)

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $response = new Vtiger_Response();

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $response->setResult(array_merge($recordModel->getData(), ['record' => $recordModel->getId()]));

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel = Settings_Currency_Record_Model::getInstance($request->getInteger('record'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('deleted', 0);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $transforCurrencyToId = $request->getInteger('transform_to_id');

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($request->isEmpty('record')) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $recordModel->set('conversion_rate', $request->getByType('conversion_rate', 'NumberInUserFormat'));

    Class name "Settings_Currency_SaveAjax_Action" is not in camel caps format
    Open

    class Settings_Currency_SaveAjax_Action extends Settings_Vtiger_Basic_Action

    There are no issues that match your filters.

    Category
    Status