Method getCRMConversionRate has 72 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getCRMConversionRate($from, $to, $date = '')
    {
        $mainCurrencyCode = \App\Fields\Currency::getDefault()['currency_code'];
        $activeBankId = self::getActiveBankId();
        $exchange = false;

Function getCRMConversionRate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.

Open

    public function getCRMConversionRate($from, $to, $date = '')
    {
        $mainCurrencyCode = \App\Fields\Currency::getDefault()['currency_code'];
        $activeBankId = self::getActiveBankId();
        $exchange = false;

• Read up
  Read up

File Module.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 * @copyright YetiForce S.A.
 * @license   YetiForce Public License 6.5 (licenses/LicenseEN.txt or yetiforce.com)

Function refreshBanks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    public function refreshBanks()
    {
        $db = App\Db::getInstance();
        $dataReader = (new \App\Db\Query())->select(['id', 'bank_name'])
            ->from('yetiforce_currencyupdate_banks')

• Read up
  Read up

Method fetchCurrencyRates has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function fetchCurrencyRates($dateCur, $cron = false)
    {
        if (!\App\RequestUtil::isNetConnection()) {
            return false;
        }

Function fetchCurrencyRates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function fetchCurrencyRates($dateCur, $cron = false)
    {
        if (!\App\RequestUtil::isNetConnection()) {
            return false;
        }

• Read up
  Read up

The method getCRMConversionRate() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.

Open

    public function getCRMConversionRate($from, $to, $date = '')
    {
        $mainCurrencyCode = \App\Fields\Currency::getDefault()['currency_code'];
        $activeBankId = self::getActiveBankId();
        $exchange = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.

Open

    public function getCRMConversionRate($from, $to, $date = '')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using undefined variables such as '$unsupported' which will lead to PHP notices.

Open

        return array_diff($unsupported, $supported);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$unsupported' which will lead to PHP notices.

Open

            $unsupported[$name] = $code;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Missing class import via use statement (line '111', column '21').

Open

            $isExists = (new \App\Db\Query())->from('yetiforce_currencyupdate_banks')->where(['bank_name' => $bankClassName])->exists();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '334', column '18').

Open

                $query = new App\Db\Query();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '403', column '15').

Open

        return (new \App\Db\Query())->select(['bank_name'])->from('yetiforce_currencyupdate_banks')->where(['active' => 1])->scalar();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '295', column '18').

Open

                $query = new App\Db\Query();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method fetchCurrencyRates has a boolean flag argument $cron, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function fetchCurrencyRates($dateCur, $cron = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '306', column '18').

Open

                $query = new App\Db\Query();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '319', column '17').

Open

            $query = new App\Db\Query();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '237', column '22').

Open

        $dataReader = (new \App\Db\Query())->select(['currency_name', 'currency_code'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '106', column '16').

Open

        foreach (new DirectoryIterator(ROOT_DIRECTORY . '/modules/Settings/CurrencyUpdate/bankmodels/') as $fileInfo) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '28', column '15').

Open

        return (new \App\Db\Query())

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '60', column '22').

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'currency_code'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '77', column '20').

Open

            $currNum = (new \App\Db\Query())->from('yetiforce_currencyupdate')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '164', column '15').

Open

        return (new \App\Db\Query())->select(['id'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '287', column '17').

Open

            $query = new App\Db\Query();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '95', column '22').

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'bank_name'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '181', column '17').

Open

        $query = (new App\Db\Query())->select(['exchange', 'currency_name', 'currency_code', 'currency_symbol', 'fetch_date', 'exchange_date'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '375', column '15').

Open

        return (new \App\Db\Query())->select(['id'])->from('yetiforce_currencyupdate_banks')->where(['active' => 1])->scalar();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method convertFromTo has a boolean flag argument $date, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function convertFromTo($amount, $from, $to, $date = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getCRMConversionRate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $exchange = $fromExchange * $convertToMainCurrency;
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Fields\Currency' in method 'getCRMConversionRate'.

Open

}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\RequestUtil' in method 'fetchCurrencyRates'.

Open

        if (!\App\RequestUtil::isNetConnection()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getRatesHistory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $query->andWhere(['exchange_date' => $dateCur]);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Fields\Currency' in method 'getCRMConversionRate'.

Open

}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Db' in method 'refreshBanks'.

Open

        $db = App\Db::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\RequestUtil' in method 'getSupportedCurrencies'.

Open

        if (!\App\RequestUtil::isNetConnection()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\RequestUtil' in method 'getUnSupportedCurrencies'.

Open

        if (!\App\RequestUtil::isNetConnection()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getCRMConversionRate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        else {
            if (\App\RequestUtil::isNetConnection()) {
                $query = new App\Db\Query();
                $query->from('yetiforce_currencyupdate')
                    ->innerJoin('vtiger_currency_info', 'vtiger_currency_info.id = yetiforce_currencyupdate.currency_id AND deleted = :del', [':del' => 0])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Db' in method 'setActiveBankById'.

Open

        $db = \App\Db::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'getSupportedCurrencies'.

Open

            \App\Log::error('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Currency' in method 'getCRMConversionRate'.

Open

}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\RequestUtil' in method 'getCRMConversionRate'.

Open

            if (\App\RequestUtil::isNetConnection()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Currency' in method 'getCurrencyNum'.

Open

        return \count(\App\Fields\Currency::getAll(true));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "active" 6 times.

Open

                $db->createCommand()->insert('yetiforce_currencyupdate_banks', ['bank_name' => $bankClassName, 'active' => 0])->execute();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "conversion_rate" 3 times.

Open

            ->update('vtiger_currency_info', ['conversion_rate' => $rate], ['currency_code' => $currency])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "_BankModel" 3 times.

Open

            $activeBankName = 'Settings_CurrencyUpdate_' . $this->getActiveBankName() . '_BankModel';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "vtiger_currency_info.id = yetiforce_currencyupdate.currency_id AND deleted = :del" 3 times.

Open

                    ->innerJoin('vtiger_currency_info', 'vtiger_currency_info.id = yetiforce_currencyupdate.currency_id AND deleted = :del', [':del' => 0])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "currency_name" 4 times.

Open

            ->select(['currency_name'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "currency_code" 13 times.

Open

            ->where(['currency_code' => $code])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "yetiforce_currencyupdate.exchange_date" 3 times.

Open

                    ->where(['yetiforce_currencyupdate.exchange_date' => $date,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "bank_name" 6 times.

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'bank_name'])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "yetiforce_currencyupdate" 8 times.

Open

            $currNum = (new \App\Db\Query())->from('yetiforce_currencyupdate')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Settings_CurrencyUpdate_" 3 times.

Open

            $activeBankName = 'Settings_CurrencyUpdate_' . $this->getActiveBankName() . '_BankModel';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "exchange_date" 7 times.

Open

                ->where(['exchange_date' => $dateCur, 'currency_id' => $currIds, 'bank_id' => $selectBankId])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "yetiforce_currencyupdate.bank_id" 4 times.

Open

            ->where(['yetiforce_currencyupdate.bank_id' => $bankId]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "yetiforce_currencyupdate_banks" 10 times.

Open

            ->from('yetiforce_currencyupdate_banks')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "bank_id" 3 times.

Open

                ->where(['exchange_date' => $dateCur, 'currency_id' => $currIds, 'bank_id' => $selectBankId])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "currency_id" 3 times.

Open

                ->where(['exchange_date' => $dateCur, 'currency_id' => $currIds, 'bank_id' => $selectBankId])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "vtiger_currency_info.currency_code" 3 times.

Open

                        'vtiger_currency_info.currency_code' => $to, ])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "vtiger_currency_info" 9 times.

Open

            ->from('vtiger_currency_info')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "exchange" 3 times.

Open

            ->update('yetiforce_currencyupdate', ['exchange' => $exchange], ['id' => $id])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Avoid unused parameters such as '$cron'.

Open

    public function fetchCurrencyRates($dateCur, $cron = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Call to undeclared method \App\Db\Query::from

Open

            $isExists = (new \App\Db\Query())->from('yetiforce_currencyupdate_banks')->where(['bank_name' => $bankClassName])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

            $db->createCommand()->update('yetiforce_currencyupdate_banks', ['active' => 1], ['bank_name' => 'NBP'])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <array> - array of supported currencies'</array>

Open

     * @return <Array> - array of supported currencies

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <array> - array of unsupported currencies'</array>

Open

     * @return <Array> - array of unsupported currencies

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            $currNum = (new \App\Db\Query())->from('yetiforce_currencyupdate')

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <float> $exchange - exchange rate'</float>

Open

     * @param <Float>   $exchange - exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <float> $exchange - exchange rate'</float>

Open

     * @param <Float>   $exchange     - exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Call to method error from undeclared class \App\Log

Open

            \App\Log::error('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        $db->createCommand()->update('yetiforce_currencyupdate_banks', ['active' => 0])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        return (new \App\Db\Query())

• Exclude checks
  • Disable engine
  • Disable check

Expected @param annotation for dateCur to be before the @param annotation for cron

Open

     * @param bool   $cron    - true if fired by server, and so updates systems currency conversion rates

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $currId - currency id'</integer>

Open

     * @param <Integer> $currId       - currency id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $bankId - id of bank'</integer>

Open

     * @param <Integer> $bankId       - id of bank

• Exclude checks
  • Disable engine
  • Disable check

Variable $unsupported was undeclared, but array fields are being added to it.

Open

            $unsupported[$name] = $code;

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $bankId - bank id'</integer>

Open

     * @param <Integer> $bankId - bank id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $currencyId - systems currency id'</integer>

Open

     * @param <Integer> $currencyId   - systems currency id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $date - date for which to fetch exchange rates'</date>

Open

     * @param <Date> $date    - date for which to fetch exchange rates

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        \App\Db::getInstance()->createCommand()->insert('yetiforce_currencyupdate', [

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        return (new \App\Db\Query())->select(['bank_name'])->from('yetiforce_currencyupdate_banks')->where(['active' => 1])->scalar();

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $exchangeDate - date of exchange rate'</date>

Open

     * @param <Date>    $exchangeDate - date of exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        return (new \App\Db\Query())->select(['id'])->from('yetiforce_currencyupdate_banks')->where(['active' => 1])->scalar();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        $result = $db->createCommand()->update('yetiforce_currencyupdate_banks', ['active' => 1], ['id' => $bankId])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $id - exchange rate id'</integer>

Open

     * @param <Integer> $id       - exchange rate id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <integer> - bank id'</integer>

Open

     * @return <Integer> - bank id

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                $query->select(['conversion_rate'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

            $query->select(['yetiforce_currencyupdate.exchange'])

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <float> - floating point number'</float>

Open

     * @return <Float> - floating point number

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <integer> - number of currencies'</integer>

Open

     * @return <Integer> - number of currencies

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        $dataReader = (new \App\Db\Query())->select(['currency_name', 'currency_code'])

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <float> $exchange - exchange rate'</float>

Open

     * @param <Float> $exchange - exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $dateCur - date, if empty show this months history'</date>

Open

     * @param <Date>       $dateCur - date, if empty show this months history

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <float> - conversion rate'</float>

Open

     * @return <Float> - conversion rate

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        \App\Db::getInstance()->createCommand()

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $exchangeDate - exchange date'</date>

Open

     * @param <Date>    $exchangeDate - exchange date

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $bankId - bank id'</integer>

Open

     * @param <Integer>    $bankId  - bank id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <array> - array containing currency rates'</array>

Open

     * @return <Array> - array containing currency rates

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        \App\Db::getInstance()->createCommand()

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <integer> $bankId - bank id'</integer>

Open

     * @param <Integer> $bankId       - bank id

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        return (new \App\Db\Query())->select(['id'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::count

Open

                $num = (float) ($query->count());

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $date - date of the exchange rate'</date>

Open

     * @param <Date>  $date   - date of the exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'currency_code'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

                $db->createCommand()->delete('yetiforce_currencyupdate_banks', ['id' => $id])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        $query = (new App\Db\Query())->select(['exchange', 'currency_name', 'currency_code', 'currency_symbol', 'fetch_date', 'exchange_date'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                $query->select(['yetiforce_currencyupdate.exchange'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

                $db->createCommand()->insert('yetiforce_currencyupdate_banks', ['bank_name' => $bankClassName, 'active' => 0])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @return <integer> - currency rate id'</integer>

Open

     * @return <Integer> - currency rate id

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <float> $amount - number to convert'</float>

Open

     * @param <Float> $amount - number to convert

• Exclude checks
  • Disable engine
  • Disable check

Saw unextractable annotation for comment '* @param <date> $date - date of the exchange rate'</date>

Open

     * @param <Date> $date - date of the exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

            $query->select(['conversion_rate'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'bank_name'])

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $query->from('yetiforce_currencyupdate')

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $convertToMainCurrency. Keep variable name length under 20.

Open

                $convertToMainCurrency = 1 / $exchange;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_CurrencyUpdate_Module_Model extends \App\Base

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_CurrencyUpdate_Module_Model is not named in CamelCase.

Open

class Settings_CurrencyUpdate_Module_Model extends \App\Base
{
    // Returns objects instance

    public static function getCleanInstance()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Avoid variables with short names like $to. Configured minimum length is 3.

Open

    public function getCRMConversionRate($from, $to, $date = '')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

            $id = $row['id'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $db. Configured minimum length is 3.

Open

        $db = App\Db::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function updateCurrencyRate($id, $exchange)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $db. Configured minimum length is 3.

Open

        $db = \App\Db::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

                $id = $row['id'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $to. Configured minimum length is 3.

Open

    public function convertFromTo($amount, $from, $to, $date = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $bank->getRates($otherCurrencyCode, $dateCur, false);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $db->createCommand()->update('yetiforce_currencyupdate_banks', ['active' => 1], ['bank_name' => 'NBP'])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'bank_id' => $bankId,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Integer> $currencyId   - systems currency id

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return string - currency name

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Returns list of active currencies in CRM.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $notifyNewRates = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            while ($row = $dataReader->read()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $dataReader->close();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->where(['exchange_date' => $dateCur, 'currency_id' => $currIds, 'bank_id' => $selectBankId])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $db->createCommand()->delete('yetiforce_currencyupdate_banks', ['id' => $id])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $isExists = (new \App\Db\Query())->from('yetiforce_currencyupdate_banks')->where(['bank_name' => $bankClassName])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function getCleanInstance()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Date> $date    - date for which to fetch exchange rates

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function fetchCurrencyRates($dateCur, $cron = false)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $numToConvert = $dataReader->count();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $code = $row['currency_code'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!$isExists) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Integer> $id       - exchange rate id

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'fetch_date' => date('Y-m-d'),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return new self();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return (new \App\Db\Query())

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param bool   $cron    - true if fired by server, and so updates systems currency conversion rates

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return bool - true if fetched new exchange rates, false otherwise

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!\App\RequestUtil::isNetConnection()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$this->getActiveBankId()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Update currency rate in archives.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $activeBankName = 'Settings_CurrencyUpdate_' . $this->getActiveBankName() . '_BankModel';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            // download only if its not in archives

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($currNum != $numToConvert && class_exists($activeBankName)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $db = App\Db::getInstance();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        while ($row = $dataReader->read()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Integer> $bankId       - bank id

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function getCRMCurrencyName($code)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $currIds = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $id = $row['id'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach (new DirectoryIterator(ROOT_DIRECTORY . '/modules/Settings/CurrencyUpdate/bankmodels/') as $fileInfo) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'exchange_date' => $exchangeDate,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed  $dateCur

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 138 characters

Open

                $db->createCommand()->insert('yetiforce_currencyupdate_banks', ['bank_name' => $bankClassName, 'active' => 0])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function addCurrencyRate($currId, $exchangeDate, $exchange, $bankId)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Returns currency exchange rate id.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from('vtiger_currencies')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return \count(\App\Fields\Currency::getAll(true));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->count(1);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $notifyNewRates = true;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function refreshBanks()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'currency_code'])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $otherCurrencyCode[$code] = $id;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Returns CRMS active currency name by currency code.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->scalar();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getCurrencyNum()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Returns currency exchange rates for systems active currencies from bank.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    // Synchronises database banks list with the bank classes existing on ftp

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $bankClassName = $fileInfo->getBasename('.php');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Float>   $exchange - exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Float>   $exchange     - exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Date>    $exchangeDate - date of exchange rate

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    // Returns objects instance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $bank = new $activeBankName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!file_exists($bankPath)) { // delete bank from database

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                continue;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        \App\Db::getInstance()->createCommand()->insert('yetiforce_currencyupdate', [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'currency_id' => $currId,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->andWhere(['<>', 'defaultid', -11])->createCommand()->query();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from('yetiforce_currencyupdate_banks')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->createCommand()->query();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!$fileInfo->isFile() || 'php' !== $fileInfo->getExtension()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        \App\Db::getInstance()->createCommand()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->update('yetiforce_currencyupdate', ['exchange' => $exchange], ['id' => $id])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $selectBankId = $this->getActiveBankId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $bankPath = ROOT_DIRECTORY . "/modules/Settings/CurrencyUpdate/bankmodels/{$row['bank_name']}.php";

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 127 characters

Open

            $db->createCommand()->update('yetiforce_currencyupdate_banks', ['active' => 1], ['bank_name' => 'NBP'])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return <Integer> - number of currencies

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $currIds[] = $id;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $notifyNewRates;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader = (new \App\Db\Query())->select(['id', 'bank_name'])

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 136 characters

Open

            $isExists = (new \App\Db\Query())->from('yetiforce_currencyupdate_banks')->where(['bank_name' => $bankClassName])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Integer> $bankId       - id of bank

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $code

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->select(['currency_name'])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->where(['currency_status' => 'Active', 'deleted' => 0])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($numToConvert >= 1) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $id = $row['id'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $currNum = (new \App\Db\Query())->from('yetiforce_currencyupdate')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $db->createCommand()->insert('yetiforce_currencyupdate_banks', ['bank_name' => $bankClassName, 'active' => 0])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Adds currency exchange rate to archive.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Integer> $currId       - currency id

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->where(['currency_code' => $code])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from('vtiger_currency_info')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $otherCurrencyCode = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataReader->close();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function updateCurrencyRate($id, $exchange)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param <Date>    $exchangeDate - exchange date

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'exchange' => $exchange,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->from('yetiforce_currencyupdate')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getRatesHistory($bankId, $dateCur, App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return <Array> - array of supported currencies

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getSupportedCurrencies($bankName = null)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!$bankName) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function setCRMConversionRate($currency, $exchange)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($from != $mainCurrencyCode) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ->from('vtiger_currency_info')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!\App\RequestUtil::isNetConnection()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $bank = new $bankName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $unsupported[$name] = $code;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Sets systems exchange rate for chosen currency.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param string  $currency - currency code

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $query->select(['conversion_rate'])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ->innerJoin('vtiger_currency_info', 'vtiger_currency_info.id = yetiforce_currencyupdate.currency_id')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        // filter by date - if not exists then display this months history

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open