YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/LangManagement/actions/Export.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '23', column '18').
Open

        $package = new vtlib\LanguageExport();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View

The class Settings_LangManagement_Export_Action is not named in CamelCase.
Open

class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View
{
    /**
     * Process request.
     *

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param \App\Request $request

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $package = new vtlib\LanguageExport();

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

        $package->exportLanguage($lang, '', $lang . '.zip', true);

Spaces must be used to indent lines; tabs are not allowed
Open

     * Process request.

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

        $lang = $request->getByType('lang', 1);

Class name "Settings_LangManagement_Export_Action" is not in camel caps format
Open

class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View

There are no issues that match your filters.

Category
Status