modules/Settings/LangManagement/actions/Export.php
Missing class import via use statement (line '23', column '18'). Open
Open
$package = new vtlib\LanguageExport();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View
- Exclude checks
The class Settings_LangManagement_Export_Action is not named in CamelCase. Open
Open
class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View
{
/**
* Process request.
*
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param \App\Request $request
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$package = new vtlib\LanguageExport();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$package->exportLanguage($lang, '', $lang . '.zip', true);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Process request.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$lang = $request->getByType('lang', 1);
- Exclude checks
Class name "Settings_LangManagement_Export_Action" is not in camel caps format Open
Open
class Settings_LangManagement_Export_Action extends Settings_Vtiger_IndexAjax_View
- Exclude checks