Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Log/actions/LogsViewer.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(App\Request $request)
    {
        $type = $request->getByType('type');
        if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
            throw new \App\Exceptions\NoPermittedForAdmin('ERR_ILLEGAL_VALUE');
Severity: Minor
Found in modules/Settings/Log/actions/LogsViewer.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(App\Request $request)
    {
        $type = $request->getByType('type');
        if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
            throw new \App\Exceptions\NoPermittedForAdmin('ERR_ILLEGAL_VALUE');
Severity: Major
Found in modules/Settings/Log/actions/LogsViewer.php - About 2 hrs to fix

    Function loadFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadFilter(App\Request $request, array $filter, App\Db\Query &$query)
    {
        foreach ($filter as $key => $value) {
            if ($request->has($key) && '' !== $request->getRaw($key)) {
                switch ($value) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method process() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
    Open

        public function process(App\Request $request)
    {
        $type = $request->getByType('type');
        if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
            throw new \App\Exceptions\NoPermittedForAdmin('ERR_ILLEGAL_VALUE');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.
    Open

        public function process(App\Request $request)
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Avoid using undefined variables such as '$logsViewerColumnMapping' which will lead to PHP notices.
    Open

            if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$logsViewerColumnMapping' which will lead to PHP notices.
    Open

            $mapping = \App\Log::$logsViewerColumnMapping[$type];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Missing class import via use statement (line '31', column '18').
    Open

                $query = (new \App\Db\Query())->from($mapping['table']);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '23', column '14').
    Open

                throw new \App\Exceptions\NoPermittedForAdmin('ERR_ILLEGAL_VALUE');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\Fields\Date' in method 'process'.
    Open

                                $r[] = \App\Fields\Date::formatToDisplay($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Record' in method 'process'.
    Open

                                $r[] = \App\Record::getLabel($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Layout' in method 'process'.
    Open

                                $r[] = $row[$key] ? \App\Layout::truncateText($row[$key], 50, true) : '';
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\Owner' in method 'process'.
    Open

                                $r[] = \App\Fields\Owner::getUserLabel($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Fields\DateTime' in method 'process'.
    Open

                                $r[] = \App\Fields\DateTime::formatToDisplay($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'process'.
    Open

            echo \App\Json::encode([
            'draw' => $request->getInteger('draw'),
            'iTotalRecords' => $logsCountAll ?? 0,
            'iTotalDisplayRecords' => $count ?? 0,
            'aaData' => $rows
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "columns" 3 times.
    Open

            foreach ($request->getArray('columns') as $key => $value) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Add a "case default" clause to this "switch" statement.
    Open

                    switch ($value) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by sonar-php

    The requirement for a final case default clause is defensive programming. The clause should either take appropriate action, or contain a suitable comment as to why no action is taken. Even when the switch covers all current values of an enum, a default case should still be used because there is no guarantee that the enum won't be extended.

    Noncompliant Code Example

    switch ($param) {  //missing default clause
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

switch ($param) {
  default: // default clause should be the last one
    error();
    break;
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

    Compliant Solution

    switch ($param) {
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
  default:
    error();
    break;
}

    See

    • MISRA C:2004, 15.0 - The MISRA C switch syntax shall be used.
    • MISRA C:2004, 15.3 - The final clause of a switch statement shall be the default clause
    • MISRA C++:2008, 6-4-3 - A switch statement shall be a well-formed switch statement.
    • MISRA C++:2008, 6-4-6 - The final clause of a switch statement shall be the default-clause
    • MISRA C:2012, 16.1 - All switch statements shall be well-formed
    • MISRA C:2012, 16.4 - Every switch statement shall have a default label
    • MISRA C:2012, 16.5 - A default label shall appear as either the first or the last switch label of a switch statement
    • MITRE, CWE-478 - Missing Default Case in Switch Statement
    • CERT, MSC01-C. - Strive for logical completeness
    • CERT, MSC01-CPP. - Strive for logical completeness

    Define a constant instead of duplicating this literal "column" 3 times.
    Open

                if ($order && isset($columns[$order['column']], $mapping['columns'][$columns[$order['column']]])) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Add a "case default" clause to this "switch" statement.
    Open

                        switch ($value['type']) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by sonar-php

    The requirement for a final case default clause is defensive programming. The clause should either take appropriate action, or contain a suitable comment as to why no action is taken. Even when the switch covers all current values of an enum, a default case should still be used because there is no guarantee that the enum won't be extended.

    Noncompliant Code Example

    switch ($param) {  //missing default clause
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

switch ($param) {
  default: // default clause should be the last one
    error();
    break;
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

    Compliant Solution

    switch ($param) {
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
  default:
    error();
    break;
}

    See

    • MISRA C:2004, 15.0 - The MISRA C switch syntax shall be used.
    • MISRA C:2004, 15.3 - The final clause of a switch statement shall be the default clause
    • MISRA C++:2008, 6-4-3 - A switch statement shall be a well-formed switch statement.
    • MISRA C++:2008, 6-4-6 - The final clause of a switch statement shall be the default-clause
    • MISRA C:2012, 16.1 - All switch statements shall be well-formed
    • MISRA C:2012, 16.4 - Every switch statement shall have a default label
    • MISRA C:2012, 16.5 - A default label shall appear as either the first or the last switch label of a switch statement
    • MITRE, CWE-478 - Missing Default Case in Switch Statement
    • CERT, MSC01-C. - Strive for logical completeness
    • CERT, MSC01-CPP. - Strive for logical completeness

    Reference to static property logsViewerColumnMapping from undeclared class \App\Log
    Open

            $mapping = \App\Log::$logsViewerColumnMapping[$type];
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::andWhere
    Open

                            $query->andWhere(['like', $key, $request->getByType($key, 'Text')]);
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::count
    Open

                $count = (int) $query->count('*');
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to method getUserLabel from undeclared class \App\Fields\Owner
    Open

                                $r[] = \App\Fields\Owner::getUserLabel($row[$key]);
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Reference to static property logsViewerColumnMapping from undeclared class \App\Log
    Open

            if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::from
    Open

                $query = (new \App\Db\Query())->from($mapping['table']);
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to method close from undeclared class \yii\db\DataReader
    Open

                $dataReader->close();
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::andWhere
    Open

                            $query->andWhere(['between', $key, $range[0] . ' 00:00:00', $range[1] . ' 23:59:59']);
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to method read from undeclared class \yii\db\DataReader
    Open

                while ($row = $dataReader->read()) {
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::limit
    Open

                $query->limit($request->getInteger('length'))->offset($request->getInteger('start'));
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Call to undeclared method \App\Db\Query::orderBy
    Open

                    $query->orderBy([$columns[$order['column']] => \App\Db::ASC === strtoupper($order['dir']) ? \SORT_ASC : \SORT_DESC]);
    Severity: Critical
    Found in modules/Settings/Log/actions/LogsViewer.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_Log_LogsViewer_Action extends Settings_Vtiger_Basic_Action
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Avoid variables with short names like $r. Configured minimum length is 3.
    Open

                    $r = [];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class Settings_Log_LogsViewer_Action is not named in CamelCase.
    Open

    class Settings_Log_LogsViewer_Action extends Settings_Vtiger_Basic_Action
{
    /** {@inheritdoc} */
    public function process(App\Request $request)
    {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        switch ($value['type']) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            case 'Date':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function loadFilter(App\Request $request, array $filter, App\Db\Query &$query)
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'DateTimeRange':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query = (new \App\Db\Query())->from($mapping['table']);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $logsCountAll = (int) $query->count('*');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            case 'DateTime':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $type = $request->getByType('type');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $rows[] = $r;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $query->limit($request->getInteger('length'))->offset($request->getInteger('start'));
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $order = current($request->getArray('order', App\Purifier::ALNUM));
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Line exceeds 120 characters; contains 133 characters
    Open

                    $query->orderBy([$columns[$order['column']] => \App\Db::ASC === strtoupper($order['dir']) ? \SORT_ASC : \SORT_DESC]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $r[] = \App\Fields\DateTime::formatToDisplay($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            case 'Reference':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader->close();
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            header('content-type: text/json; charset=UTF-8');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Load filter.
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($request->getArray('columns') as $key => $value) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $range = $request->getByType($key, 'DateRangeUserFormat');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $query->andWhere(['like', $key, $request->getByType($key, 'Text')]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!isset(\App\Log::$logsViewerColumnMapping[$type])) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    switch ($value) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $query->andWhere(['between', $key, $range[0] . ' 00:00:00', $range[1] . ' 23:59:59']);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $rows = $columns = [];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $columns[$key] = $value['name'];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (\App\Db::getInstance()->isTableExists($mapping['table'])) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $r[] = \App\Fields\Date::formatToDisplay($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $r[] = \App\Fields\Owner::getUserLabel($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'draw' => $request->getInteger('draw'),
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'iTotalDisplayRecords' => $count ?? 0,
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $mapping = \App\Log::$logsViewerColumnMapping[$type];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            case 'Owner':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'iTotalRecords' => $logsCountAll ?? 0,
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param array        $filter
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                throw new \App\Exceptions\NoPermittedForAdmin('ERR_ILLEGAL_VALUE');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($order && isset($columns[$order['column']], $mapping['columns'][$columns[$order['column']]])) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                while ($row = $dataReader->read()) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $r[] = \App\Record::getLabel($row[$key]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param App\Db\Query $query
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($request->has($key) && '' !== $request->getRaw($key)) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $count = (int) $query->count('*');
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader = $query->createCommand()->query();
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $r = [];
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach ($mapping['columns'] as $key => $value) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            echo \App\Json::encode([
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query->orderBy([$columns[$order['column']] => \App\Db::ASC === strtoupper($order['dir']) ? \SORT_ASC : \SORT_DESC]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $r[] = $row[$key] ? \App\Layout::truncateText($row[$key], 50, true) : '';
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param App\Request  $request
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($filter as $key => $value) {
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(App\Request $request)
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $this->loadFilter($request, $mapping['filter'], $query);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            case 'Text':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'aaData' => $rows
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ]);
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        case 'Text':
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    Class name "Settings_Log_LogsViewer_Action" is not in camel caps format
    Open

    class Settings_Log_LogsViewer_Action extends Settings_Vtiger_Basic_Action
    Severity: Minor
    Found in modules/Settings/Log/actions/LogsViewer.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status