modules/Settings/Magento/actions/DeleteAjax.php
Missing class import via use statement (line '21', column '19'). Open
Open
$response = new Vtiger_Response();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Magento_DeleteAjax_Action extends Settings_Vtiger_Delete_Action- Exclude checks
The class Settings_Magento_DeleteAjax_Action is not named in CamelCase. Open
Open
class Settings_Magento_DeleteAjax_Action extends Settings_Vtiger_Delete_Action
{
/** {@inheritdoc} */
public function process(App\Request $request)
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response = new Vtiger_Response();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
Settings_Magento_Record_Model::getInstanceById($request->getInteger('record'))->delete();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response->emit();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response->setResult(['success' => true]);- Exclude checks
Class name "Settings_Magento_DeleteAjax_Action" is not in camel caps format Open
Open
class Settings_Magento_DeleteAjax_Action extends Settings_Vtiger_Delete_Action- Exclude checks