modules/Settings/Magento/models/Record.php
Method getFieldInstanceByName has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getFieldInstanceByName($name)
{
$moduleName = $this->getModule()->getName(true);
$fields = $this->getModule()->getFormFields();
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];Method getRecordLinks has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getRecordLinks(): array
{
$links = [];
$recordLinks = [
[Function getFieldInstanceByName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getFieldInstanceByName($name)
{
$moduleName = $this->getModule()->getName(true);
$fields = $this->getModule()->getFormFields();
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setDataFromRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function setDataFromRequest(App\Request $request)
{
foreach ($this->getModule()->getFormFields() as $fieldName => $fieldInfo) {
switch ($fieldName) {
case 'password':- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getFieldInstanceByName() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10. Open
Open
public function getFieldInstanceByName($name)
{
$moduleName = $this->getModule()->getName(true);
$fields = $this->getModule()->getFormFields();
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Settings_Magento_Record_Model has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Open
Open
class Settings_Magento_Record_Model extends Settings_Vtiger_Record_Model
{
/**
* Record ID.
*- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '283', column '15'). Open
Open
throw new \App\Exceptions\IllegalValue('ERR_NO_VALUE||' . \App\Language::translate('LBL_' . \strtoupper($fieldName), $this->getModule()->getName(true)), 406);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Vtiger_Link_Model' in method 'getRecordLinks'. Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Integrations\Magento\Config' in method 'getInstanceById'. Open
Open
if ($row = \App\Integrations\Magento\Config::getServer($id)) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '123', column '7'). Open
Open
public static function getInstanceById(int $id)
{
$instance = false;
if ($row = \App\Integrations\Magento\Config::getServer($id)) {
$instance = new self();- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$db->createCommand()->insert('i_#__magento_servers', $params)->execute();
$this->set('id', $db->getLastInsertID('i_#__magento_servers_id_seq'));
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Cache' in method 'delete'. Open
Open
\App\Cache::delete('Magento|getAllServers', '');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
Open
'None' => \App\Language::translate('None'),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Vtiger_Field_Model' in method 'getFieldInstanceByName'. Open
Open
return \Vtiger_Field_Model::init($moduleName, $params, $name);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Cache' in method 'save'. Open
Open
\App\Cache::delete('Magento|getAllServers', '');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Vtiger_Module_Model' in method 'getModule'. Open
Open
$this->module = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
Open
'IStorages' => \App\Language::translate('SINGLE_IStorages', 'IStorages'),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'. Open
Open
$value = \App\Purifier::encodeHtml($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
Open
'Products' => \App\Language::translate('SINGLE_Products', 'Products'),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Vtiger_Module_Model' in method 'getCleanInstance'. Open
Open
$moduleInstance = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getDisplayValue'. Open
Open
$value = \App\Language::translate(1 == $value ? 'LBL_ACTIVE' : 'LBL_INACTIVE', 'Settings:Magento');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Db' in method 'save'. Open
Open
$db = App\Db::getInstance('admin');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'setDataFromRequest'. Open
Open
throw new \App\Exceptions\IllegalValue('ERR_NO_VALUE||' . \App\Language::translate('LBL_' . \strtoupper($fieldName), $this->getModule()->getName(true)), 406);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "linkclass" 3 times. Open
Open
'linkclass' => 'btn btn-sm btn-info',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "LISTVIEWRECORD" 3 times. Open
Open
'linktype' => 'LISTVIEWRECORD',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "linkurl" 3 times. Open
Open
'linkurl' => $this->getEditViewUrl(),- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "IStorages" 3 times. Open
Open
$params['referenceList'] = ['IStorages'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "i_#__magento_servers" 3 times. Open
Open
->delete('i_#__magento_servers', ['id' => $this->getId()])- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "linkicon" 3 times. Open
Open
'linkicon' => 'yfi yfi-full-editing-view',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "linklabel" 3 times. Open
Open
'linklabel' => 'BTN_RECORD_EDIT',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Add a "case default" clause to this "switch" statement. Open
Open
switch ($name) {- Read upRead up
- Exclude checks
The requirement for a final case default clause is defensive programming. The clause should either take appropriate action, or contain
a suitable comment as to why no action is taken. Even when the switch covers all current values of an enum, a default case
should still be used because there is no guarantee that the enum won't be extended.
Noncompliant Code Example
switch ($param) { //missing default clause
case 0:
do_something();
break;
case 1:
do_something_else();
break;
}
switch ($param) {
default: // default clause should be the last one
error();
break;
case 0:
do_something();
break;
case 1:
do_something_else();
break;
}
Compliant Solution
switch ($param) {
case 0:
do_something();
break;
case 1:
do_something_else();
break;
default:
error();
break;
}
See
- MISRA C:2004, 15.0 - The MISRA C switch syntax shall be used.
- MISRA C:2004, 15.3 - The final clause of a switch statement shall be the default clause
- MISRA C++:2008, 6-4-3 - A switch statement shall be a well-formed switch statement.
- MISRA C++:2008, 6-4-6 - The final clause of a switch statement shall be the default-clause
- MISRA C:2012, 16.1 - All switch statements shall be well-formed
- MISRA C:2012, 16.4 - Every switch statement shall have a default label
- MISRA C:2012, 16.5 - A default label shall appear as either the first or the last switch label of a switch statement
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness
- CERT, MSC01-CPP. - Strive for logical completeness
Define a constant instead of duplicating this literal "maximumlength" 3 times. Open
Open
$params['maximumlength'] = '16777215';- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "Settings:Magento" 3 times. Open
Open
$moduleInstance = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "linktype" 3 times. Open
Open
'linktype' => 'LISTVIEWRECORD',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "typeofdata" 4 times. Open
Open
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "uitype" 8 times. Open
Open
$params['uitype'] = 7;- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Return type of getCleanInstance() is undeclared type \self Open
Open
public static function getCleanInstance()- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
$db->createCommand()->insert('i_#__magento_servers', $params)->execute();- Exclude checks
Reference to undeclared property \Settings_Magento_Record_Model->module Open
Open
$instance->module = $moduleInstance;- Exclude checks
Return type of getInstanceById() is undeclared type \self Open
Open
public static function getInstanceById(int $id)- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
\App\Db::getInstance('admin')->createCommand()- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
$db->createCommand()->update('i_#__magento_servers', $params, ['id' => $this->getId()])->execute();- Exclude checks
Reference to undeclared property \Settings_Magento_Record_Model->module Open
Open
if (!isset($this->module)) {- Exclude checks
Saw an @param annotation for type, but the param list of function getCleanInstance() : \Settings_Magento_Record_Model|\self is empty Open
Open
* @param string $type- Exclude checks
Reference to undeclared property \Settings_Magento_Record_Model->module Open
Open
$this->module = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Exclude checks
Reference to undeclared property \Settings_Magento_Record_Model->module Open
Open
return $this->module;- Exclude checks
Call to method getInstance from undeclared class \App\Encryption (Did you mean class \Tests\App\Encryption) Open
Open
$value = \App\Encryption::getInstance()->encrypt($request->getRaw($fieldName));- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Magento_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public static function getInstanceById(int $id)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Settings_Magento_Record_Model is not named in CamelCase. Open
Open
class Settings_Magento_Record_Model extends Settings_Vtiger_Record_Model
{
/**
* Record ID.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = App\Db::getInstance('admin');- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-sm btn-danger text-white',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['isEditableReadOnly'] = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return '?parent=Settings&module=Magento&action=SaveAjax&mode=save';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->module;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['typeofdata'] = 'I';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['isEditableReadOnly'] = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'url':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 17;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '250';- Exclude checks
Line exceeds 120 characters; contains 124 characters Open
Open
$value = $request->isEmpty($fieldName) ? '' : $request->getByType($fieldName, $fieldInfo['purifyType']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('name');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordLinks = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'yfi yfi-full-editing-view',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => "javascript:Settings_Magento_List_Js.reload('{$this->getId()}')",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getCleanInstance()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields = $this->getModule()->getFormFields();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['typeofdata'] = 'I';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'customers_limit':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Save Ajax.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getRecordLinks(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Db::getInstance('admin')->createCommand()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Cache::delete('Magento|getAllServers', '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new self();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->set('id', $db->getLastInsertID('i_#__magento_servers_id_seq'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Settings_Vtiger_Field_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFieldInstanceByName($name)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '65535';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param App\Request $request- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($fieldName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Detail Url.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getEditViewUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-sm btn-info',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_DELETE_RECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance->setData($row);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->getId()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!isset($this->module)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'invoices_limit':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['referenceList'] = ['IStorages'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'] = ['Token' => 'Token'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Products' => \App\Language::translate('SINGLE_Products', 'Products'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 56;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('id');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \self- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new self();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db->createCommand()->update('i_#__magento_servers', $params, ['id' => $this->getId()])->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '16777215';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 10;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'payment_paypal_service_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $this->get($key);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function setDataFromRequest(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDetailViewUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'index.php?parent=Settings&module=Magento&view=Edit&record=' . $this->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'BTN_RECORD_EDIT',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'fas fa-trash-alt',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->delete('i_#__magento_servers', ['id' => $this->getId()])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->module = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param $name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 7;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 7;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'storage_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_categories':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'status':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->set($fieldName, $value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($row = \App\Integrations\Magento\Config::getServer($id)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the clean instance.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to save.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params[$key] = $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getModule()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $this->getModule()->getName(true);- Exclude checks
Line exceeds 120 characters; contains 150 characters Open
Open
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'IStorages' => \App\Language::translate('SINGLE_IStorages', 'IStorages'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_orders':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-sm btn-warning text-white',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \self instance, if exists- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db->createCommand()->insert('i_#__magento_servers', $params)->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_products':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_invoices':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Purifier::encodeHtml($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'password':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ('' === $value && $fieldInfo['required']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getId()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => "javascript:Settings_Vtiger_List_Js.deleteById('{$this->getId()}')",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'store_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'products_limit':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($key) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $request->isEmpty($fieldName) ? '' : $request->getByType($fieldName, $fieldInfo['purifyType']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Edit View Url.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($recordLinks as $recordLink) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function delete()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params = ['label' => 'LBL_' . \strtoupper($name), 'fieldvalue' => $this->get($name) ?? $fields[$name]['default'] ?? '', 'typeofdata' => 'V'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'categories_limit':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_customers':- Exclude checks
Line exceeds 120 characters; contains 174 characters Open
Open
throw new \App\Exceptions\IllegalValue('ERR_NO_VALUE||' . \App\Language::translate('LBL_' . \strtoupper($fieldName), $this->getModule()->getName(true)), 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_RELOAD_MAGENTO',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $links;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get field instance by name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['referenceList'] = ['Services'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 16;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['typeofdata'] .= $fields[$name]['required'] ? '~M' : '~O';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDisplayValue(string $key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Sets data from request.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return '?parent=Settings&module=Magento&view=Edit&record=' . $this->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to delete the current record model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function save()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($this->getData() as $key => $value) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Cache::delete('Magento|getAllServers', '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get Module instance.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws ReflectionException- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'orders_limit':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 10;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'mdi mdi-reload',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $type- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleInstance = Settings_Vtiger_Module_Model::getInstance('Settings:Magento');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance->module = $moduleInstance;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Settings_Magento_Module_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'shipping_service_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'connector':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 16;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sync_currency':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \Vtiger_Field_Model::init($moduleName, $params, $name);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Language::translate(1 == $value ? 'LBL_ACTIVE' : 'LBL_INACTIVE', 'Settings:Magento');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($this->getModule()->getFormFields() as $fieldName => $fieldInfo) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Encryption::getInstance()->encrypt($request->getRaw($fieldName));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\IllegalValue('ERR_NO_VALUE||' . \App\Language::translate('LBL_' . \strtoupper($fieldName), $this->getModule()->getName(true)), 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getSaveAjaxActionUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => $this->getEditViewUrl(),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the instance of record model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'None' => \App\Language::translate('None'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Record name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getInstanceById(int $id)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = App\Db::getInstance('admin');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'payment_cash_service_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'storage_quantity_location':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'status':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel = $this->getFieldInstanceByName($fieldName)->getUITypeModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel->validate($value, true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $fieldModel->getDBValue($value);- Exclude checks
Class name "Settings_Magento_Record_Model" is not in camel caps format Open
Open
class Settings_Magento_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks