modules/Settings/Mail/models/Module.php
Missing class import via use statement (line '59', column '23'). Open
Open
$attachments = (new \App\Db\Query())->select(['attachments'])->from('s_#__mail_queue')->where(['id' => $id])->scalar(\App\Db::getInstance('admin')) ?: '[]';- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Settings_Vtiger_MenuItem_Model' in method 'getDefaultUrl'. Open
Open
$menu = Settings_Vtiger_MenuItem_Model::getInstance('LBL_EMAILS_TO_SEND');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Mail' in method 'getAttachmentInfo'. Open
Open
$attachments = array_merge($attachments, \App\Mail::getAttachmentsFromDocument($attachments['ids']));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getAttachmentInfo'. Open
Open
$attachments = \App\Json::decode($attachments);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Db' in method 'getAttachmentInfo'. Open
Open
$attachments = (new \App\Db\Query())->select(['attachments'])->from('s_#__mail_queue')->where(['id' => $id])->scalar(\App\Db::getInstance('admin')) ?: '[]';- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Returning type array{path:mixed,name:mixed|null} but getAttachmentInfo() is declared to return string Open
Open
return ['path' => $path, 'name' => $name];- Exclude checks
Returning type array{path:mixed,name:mixed|null} but getAttachmentInfo() is declared to return string Open
Open
return ['path' => $path, 'name' => $name];- Exclude checks
Call to undeclared method \App\Db\Query::select Open
Open
$attachments = (new \App\Db\Query())->select(['attachments'])->from('s_#__mail_queue')->where(['id' => $id])->scalar(\App\Db::getInstance('admin')) ?: '[]';- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Mail_Module_Model extends Settings_Vtiger_Module_Model- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public static function getAttachmentInfo($id, $selectedFile)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Settings_Mail_Module_Model is not named in CamelCase. Open
Open
class Settings_Mail_Module_Model extends Settings_Vtiger_Module_Model
{
public $baseTable = 's_#__mail_queue';
public $baseIndex = 'id';
public $listFields = ['smtp_id' => 'LBL_SMTP_NAME', 'date' => 'LBL_DATE', 'owner' => 'LBL_CREATED_BY', 'subject' => 'LBL_SUBJECT', 'status' => 'LBL_STATUS', 'priority' => 'LBL_PRIORITY', 'error' => 'LBL_ERROR'];- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $baseIndex = 'id';- Exclude checks
Line exceeds 120 characters; contains 215 characters Open
Open
public $listFields = ['smtp_id' => 'LBL_SMTP_NAME', 'date' => 'LBL_DATE', 'owner' => 'LBL_CREATED_BY', 'subject' => 'LBL_SUBJECT', 'status' => 'LBL_STATUS', 'priority' => 'LBL_PRIORITY', 'error' => 'LBL_ERROR'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDefaultUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getCreateRecordUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$attachments = \App\Json::decode($attachments);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$attachments = array_merge($attachments, \App\Mail::getAttachmentsFromDocument($attachments['ids']));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return ['path' => $path, 'name' => $name];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $baseTable = 's_#__mail_queue';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($attachments['ids'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($counter === $selectedFile) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the url for create view of the module.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getAttachmentInfo($id, $selectedFile)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $selectedFile- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return ['path' => $path, 'name' => $name];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $listFields = ['smtp_id' => 'LBL_SMTP_NAME', 'date' => 'LBL_DATE', 'owner' => 'LBL_CREATED_BY', 'subject' => 'LBL_SUBJECT', 'status' => 'LBL_STATUS', 'priority' => 'LBL_PRIORITY', 'error' => 'LBL_ERROR'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->filterFields;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'index.php?module=Mail&parent=Settings&view=List&fieldid=' . $menu->get('fieldid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($attachments['ids']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$counter = 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $name = 'Mail';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$counter;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the url for default view of the module.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$menu = Settings_Vtiger_MenuItem_Model::getInstance('LBL_EMAILS_TO_SEND');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$attachments = (new \App\Db\Query())->select(['attachments'])->from('s_#__mail_queue')->where(['id' => $id])->scalar(\App\Db::getInstance('admin')) ?: '[]';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $filterFields = ['smtp_id', 'status', 'priority'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFilterFields()- Exclude checks
Line exceeds 120 characters; contains 164 characters Open
Open
$attachments = (new \App\Db\Query())->select(['attachments'])->from('s_#__mail_queue')->where(['id' => $id])->scalar(\App\Db::getInstance('admin')) ?: '[]';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to gets the file info for attachment file.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$path = '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($attachments as $path => $name) {- Exclude checks
Class name "Settings_Mail_Module_Model" is not in camel caps format Open
Open
class Settings_Mail_Module_Model extends Settings_Vtiger_Module_Model- Exclude checks