modules/Settings/Mail/models/Record.php
Function getDisplayValue has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getDisplayValue(string $key)
{
$value = $this->get($key);
switch ($key) {
case 'smtp_id':- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getDisplayValue has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getDisplayValue(string $key)
{
$value = $this->get($key);
switch ($key) {
case 'smtp_id':Function getDisplayValueForEmail has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getDisplayValueForEmail($emails)
{
$value = '';
if ($emails) {
foreach (\App\Json::decode($emails) as $email => $name) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getDisplayValue() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
Open
public function getDisplayValue(string $key)
{
$value = $this->get($key);
switch ($key) {
case 'smtp_id':- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. Open
Open
public function getDisplayValue(string $key)- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Avoid using undefined variables such as '$statuses' which will lead to PHP notices. Open
Open
$value = \App\Language::translate(\App\Mailer::$statuses[$value], 'Settings::Mail');- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$statuses' which will lead to PHP notices. Open
Open
if (isset(\App\Mailer::$statuses[$value])) {- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
The class Settings_Mail_Record_Model has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. Open
Open
class Settings_Mail_Record_Model extends Settings_Vtiger_Record_Model
{
/**
* Function to get the Id.
*- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '202', column '17'). Open
Open
$query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['id' => $id]);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Db' in method 'getInstance'. Open
Open
$row = $query->createCommand(\App\Db::getInstance('admin'))->queryOne();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getDisplayValueForEmail uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$value .= $name . ' <' . $email . '>, ';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Layout' in method 'getDisplayValue'. Open
Open
$value = \App\Layout::truncateHtml($value, 'mini', 30);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'. Open
Open
$value = \App\Purifier::encodeHtml($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Mail' in method 'getDisplayValue'. Open
Open
$attachments = array_merge($attachments, \App\Mail::getAttachmentsFromDocument($attachments['ids']));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Mail' in method 'getDisplayValue'. Open
Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'DateTimeField' in method 'getDisplayValue'. Open
Open
$value = DateTimeField::convertToUserFormat($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getDisplayValue'. Open
Open
$name = \App\Language::translate('LBL_FILE');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_Link_Model' in method 'getRecordLinks'. Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getDisplayValueForEmail'. Open
Open
foreach (\App\Json::decode($emails) as $email => $name) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'vtlib\Functions' in method 'getDisplayValue'. Open
Open
$value = \App\Layout::truncateHtml(vtlib\Functions::getHtmlOrPlainText($value), 'full');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getDisplayValue'. Open
Open
$value = \App\Language::translate(\App\Mailer::$statuses[$value], 'Settings::Mail');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Owner' in method 'getDisplayValue'. Open
Open
$value = \App\Fields\Owner::getUserLabel($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Layout' in method 'getDisplayValue'. Open
Open
$value = \App\Layout::truncateHtml(vtlib\Functions::getHtmlOrPlainText($value), 'full');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getDisplayValue'. Open
Open
$attachments = \App\Json::decode($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Vtiger_MenuItem_Model' in method 'getDetailViewUrl'. Open
Open
$menu = Settings_Vtiger_MenuItem_Model::getInstance('LBL_EMAILS_TO_SEND');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "status" 3 times. Open
Open
case 'status':- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Call to undeclared method \App\Db\Query::from Open
Open
$query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['id' => $id]);- Exclude checks
Return type of getInstance() is undeclared type \self Open
Open
public static function getInstance($id)- Exclude checks
Variable $recordLinks was undeclared, but array fields are being added to it. Open
Open
$recordLinks[] = [- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
return \App\Db::getInstance('admin')->createCommand()- Exclude checks
Argument 1 (encodedValue) is array but \App\Json::decode() takes string defined at /code/app/Json.php:37 Open
Open
foreach (\App\Json::decode($emails) as $email => $name) {- Exclude checks
Call to method getUserLabel from undeclared class \App\Fields\Owner Open
Open
$value = \App\Fields\Owner::getUserLabel($value);- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
Open
public static function getInstance($id)
{
$query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['id' => $id]);
$row = $query->createCommand(\App\Db::getInstance('admin'))->queryOne();
$instance = false;- Read upRead up
app/Mail/Rbl.php on lines 220..230
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Mail_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public static function getInstance($id)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Settings_Mail_Record_Model is not named in CamelCase. Open
Open
class Settings_Mail_Record_Model extends Settings_Vtiger_Record_Model
{
/**
* Function to get the Id.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Id.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getAcceptanceActionUrl()- Exclude checks
Line exceeds 120 characters; contains 182 characters Open
Open
$value = '<span class="fas fa-exclamation-triangle js-popover-tooltip color-red-a200" data-content="' . $this->get('error') . '"> ' . $value . '</span>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'bcc':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$fileCounter;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int Id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$smtpName = \App\Mail::getSmtpById($value)['name'] ?? '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset(\App\Mailer::$statuses[$value])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($value) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($attachments as $path => $name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Layout::truncateHtml($value, 'mini', 30);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getRecordLinks(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'fas fa-check',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getId()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('id');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (2 === (int) $this->get('status')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'from':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$attachments = array_merge($attachments, \App\Mail::getAttachmentsFromDocument($attachments['ids']));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_DELETE_RECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$menu = Settings_Vtiger_MenuItem_Model::getInstance('LBL_EMAILS_TO_SEND');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'cc':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$attachments = \App\Json::decode($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$email = $name;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDisplayValue(string $key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'owner':- Exclude checks
Line exceeds 120 characters; contains 125 characters Open
Open
$attachments = array_merge($attachments, \App\Mail::getAttachmentsFromDocument($attachments['ids']));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (is_numeric($email)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Line exceeds 120 characters; contains 133 characters Open
Open
$value = '<a href=index.php?module=MailSmtp&parent=Settings&view=Detail&record=' . $value . '>' . $smtpName . '</a>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Line exceeds 120 characters; contains 145 characters Open
Open
$actionPath = "?module=Mail&parent=Settings&action=DownloadAttachment&record={$this->getId()}&selectedFile=$fileCounter";- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value .= $name . ' <' . $email . '>, ';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function delete(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => "javascript:Settings_Vtiger_List_Js.deleteById('{$this->getId()}')",- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = DateTimeField::convertToUserFormat($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fileCounter = 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$name = '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordLinks[] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$recordLinks[] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'index.php?module=Mail&parent=Settings&action=SaveAjax&mode=acceptanceRecord&record=' . $this->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$path = $name;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$name = \App\Language::translate('LBL_FILE');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return rtrim($value, ', ');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to delete the current Record Model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (0 === $this->get('status')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row = $query->createCommand(\App\Db::getInstance('admin'))->queryOne();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDetailViewUrl()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = '<a href=index.php?module=MailSmtp&parent=Settings&view=Detail&record=' . $value . '>' . $smtpName . '</a>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'to':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'attachments':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (is_numeric($path)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value .= '<form action="' . $actionPath . '"- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDisplayValueForEmail($emails)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Acceptance Action Url.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Line exceeds 120 characters; contains 130 characters Open
Open
return 'index.php?module=Mail&parent=Settings&view=Detail&record=' . $this->getId() . '&fieldid=' . $menu->get('fieldid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $this->get($key);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'smtp_id':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $this->getDisplayValueForEmail($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $emails- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-xs btn-success acceptanceRecord',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $links;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'status':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Language::translate(\App\Mailer::$statuses[$value], 'Settings::Mail');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($attachments['ids'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($attachments['ids']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the display value for emails.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkurl' => '#',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Display Value, for the current field type with given DB Insert Value.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach (\App\Json::decode($emails) as $email => $name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkclass' => 'btn btn-xs btn-danger text-white',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($recordLinks as &$recordLink) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the instance of advanced permission record model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = '<span class="fas fa-exclamation-triangle js-popover-tooltip color-red-a200" data-content="' . $this->get('error') . '"> ' . $value . '</span>';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'content':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Layout::truncateHtml(vtlib\Functions::getHtmlOrPlainText($value), 'full');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Purifier::encodeHtml($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->delete('s_#__mail_queue', ['id' => $this->getId()])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new self();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Detail Url.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 'index.php?module=Mail&parent=Settings&view=Detail&record=' . $this->getId() . '&fieldid=' . $menu->get('fieldid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'error':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linktype' => 'LISTVIEWRECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (false !== $row) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new \App\Db\Query())->from('s_#__mail_queue')->where(['id' => $id]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('name');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'date':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \App\Db::getInstance('admin')->createCommand()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($key) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Fields\Owner::getUserLabel($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$actionPath = "?module=Mail&parent=Settings&action=DownloadAttachment&record={$this->getId()}&selectedFile=$fileCounter";- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($emails) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value .= $email . ', ';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linklabel' => 'LBL_ACCEPTANCE_RECORD',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'linkicon' => 'fas fa-trash-alt',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$links[] = Vtiger_Link_Model::getInstanceFromValues($recordLink);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance->setData($row);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \self instance, if exists- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getInstance($id)- Exclude checks
Class name "Settings_Mail_Record_Model" is not in camel caps format Open
Open
class Settings_Mail_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks