Function process has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $fields = Settings_MailIntegration_ConfigForm_Model::getFields($request->getModule(false));
        $field = $request->getByType('updateField');
        if (!isset($fields[$field])) {

• Read up
  Read up

Method process has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(App\Request $request)
    {
        $fields = Settings_MailIntegration_ConfigForm_Model::getFields($request->getModule(false));
        $field = $request->getByType('updateField');
        if (!isset($fields[$field])) {

Missing class import via use statement (line '37', column '19').

Open

        $security = new \App\ConfigFile('security');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '23', column '14').

Open

            throw new \App\Exceptions\IllegalValue('ERR_ILLEGAL_VALUE');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '51', column '19').

Open

        $response = new Vtiger_Response();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '33', column '21').

Open

        $configFile = new \App\ConfigFile('module', 'MailIntegration');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'Settings_MailIntegration_ConfigForm_Model' in method 'process'.

Open

        $fields = Settings_MailIntegration_ConfigForm_Model::getFields($request->getModule(false));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'process'.

Open

        $response->setResult(['notify' => ['type' => 'success', 'text' => \App\Language::translate('LBL_CHANGES_SAVED')]]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid assigning values to variables in if clauses and the like (line '42', column '21').

Open

    public function process(App\Request $request)
    {
        $fields = Settings_MailIntegration_ConfigForm_Model::getFields($request->getModule(false));
        $field = $request->getByType('updateField');
        if (!isset($fields[$field])) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Reference to static property outlookUrls from undeclared class \Config\Modules\MailIntegration

Open

            $oldValue = \Config\Modules\MailIntegration::$outlookUrls;

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long class names like Settings_MailIntegration_SaveConfigForm_Action. Keep class name length under 40.

Open

class Settings_MailIntegration_SaveConfigForm_Action extends Settings_Vtiger_Basic_Action
{
    /** {@inheritdoc} */
    public function process(App\Request $request)
    {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_MailIntegration_SaveConfigForm_Action extends Settings_Vtiger_Basic_Action

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_MailIntegration_SaveConfigForm_Action is not named in CamelCase.

Open

class Settings_MailIntegration_SaveConfigForm_Action extends Settings_Vtiger_Basic_Action
{
    /** {@inheritdoc} */
    public function process(App\Request $request)
    {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!isset($fields[$field])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $configFile->create();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(App\Request $request)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $value = $fieldModel->get('isArray') ? $request->getArray($field, $fieldModel->get('purifyType')) : $request->getByType($field, $fieldModel->get('purifyType'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $oldValue = \Config\Modules\MailIntegration::$outlookUrls;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('outlookUrls' === $field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $configFile->set($field, $value);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $updateValue = array_unique(array_merge((\Config\Security::$allowedFrameDomains), $value));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** {@inheritdoc} */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $configFile = new \App\ConfigFile('module', 'MailIntegration');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('outlookUrls' === $field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (isset($toRemove)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response->emit();

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 168 characters

Open

        $value = $fieldModel->get('isArray') ? $request->getArray($field, $fieldModel->get('purifyType')) : $request->getByType($field, $fieldModel->get('purifyType'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $field = $request->getByType('updateField');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $security->create();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $security->set('allowedFrameDomains', array_values($updateValue));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fields = Settings_MailIntegration_ConfigForm_Model::getFields($request->getModule(false));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        unset($updateValue[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 123 characters

Open

        $response->setResult(['notify' => ['type' => 'success', 'text' => \App\Language::translate('LBL_CHANGES_SAVED')]]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $toRemove = array_diff($oldValue, $value);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (false !== ($key = array_search($value, $updateValue))) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response->setResult(['notify' => ['type' => 'success', 'text' => \App\Language::translate('LBL_CHANGES_SAVED')]]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            throw new \App\Exceptions\IllegalValue('ERR_ILLEGAL_VALUE');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldModel->getUITypeModel()->validate($value, true);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldModel = $fields[$field];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $security = new \App\ConfigFile('security');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($toRemove as $value) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $response = new Vtiger_Response();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_MailIntegration_SaveConfigForm_Action" is not in camel caps format

Open

class Settings_MailIntegration_SaveConfigForm_Action extends Settings_Vtiger_Basic_Action

• Exclude checks
  • Disable engine
  • Disable check