YetiForceCompany/YetiForceCRM

Method getFields has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function getFields(string $moduleName): array
    {
        $config = App\Config::module('MailIntegration', null, []);
        $outlookUrls = $config['outlookUrls'] ?? [];
        $fields = [

Avoid using static access to class 'App\Config' in method 'getFields'.

Open

        $config = App\Config::module('MailIntegration', null, []);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'getFields'.

Open

                'picklistValues' => \App\Module::getAllModuleNamesFilter(true, false, 0),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Field_Model' in method 'getFields'.

Open

            $fields[$key] = \Vtiger_Field_Model::init($moduleName, $value, $key);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid excessively long class names like Settings_MailIntegration_ConfigForm_Model. Keep class name length under 40.

Open

class Settings_MailIntegration_ConfigForm_Model
{
    /**
     * Get fields for config form.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Settings_MailIntegration_ConfigForm_Model

• Exclude checks
  • Disable engine
  • Disable check

The class Settings_MailIntegration_ConfigForm_Model is not named in CamelCase.

Open

class Settings_MailIntegration_ConfigForm_Model
{
    /**
     * Get fields for config form.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $config = App\Config::module('MailIntegration', null, []);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param string $moduleName

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'isArray' => true,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'fieldvalue' => $config['modulesListQuickCreate'] ?? ''

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'labelDescArgs' => 'https://outlook.live.com, https://outlook.office365.com, https://outlook.office.com',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'purifyType' => 'Alnum',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($fields as $key => $value) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function getFields(string $moduleName): array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Get fields for config form.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'labelDesc' => 'LBL_QUICK_CREATE_MODULES_DESC',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'picklistValues' => \App\Module::getAllModuleNamesFilter(true, false, 0),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'fieldvalue' => $outlookUrls,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $fields[$key] = \Vtiger_Field_Model::init($moduleName, $value, $key);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return Vtiger_Field_Model[]

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 121 characters

Open

                'labelDescArgs' => 'https://outlook.live.com, https://outlook.office365.com, https://outlook.office.com',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'modulesListQuickCreate' => [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'outlookUrls' => [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'label' => 'LBL_OUTLOOK_ADDRESSES',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'isArray' => true,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'uitype' => 33,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $outlookUrls = $config['outlookUrls'] ?? [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'uitype' => 33,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'labelDesc' => 'LBL_OUTLOOK_ADDRESSES_DESC',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fields = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $fields;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'purifyType' => 'url',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'dataSelect' => 'tags',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'label' => 'LBL_QUICK_CREATE_MODULES',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'picklistValues' => array_combine($outlookUrls, $outlookUrls),

• Exclude checks
  • Disable engine
  • Disable check

Class name "Settings_MailIntegration_ConfigForm_Model" is not in camel caps format

Open

class Settings_MailIntegration_ConfigForm_Model

• Exclude checks
  • Disable engine
  • Disable check