YetiForceCompany/YetiForceCRM

View on GitHub
modules/Settings/MailRbl/views/ConfigModal.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class 'Settings_MailRbl_ConfigModal_Model' in method 'process'.
Open

        $viewer->assign('CONFIG_FIELDS', Settings_MailRbl_ConfigModal_Model::getFields());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'App\Config' in method 'process'.
Open

        $viewer->assign('CONFIG', App\Config::component('Mail', null, []));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Language' in method 'preProcessAjax'.
Open

        $this->pageTitle = \App\Language::translate('BTN_RBL_CONFIG', $this->qualifiedModuleName);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Reference to undeclared property \Settings_MailRbl_ConfigModal_View->qualifiedModuleName
Open

        $viewer->view('ConfigModal.tpl', $this->qualifiedModuleName);

Reference to undeclared property \Settings_MailRbl_ConfigModal_View->qualifiedModuleName
Open

        $this->pageTitle = \App\Language::translate('BTN_RBL_CONFIG', $this->qualifiedModuleName);

Static call to undeclared method \App\Controller\ModalSettings::preProcessAjax
Open

        parent::preProcessAjax($request);

Reference to undeclared property \Settings_MailRbl_ConfigModal_View->pageTitle
Open

        $this->pageTitle = \App\Language::translate('BTN_RBL_CONFIG', $this->qualifiedModuleName);

Call to undeclared method \Settings_MailRbl_ConfigModal_View::getViewer
Open

        $viewer = $this->getViewer($request);

Reference to undeclared property \Settings_MailRbl_ConfigModal_View->qualifiedModuleName
Open

        $this->qualifiedModuleName = $request->getModule(false);

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Settings_MailRbl_ConfigModal_View extends \App\Controller\ModalSettings

The class Settings_MailRbl_ConfigModal_View is not named in CamelCase.
Open

class Settings_MailRbl_ConfigModal_View extends \App\Controller\ModalSettings
{
    /** {@inheritdoc} */
    public $modalSize = 'modal-lg';

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalSize = 'modal-lg';

Spaces must be used to indent lines; tabs are not allowed
Open

    public function preProcessAjax(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer = $this->getViewer($request);

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('CONFIG_FIELDS', Settings_MailRbl_ConfigModal_Model::getFields());

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->view('ConfigModal.tpl', $this->qualifiedModuleName);

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(App\Request $request)

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->qualifiedModuleName = $request->getModule(false);

Spaces must be used to indent lines; tabs are not allowed
Open

    public $showFooter = false;

Spaces must be used to indent lines; tabs are not allowed
Open

        parent::preProcessAjax($request);

Spaces must be used to indent lines; tabs are not allowed
Open

    public $modalIcon = 'fas fa-cogs';

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->pageTitle = \App\Language::translate('BTN_RBL_CONFIG', $this->qualifiedModuleName);

Spaces must be used to indent lines; tabs are not allowed
Open

        $viewer->assign('CONFIG', App\Config::component('Mail', null, []));

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Class name "Settings_MailRbl_ConfigModal_View" is not in camel caps format
Open

class Settings_MailRbl_ConfigModal_View extends \App\Controller\ModalSettings

There are no issues that match your filters.

Category
Status