Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/Menu/actions/SaveAjax.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method updateMenu has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateMenu(App\Request $request)
    {
        $data = $request->getMultiDimensionArray('mdata', [
            'id' => 'Integer',
            'type' => 'Alnum',
Severity: Minor
Found in modules/Settings/Menu/actions/SaveAjax.php - About 1 hr to fix

    Method createMenu has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createMenu(App\Request $request)
    {
        $data = $request->getMultiDimensionArray('mdata', [
            'type' => 'Alnum',
            'module' => 'Alnum',
    Severity: Minor
    Found in modules/Settings/Menu/actions/SaveAjax.php - About 1 hr to fix

      Missing class import via use statement (line '91', column '19').
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '79', column '19').
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '45', column '19').
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '103', column '19').
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '123', column '19').
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class 'Settings_Menu_Record_Model' in method 'copyMenu'.
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'createMenu'.
      Open

                  'message' => \App\Language::translate('LBL_ITEM_ADDED_TO_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_Menu_Record_Model' in method 'createMenu'.
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'removeMenu'.
      Open

                  'message' => \App\Language::translate('LBL_REMOVED_MENU_ITEM', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'copyMenu'.
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MAP_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_Menu_Record_Model' in method 'removeMenu'.
      Open

              $settingsModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'updateMenu'.
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_Menu_Record_Model' in method 'updateMenu'.
      Open

              $recordModel = Settings_Menu_Record_Model::getInstanceById($data['id']);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Settings_Menu_Record_Model' in method 'updateSequence'.
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'updateSequence'.
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MAP_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Define a constant instead of duplicating this literal "message" 5 times.
      Open

                  'message' => \App\Language::translate('LBL_ITEM_ADDED_TO_MENU', $request->getModule(false)),
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "Integer" 10 times.
      Open

                  'newwindow' => 'Integer',
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "filterId" 7 times.
      Open

                  'filterId' => 'Integer',
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "source" 5 times.
      Open

              $data['source'] = $request->getInteger('source');
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "mdata" 4 times.
      Open

              $data = $request->getMultiDimensionArray('mdata', [
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "success" 5 times.
      Open

                  'success' => true,
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "Alnum" 8 times.
      Open

                  'type' => 'Alnum',
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "dataurl" 5 times.
      Open

                  'dataurl' => 'Url',
      Severity: Critical
      Found in modules/Settings/Menu/actions/SaveAjax.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class Settings_Menu_SaveAjax_Action extends Settings_Vtiger_Basic_Action
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      The class Settings_Menu_SaveAjax_Action is not named in CamelCase.
      Open

      class Settings_Menu_SaveAjax_Action extends Settings_Vtiger_Basic_Action
{
    public function __construct()
    {
        parent::__construct();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'label' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'hotkey' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->exposeMethod('copyMenu');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'module' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->save();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ('CustomFilter' === $data['type'] && \in_array($data['type'], \App\Menu::TYPES)) {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'type' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'dataurl' => 'Url',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'message' => \App\Language::translate('LBL_ITEM_ADDED_TO_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'filters' => ['Integer'],
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->save();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->emit();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->emit();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'filters' => ['Integer'],
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function updateMenu(App\Request $request)
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'dataurl' => 'Url',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'countentries' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->exposeMethod('updateSequence');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($data['filterId']) && empty($data['dataurl'])) {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->exposeMethod('removeMenu');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'icon' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'countentries' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->setResult([
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->set('edit', true);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MAP_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'newwindow' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              );
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $data['dataurl'] = $data['filterId'];
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->setResult([
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              parent::__construct();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              );
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->emit();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'type' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'label' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'success' => true,
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->exposeMethod('updateMenu');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $data = $request->getMultiDimensionArray('mdata', [
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'filterId' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $data['dataurl'] = $data['filterId'];
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  unset($data['filterId']);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'id' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'module' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function removeMenu(App\Request $request)
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Function to trigger copying menu.
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->setResult([
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->emit();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $data['source'] = $request->getInteger('source');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response = new Vtiger_Response();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->initialize($data);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $settingsModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function copyMenu(App\Request $request)
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->exposeMethod('createMenu');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'newwindow' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'role' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'filterId' => 'Integer',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->setResult([
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'success' => true,
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function __construct()
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function createMenu(App\Request $request)
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->initialize($data);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'role' => 'Alnum',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Line exceeds 120 characters; contains 145 characters
      Open

              $recordModel->saveSequence($request->getArray('mdata', 'Text'), Settings_Menu_Record_Model::SRC_ROLE === $request->getInteger('source'));
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'message' => \App\Language::translate('LBL_SAVED_MAP_MENU', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function updateSequence(App\Request $request)
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->saveSequence($request->getArray('mdata', 'Text'), Settings_Menu_Record_Model::SRC_ROLE === $request->getInteger('source'));
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @param \App\Request $request
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $toRole = filter_var($roleTo, FILTER_SANITIZE_NUMBER_INT);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $data = $request->getMultiDimensionArray('mdata', [
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'hotkey' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $data['source'] = $request->getInteger('source');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel = Settings_Menu_Record_Model::getInstanceById($data['id']);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->emit();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'message' => \App\Language::translate('LBL_REMOVED_MENU_ITEM', $request->getModule(false)),
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $roleTo = $request->getByType('toRole', 'Alnum');
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel->copyMenu($fromRole, $toRole, $roleTo);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'icon' => 'Text',
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  unset($data['filterId']);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $response->setResult([
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $settingsModel->removeMenu($request->getArray('mdata', 'Integer'));
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $fromRole = filter_var($request->getByType('fromRole', 'Alnum'), FILTER_SANITIZE_NUMBER_INT);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'success' => true,
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'success' => true,
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  'success' => true,
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ]);
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel = Settings_Menu_Record_Model::getCleanInstance();
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Expected 0 spaces before closing bracket; newline found
      Open

              $data = $request->getMultiDimensionArray('mdata', [
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Expected 0 spaces before closing bracket; newline found
      Open

              $data = $request->getMultiDimensionArray('mdata', [
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      Class name "Settings_Menu_SaveAjax_Action" is not in camel caps format
      Open

      class Settings_Menu_SaveAjax_Action extends Settings_Vtiger_Basic_Action
      Severity: Minor
      Found in modules/Settings/Menu/actions/SaveAjax.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status